- Nov 03, 2010
-
-
rolandsteiner@chromium.org authored
BUG=none TEST=none TBR=dumi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64890 0039d316-1c4b-4281-b951-d872f2087c98
-
chocobo@chromium.org authored
Added handling of network ("service" in flimflam parlance) property changes. NetworkLibrary updates its Network objects in response to property changes, then calls any NetworkObservers that have registered for the given network. Use the is_active member of Network in various places to ensure that we are dealing with the correct network. Created separate observer classes for NetworkManager, Network, and CellularDataPlan, so that monitors can be established independently for each of them. Changed the callback method names to prepend "On", i.e., OnNetworkManagerChanged, OnNetworkChanged, OnCellularDataPlanChanged. Wired up signal strength update and network technology update in the status bar, network dropdown menu, and internet settings page. Added new icon badges for 1xRTT radio technology. These are used when EVDO coverage switches to 1xRTT. Just as is the case for the 3G icons, there are three 1x icons: normal, warn, and error. Please consider these icons to be placeholders if the UI folks think they need to be redesigned. Centralized choosing of the network technology badge in NetworkMenu::BadgeForNetworkTechnology. BUG=chromium-os:5612:chromium-os:7619,chromium-os:5917,chromium-os:4674 TEST=Extensive manual testing with different combinations of wi-fi and cellular networks connected and disconnected. Used a modified version of flimflam that randomly changes reported signal strength, network technology, and roaming state, and verified that the UI correctly reflected current values for the active network (roaming is not handled in the UI at this time). Review URL: http://codereview.chromium.org/4235005 TBR=chocobo@chromium.org Review URL: http://codereview.chromium.org/4229006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64889 0039d316-1c4b-4281-b951-d872f2087c98
-
chocobo@chromium.org authored
Added handling of network ("service" in flimflam parlance) property changes. NetworkLibrary updates its Network objects in response to property changes, then calls any NetworkObservers that have registered for the given network. Use the is_active member of Network in various places to ensure that we are dealing with the correct network. Created separate observer classes for NetworkManager, Network, and CellularDataPlan, so that monitors can be established independently for each of them. Changed the callback method names to prepend "On", i.e., OnNetworkManagerChanged, OnNetworkChanged, OnCellularDataPlanChanged. Wired up signal strength update and network technology update in the status bar, network dropdown menu, and internet settings page. Added new icon badges for 1xRTT radio technology. These are used when EVDO coverage switches to 1xRTT. Just as is the case for the 3G icons, there are three 1x icons: normal, warn, and error. Please consider these icons to be placeholders if the UI folks think they need to be redesigned. Centralized choosing of the network technology badge in NetworkMenu::BadgeForNetworkTechnology. BUG=chromium-os:5612:chromium-os:7619,chromium-os:5917,chromium-os:4674 TEST=Extensive manual testing with different combinations of wi-fi and cellular networks connected and disconnected. Used a modified version of flimflam that randomly changes reported signal strength, network technology, and roaming state, and verified that the UI correctly reflected current values for the active network (roaming is not handled in the UI at this time). Review URL: http://codereview.chromium.org/4235005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64888 0039d316-1c4b-4281-b951-d872f2087c98
-
rolandsteiner@chromium.org authored
remove obsolete entry in webkit/tools/layout_tests/test_expectations.txt add temporary expectation for fast/events/remove-event-listener.html on Mac BUG=none TEST=none TBR=dumi git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64886 0039d316-1c4b-4281-b951-d872f2087c98
-
scherkus@chromium.org authored
Refactored FilterType usage a bit to remove the need to manually associate FilterType values to filter base classes. Patch by acolwell@chromium.org: http://codereview.chromium.org/4176006/show BUG=60778 TEST=media_unittests git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64885 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
When checking "sync everything", only check the other boxes which are visible, otherwise you can get into a situation where you can have nothing visibly checked and succeed through the dialog. BUG=60187 TEST=see bug Review URL: http://codereview.chromium.org/4355001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64884 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
BUG=61510 TEST=New unittests in base_unittests Review URL: http://codereview.chromium.org/4262001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64883 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4371001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64879 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
Implemented VideoReader and VideoWriter for RTP and Protobuf. BUG=53986 TEST=None Review URL: http://codereview.chromium.org/4229003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64878 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
This should fix conflicts like: 2>d:\src\chromium_src2\src\base/string_util.h(480) : error C2904: 'CaseInsensitiveCompare' : name already used for a template in the current scope 2> d:\src\chromium_src2\src\third_party\xulrunner-sdk\win\include\xpcom\nsStringAPI.h(1406) : see declaration of 'CaseInsensitiveCompare' Reported-by:
Jeff Timanus <twiz@google.com> BUG=None TEST=trybots Review URL: http://codereview.chromium.org/4366001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64877 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=61685 TEST=None Review URL: http://codereview.chromium.org/4368001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64876 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64875 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
on each end of the IPC channel. It includes the IPC message definitions. It also includes the base class for the interface proxying, and the core resource and var tracking. BUG=none TEST=none Review=http://codereview.chromium.org/4229002/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64874 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64873 0039d316-1c4b-4281-b951-d872f2087c98
-
dimich@chromium.org authored
Will rebaseline upstream. TBR=rolandsteiner BUG=none TEST=none Review URL: http://codereview.chromium.org/4362002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64872 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64871 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64870 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
on each end of the IPC channel. It includes the IPC message definitions. It also includes the base class for the interface proxying, and the core resource and var tracking. BUG=none TEST=none Review URL: http://codereview.chromium.org/4229002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64869 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@chromium.org authored
Fix for WKBug 47000: a failure mode given bad content (in an unlikely form). The error occurs when an html page is put in an appcache as a fallback resource (so it's listed in a fallback section), but it contains a manifest attribute that refers to a different manifest file. The system should mark the resource as foreign and exclude it from main resource loads, but it was failing to do so. The fix is to do that. BUG=WK47000 TEST=http/tests/appcache/foreign-fallback.html Review URL: http://codereview.chromium.org/3529009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64868 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
BUG=19991 TEST=cert manager no longer has a "people" tab, any certs that were there are now in "other" tab. Review URL: http://codereview.chromium.org/4310004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64866 0039d316-1c4b-4281-b951-d872f2087c98
-
seh@chromium.org authored
BUG=none TEST=Only a problem when uploading to the Web Store. Review URL: http://codereview.chromium.org/4347002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64864 0039d316-1c4b-4281-b951-d872f2087c98
-
dimich@chromium.org authored
TBR=rolandsteiner BUG=none TEST=none Review URL: http://codereview.chromium.org/4324002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64863 0039d316-1c4b-4281-b951-d872f2087c98
-
kkanetkar@chromium.org authored
be created if the path doesn't exist. BUG=None TEST=None Review URL: http://codereview.chromium.org/4350001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64862 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
Callers should append base:: when calling StringPrintV now. BUG=None TEST=locally and trybots Review URL: http://codereview.chromium.org/4296004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64861 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=61611 TEST=Linux file dialogs don't trigger AssertIOAllowed DCHECKs. Review URL: http://codereview.chromium.org/4321003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64859 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
Made failing SwapBuffers not an error. We have a race condition whereby a window can be closed while the GPU process is rendering. This could make ui and browser tests flaky. TEST=try, make sure color channels are not reversed BUG=none Review URL: http://codereview.chromium.org/4281003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64858 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
BUG=57041 TEST=None Review URL: http://codereview.chromium.org/4362001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64853 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 02, 2010
-
-
aa@chromium.org authored
in pure HTML into the extension-based web apps used internally by Chrome. BUG=49233 TEST=unit_tests --gtest_filter=ExtensionFromWebApp.* Review URL: http://codereview.chromium.org/4139008 TBR=aa@chromium.org Review URL: http://codereview.chromium.org/4326002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64851 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
TBR=evan@chromium.org Review URL: http://codereview.chromium.org/4300003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64850 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64847 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
Corruptions can include changes in bucket boundaries, large changes in sample counts (in a bucket), etc. We now detect problems, and don't forward the corrupt data any further. This means it won't exit the renderer and go to the browser if corrupt, and it won't exit the browser and be sent up via UMA if corrupt. IF the would-be corruption is caused by a race to snapshot the data, then a later snapshot should get the clean copy, and all data (across the precluded period) will be sent onward. BUG=61281 r=mbelshe Review URL: http://codereview.chromium.org/4174002 TBR=jar@chromium.org Review URL: http://codereview.chromium.org/4349002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64846 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
in pure HTML into the extension-based web apps used internally by Chrome. BUG=49233 TEST=unit_tests --gtest_filter=ExtensionFromWebApp.* Review URL: http://codereview.chromium.org/4139008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64845 0039d316-1c4b-4281-b951-d872f2087c98
-
dimich@chromium.org authored
TBR=rolandsteiner BUG=none TEST=none Review URL: http://codereview.chromium.org/4343001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64843 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=chromium-os:6497,chromium-os:8574 TEST=all tests should still pass. Review URL: http://codereview.chromium.org/4273003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64841 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
seems to repeatedly querying history during this perf test. So, the biggest gain is made by scaling this back. Here are other tweaks I've made: . decrease the page size/cache size of the two DBs. Now that favicons doesn't store thumbnails the db doesn't need to be so big. . Set a cap to the max number of tmp thumnbails maintains. . Force jpg data vector to be only as big as it needs to be. . Tweak TopSitesCache so it doesn't end up duplicating so many GURLs. This is particularly helpful for long redirect lists. BUG=61487 TEST=none Review URL: http://codereview.chromium.org/4106014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64837 0039d316-1c4b-4281-b951-d872f2087c98
-
asargent@chromium.org authored
BUG=none TEST=This is adding a browser test Review URL: http://codereview.chromium.org/4115005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64835 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Make the content settings bubbles extend down and left (like the bookmarks bubble), not down and right. Also fixes a case of strange indenting in the bookmark bubble code. BUG=none TEST=none Review URL: http://codereview.chromium.org/4296003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64831 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/4233003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64830 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
These files should be part of http://codereview.chromium.org/4123001/, but were missed during the original patch. Contributed by Jianxia Ning <jning@google.com>. BUG=none TEST=none TBR=lzheng@chromium.org Review URL: http://codereview.chromium.org/4349001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64828 0039d316-1c4b-4281-b951-d872f2087c98
-
gspencer@chromium.org authored
For BWSI (incognito) mode, we want to make sure that we don't leak private information between sessions, so we need to have chrome write log output to the tmpfs created for that mode. Also, the chrome log in "logged in" mode should reside in the "log" subdir instead of in the user data dir. BUG=http://crosbug.com/6908 TEST=Ran on device in incognito and regular modes, and watched where log output ended up. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=64638 Review URL: http://codereview.chromium.org/4194005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64826 0039d316-1c4b-4281-b951-d872f2087c98
-