- Jan 07, 2011
-
-
laforge@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70780 0039d316-1c4b-4281-b951-d872f2087c98
-
neb@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/4182010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70779 0039d316-1c4b-4281-b951-d872f2087c98
-
neb@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6072003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70778 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
with them. BUG=none TEST=none Review URL: http://codereview.chromium.org/6135001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70777 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=60090 TEST=On Windows and Mac, when a popup is blocked, there's an animation in the Omnibox. Review URL: http://codereview.chromium.org/6028015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70775 0039d316-1c4b-4281-b951-d872f2087c98
-
jochen@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6153002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70774 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@google.com authored
BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6189001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70771 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6156001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70769 0039d316-1c4b-4281-b951-d872f2087c98
-
asargent@chromium.org authored
Glen got bit by this during development of an extension, where he was expecting that the tab's url would always be defined right away. (Someone filed crbug.com/52195 about this a while back, but I had marked it as WontFix because there are legitimate reasons why the url isn't always set) BUG=none TEST=none Review URL: http://codereview.chromium.org/6193001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70767 0039d316-1c4b-4281-b951-d872f2087c98
-
jorlow@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/6186001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70766 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitbm@google.com authored
Replacing bing.com with search.msn.com (which redirects to bing.com) and word 'instant' to 'chrome instant' fix random failures. Review URL: http://codereview.chromium.org/6170002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70765 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6165001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70763 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
Mostly to pick up a clang warning fix in r425. BUG=68713 TEST=clang bot goes green Review URL: http://codereview.chromium.org/6142005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70759 0039d316-1c4b-4281-b951-d872f2087c98
-
rohitbm@google.com authored
After I watch running test carefully, I found that history page option starts coming into the omnibox, but test count comparison wasn't catching that. So now checking history page option in each waituntil iteration. Review URL: http://codereview.chromium.org/6008012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70758 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
have to repeat the logic for it in a bunch of different places. I had to add another level of variables{} so I could use use_titlecase_in_grd_files in a condition. I also removed some quotes around default values since that seems to be the more common way to express boolean values. BUG=68028 Review URL: http://codereview.chromium.org/6070011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70757 0039d316-1c4b-4281-b951-d872f2087c98
-
panayiotis@google.com authored
Add a checkbox to the malware interstitial page, for user to opt-in to send malware report. The user's choice will be stored as preference in user's profile. Landing original change by kewang: http://codereview.chromium.org/5102001/. BUG=60831 TEST=Relevant unit_tests,browser_tests Review URL: http://codereview.chromium.org/6066011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70755 0039d316-1c4b-4281-b951-d872f2087c98
-
sanjeevr@chromium.org authored
Detailed story: Calls to XPS APIs typically require the XPS provider to be opened with PTOpenProvider. PTOpenProvider calls CoInitializeEx with COINIT_MULTITHREADED. We have seen certain buggy HP printer driver DLLs that call CoInitializeEx with COINIT_APARTMENTTHREADED in the context of PTGetPrintCapabilities. This call fails but the printer driver calls CoUninitialize anyway. This results in the apartment being torn down too early and the msxml DLL being unloaded which in turn causes code in unidrvui.dll to have a dangling pointer to an XML document which causes a crash. To protect ourselves from such drivers we make sure we always have an extra CoInitialize (calls to CoInitialize/CoUninitialize are refcounted). BUG=None TEST=Test Cloud Print Proxy on Windows with HP Photosmart 7960 series printers. Review URL: http://codereview.chromium.org/6037019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70754 0039d316-1c4b-4281-b951-d872f2087c98
-
georgey@chromium.org authored
BUG=66111 TEST=in the bug, no code changes Review URL: http://codereview.chromium.org/6161001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70753 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
BUG=68030 TEST=See bug Review URL: http://codereview.chromium.org/6119002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70752 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
Make sure we don't trigger the incompatibility badge if the flag is turned off when the user navigates to about:conflicts and finds a conflict. Also, record an event when we show the incompatibilities badge to the user so we can find out how often this occurs in the field. BUG=None TEST=None Review URL: http://codereview.chromium.org/6061011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70751 0039d316-1c4b-4281-b951-d872f2087c98
-
georgey@chromium.org authored
BUG=68588 TEST=Should not crash in described circumstances Review URL: http://codereview.chromium.org/6134002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70750 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@google.com authored
A lot of our headers are a mess and aren't organized. Impose the following order on files in the base/ directory: class Blah { each public/protected/private section: typedefs; enums; static constants; ctors; dtors; methods; overridden virtual methods; data members; }; BUG=68682 TEST=compiles Review URL: http://codereview.chromium.org/6081007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70749 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70748 0039d316-1c4b-4281-b951-d872f2087c98
-
http://codereview.chromium.org/6094009kbr@google.com authored
Perform GPU-related initialization in GPU process in response to an IPC from the browser. Because Chromium's child process host detects that the child has crashed by watching for IPC channel errors, it is imperative that the GPU process's IPC channel be set up before it does any work that might cause it to crash. If initialization fails, the GPU process quits its message loop and cooperatively exits. Fixed a bug in the GpuProcessHost where it would not unblock renderers waiting for GPU process initialization if the GPU process exited. BUG=65369 TEST=ran test case from bug on machine with no GPU hardware and verified that it no longer hangs the renderer, and that the GPU process exits Review URL: http://codereview.chromium.org/6124002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70747 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
The goal of this refactoring is to make it easy to swap AutocompleteEditView implementation between Gtk based impl and Views based one. This is 1st phrase and there will be more refacotring needed to implement AutocompleteEditViewViews. - Added factory method AutocompleteEditViewGtk::Create, which hides initialization details for gtk based impl. - Moved gtk specific accessibilty code to AutocompleteEditViewGtk. - Added TOOLKIT_VIWES only methods to AutocompleteEditView to hide platform specific implementation. (AddToView, CommitInstatntSuggestion/SetInstantSuggestion) BUG=none TEST=none no functional change. all tests should pass. Review URL: http://codereview.chromium.org/6036004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70746 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70745 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70744 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
BUG=none TEST=none TBR=brettw Review URL: http://codereview.chromium.org/6154001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70743 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
from downstream test_expectations. BUG=none TEST=layout tests TBR=jorlow Review URL: http://codereview.chromium.org/6163002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70742 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
far to the right. BUG=66713 TEST=see bug Review URL: http://codereview.chromium.org/6023014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70741 0039d316-1c4b-4281-b951-d872f2087c98
-
cbentzel@chromium.org authored
These didn't turn out to be terribly useful, and add some complexity to HttpAuthHandler. BUG=NONE TEST=targets build Review URL: http://codereview.chromium.org/6103003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70740 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
unnecessary overrides in instant's TabContentsDelegate implementation. BUG=68540 TEST=see bug Review URL: http://codereview.chromium.org/6152001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70739 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
This reverts commit r70714 which was a suppression for a bug fixed in r70737. BUG=68820 TEST=valgrind git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70738 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
I'm too used to callbacks which delete themselves and forgot to delete it myself in r70631. BUG=68820 TEST=valgrind git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70737 0039d316-1c4b-4281-b951-d872f2087c98
-
jorlow@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/6110002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70736 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
BUG=none TEST=none TBR=finnur Review URL: http://codereview.chromium.org/6176002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70735 0039d316-1c4b-4281-b951-d872f2087c98
-
jknotten@chromium.org authored
Remove unnecessary methods GeolocationPermissionContext::StartUpdatingRequested and GeolocationPermissionContext::StopUpdatingRequested Remove the unused bridge_id from IPC messages ViewHostMsg_Geolocation_StartUpdating ViewHostMsg_Geolocation_StopUpdating. Remove unnecessary / unused IPC messages: ViewHostMsg_Geolocation_RegisterDispatcher ViewHostMsg_Geolocation_UnregisterDispatcher ViewHostMsg_Geolocation_Suspend ViewHostMsg_Geolocation_Resume Rename GeolocationDispatcherHost::bridge_update_options_ to renderer_update_options, and simplify map type to key only on render id, since there is no relevant bridge id. BUG=59907 TEST=Existing Review URL: http://codereview.chromium.org/6127001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70734 0039d316-1c4b-4281-b951-d872f2087c98
-
satish@chromium.org authored
BUG=none TEST=Start speech input and close tab with keyboard before the UI comes up, check for crashes. Review URL: http://codereview.chromium.org/6115001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70733 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70729 0039d316-1c4b-4281-b951-d872f2087c98
-
finnur@chromium.org authored
Add column header for data. Move the Learn more link to appear last. BUG=51105 TEST=None Review URL: http://codereview.chromium.org/5981012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70727 0039d316-1c4b-4281-b951-d872f2087c98
-