This also fixes some lines over 80 chars, and converts a file to using the standard license header (I verified that the existing long-form license was exactly the same as the one in LICENSE).

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3918001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63149 0039d316-1c4b-4281-b951-d872f2087c98

put them in the base namespace.

TEST=it compiles
BUG=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62510 0039d316-1c4b-4281-b951-d872f2087c98

ASCIIToUTF16. I removed string_util includes from a few places where it
obviously wasn't needed.

In a separate pass, I'm going to remove ASCIITo* from string_util, then I'm
going to do an even later pass to find the unnecessary string_util.h includes
and remove them.

TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3058027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54746 0039d316-1c4b-4281-b951-d872f2087c98

Use the base namespace in the new file. Update callers.

I removed all wstring variants and also the string->number ones that ignore the return value. That encourages people to write code and forget about error handling.

TEST=included unit tests
BUG=none

Review URL: http://codereview.chromium.org/3056029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@54355 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2813042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@51554 0039d316-1c4b-4281-b951-d872f2087c98

TODO: Fix the remaining usages in third_party libraries and get rid of the macro in question.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/2657005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@49032 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41559 0039d316-1c4b-4281-b951-d872f2087c98

breaks dependencies on chrome from webkit, app, views
and base.

BUG=37649
TEST=compiles
Review URL: http://codereview.chromium.org/699001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41001 0039d316-1c4b-4281-b951-d872f2087c98

The use of * in the dependencies makes memory_watcher depend on all targets in app.gyp, both 32-bit and 64-bit. Clearly, 32-bit targets should not depend on 64-bit targets.

BUG=none
TEST=build memory_watcher on Windows
Review URL: http://codereview.chromium.org/486024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@34365 0039d316-1c4b-4281-b951-d872f2087c98

When releasing the lock, I incorrectly set the thread owner for the lock
to the current thread, rather than resetting it to zero.  The result is that
some number of stacks were not being recorded into the stack map (because
the recursion blocking logic aborted the attempt to gather the lock).

If I ever do a recursive acquisition (i.e., my logic is faulty), then
an assertion will fire in the Acquire() for the lock.  This in turn
guarantees that when I Release() the lock, it was not a (windows
allowed) recursive acquisition of the lock, and hence the
thread owning the lock should indeed be zeroed.

r=mbelshe
Review URL: http://codereview.chromium.org/443009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@33140 0039d316-1c4b-4281-b951-d872f2087c98

v8 proved to be a very coarse bucket, and was too high up.
I've added several buckets, and put in a section for drilling
down on a specific bucket (contributions over a specific value).

r=mbelshe
Review URL: http://codereview.chromium.org/376003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31435 0039d316-1c4b-4281-b951-d872f2087c98

This version of memory_watcher can run under Vista, even though the
recursive calls that it handles are appearing often enough that there
is a performance penalty.  With this landed, it may be possible for other
folks to run the tool, and I can work on improving its performance.

This CL also resolves the problem with hanging processes.  Although
memory reporting can only be done once, and it leaves a pile of memory
"hanging around," the browser can be cleanly exited.

Tweaks include outputing the aggregate stacks such that the largest
stacks appear at the start of the output file.

This version avoids ongoing aggregation of stats in favor of only
doing the aggregation at dump-time.  This probably enhances performance
at run-time, although it is hidden (on Vista) by the recursive calling.
This also simplifies the tracking code a fair amount.

There is some evidence that a small number of duplicate calls are being
made to "track" the same memory region, without an intervening free (i.e.,
call to "untrack").  The code to better diagnose this is currently in
place, but ifdef'ed, as it is only useful under a debugger.  Exercise
of this code (turning a stack-frame list into a human readable stack
trace string) currently causes some corruption shortly after it triggers,
so I can't leave it on full time.


r=mbelshe
Review URL: http://codereview.chromium.org/366031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@31299 0039d316-1c4b-4281-b951-d872f2087c98

The results are now sorted before being output, so there is no need
to pass the results through a sort filter.

Byte counts are now printed with comma separators between groups of
3 digits, so that 1234567 is now output as 1,234,567.

The summary.pl now has a number of more precise matches to better 
give a quick estimate of blame for each allocation stack.


r=mbelshe
Review URL: http://codereview.chromium.org/348034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30673 0039d316-1c4b-4281-b951-d872f2087c98

I removed a leak of "stack" objects, and made them a little
more lightweight by removing an unused member.

This change is only part of an option for chrome, that is not currently
linked in during any tests.  It can only currently be used under XP, so
build-bot tests are not currently appropriate.

r=mbelshe
Review URL: http://codereview.chromium.org/345033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30672 0039d316-1c4b-4281-b951-d872f2087c98

With the previous patch, the try bots failed with mysterious messages, so I ignored them, patched it into my windows box and tested it there manually, and found no problems. As it turns out, the try failures were real :(. But nsylvain and I found the problem: the behavior of file_util::GetDirectoryFromPath() differs from DirName() when the path is empty (officially, GetDirectoryFromPath is not supposed to support non-absolute paths, but that is not enforced).

Here is a green win try result: http://build.chromium.org/buildbot/try-server/builders/win/builds/3705
mac: http://build.chromium.org/buildbot/try-server/builders/mac/builds/3491
linux: http://build.chromium.org/buildbot/try-server/builders/linux/builds/3466

I also applied this patch locally in Windows to test that it doesn't break the chrome frame compile or tests, since that's not covered by the trybots yet.
Review URL: http://codereview.chromium.org/271099

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29094 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nsylvain

Review URL: http://codereview.chromium.org/280004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29085 0039d316-1c4b-4281-b951-d872f2087c98

death to the wstring

TEST=trybots
BUG=none

Review URL: http://codereview.chromium.org/276016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29078 0039d316-1c4b-4281-b951-d872f2087c98

Replace it with base_i18n which encapsulates all ICU dependencies.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/267048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@29036 0039d316-1c4b-4281-b951-d872f2087c98

app/gfx in preparation for removing the base_gfx project. This also moves
base/window_impl.cc to app/win/window_impl because this file shouldn't be in
base.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/273017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=successful builds
Review URL: http://codereview.chromium.org/256059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28089 0039d316-1c4b-4281-b951-d872f2087c98

Why: Simpler build code. If everybody includes it, it should be included automatically.
Why now: The webkit chromium builds need it be specified, since can't default to build/common.gypi.

What was done:
1. build/common.gypi's contents were moved to a new file build/gyp_chromium.gypi
2. tools/gyp/gyp_chromium was moved to build/gyp_chromium and made to automatically include build/gyp_chromium.gypi.
3. lots of gyp files were fixed to not refer to build/common.gypi any more.
4. o3d which also builds independently of chrome, was fixed to have a gyp_o3d that includes gyp_chromium.gypi too.
5. build/common.gypi was left empty, because there are some external projects that still refer to it.

Things that are left to do after this patch is in:
1. The following external files (in other repositories) need to stop include common.gypi
  ./third_party/hunspell/hunspell.gyp
  ./third_party/icu/icu.gyp
  ./v8/tools/gyp/v8.gyp
2. Once nobody refers to common.gypi anymore, delete common.gypi
   -or-
   Delete gyp_chromium.gypi and move its content back to common.gypi

Tested on mac, win and linux. On win, got a few unit tests errors on chrome bookmarks, which should not be related. I'm running again with clobber to verify.

Review URL: http://codereview.chromium.org/206006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26302 0039d316-1c4b-4281-b951-d872f2087c98

BUG=5027
TEST=none
Review URL: http://codereview.chromium.org/196081

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25925 0039d316-1c4b-4281-b951-d872f2087c98

svn:ignore gyp-generated memory_watcher.{sln,vcproj}.
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/118026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17232 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113957

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17090 0039d316-1c4b-4281-b951-d872f2087c98

* activex_test_control.dll
* browser_tests.dll
* browser_tests.exe
* memory_watcher.dll
* rlz.dll
* security_tests.dll
* test_chrome_plugin.dll
* themes/default.dll
BUG=none
TEST=none
Review URL: http://codereview.chromium.org/113915

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17023 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/43148

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11590 0039d316-1c4b-4281-b951-d872f2087c98

Normalize end of file newlines in build/ media/ printing/ testing/ and tools/.  All files end in a single newline.

Review URL: http://codereview.chromium.org/43082


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11449 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10982 0039d316-1c4b-4281-b951-d872f2087c98

dynamic font support.

This is a re-run of http://codereview.chromium.org/14908/show (except that chrome_dll.deps file which needs to be updated along with the actual code change)

This will be followed by http://codereview.chromium.org/16494 (actual webkit code change) and changes in webkit/build

BUG=1303


Review URL: http://codereview.chromium.org/16496

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7520 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nsylvain

Review URL: http://codereview.chromium.org/17021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7501 0039d316-1c4b-4281-b951-d872f2087c98

SDK upgrade is necessary to support dynamic/webfont because SDK 6.0 does not have
t2embapi.h and t2embed.lib. SDK 6.1 is compatible with WIn XP and VS 2005 or later.

FYI:
http://codereview.chromium.org/14084/show is the CL for adding web/dynamic font support. 
Review URL: http://codereview.chromium.org/14908

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7500 0039d316-1c4b-4281-b951-d872f2087c98

Patch fails otherwise on non-Windows platforms.
Review URL: http://codereview.chromium.org/14478

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@7093 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/13133

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@6372 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/11544


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@5880 0039d316-1c4b-4281-b951-d872f2087c98

Ran dos2unix on *.cc, *.h, *.py and SCons*.*
Ran for /R /D %a in (*.*) do @if exist %a\.svn\. svn pset svn:eol-style LF %a\*.cc
Ran for /R /D %a in (*.*) do @if exist %a\.svn\. svn pset svn:eol-style LF %a\*.h
Ran for /R /D %a in (*.*) do @if exist %a\.svn\. svn pset svn:eol-style LF %a\*.py
Ran for /R /D %a in (*.*) do @if exist %a\.svn\. svn pset svn:eol-style LF %a\SCons*.*



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2611 0039d316-1c4b-4281-b951-d872f2087c98

Provide necessary constructors in StackAllocator and PrivateHookAllocator to permit release mode building in VC++2008 SP1. The current allocators do not conform with the C++ spec for allocators, and unlike previous versions, VC++2008 requires conformant allocators.

The reason that the allocators are not conformant is that any allocator, say, template<typename T> struct Alloc; must have a constructor of the following form:
template<typename U> Alloc(const Alloc<U>& other)
to allow construction of an Alloc<T> from an Alloc<U>.  The constructors cannot be explicit, because they're (essentially) copy constructors, and so are not called explicitly.

StackAllocator has no converting copy constructor at all, and PrivateHookAllocator's is declared explicit, preventing it from being usable.

Without the StackAllocator constructor, StackVectors fail (due to the std::vector member, base\stack_container.h(216)).

Patch by Peter Bright <drpizza@quiscalusmexicanus.org>.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@2175 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@1287 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@623 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@615 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17 0039d316-1c4b-4281-b951-d872f2087c98