BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/6040002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70286 0039d316-1c4b-4281-b951-d872f2087c98

As described in the bug, the current behavior is confusing and bug-prone.

BUG=47194
TEST=Check that there are no visible regressions in RTL and LTR language UIs on Linux & Windows.

Review URL: http://codereview.chromium.org/5154009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67237 0039d316-1c4b-4281-b951-d872f2087c98

In the browser, duplicate the file mapping handle before sending to the
renderer and map the TransportDIB before accessing the memory. In the
renderer, do not map the file twice, which was happening when
TransportDIB::Map and GetPlatformCanvas were both being called.
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4569002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65775 0039d316-1c4b-4281-b951-d872f2087c98

Move windows version-related stuff out of base/win_util and into base/win/windows_version. Many files now only need to include this instead of all of win_util.

Remove a bunch of unused code from base/win_util. There was a surprising amount.

Replace the AppUserModel property key with the one from the SDK now that we use the Win7 SDK. Move GetLogonSessionOnlyDACL from win_util to ipc since it's only used in that one place.

TEST=it compiles
BUG=none
Review URL: http://codereview.chromium.org/3823002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@62694 0039d316-1c4b-4281-b951-d872f2087c98

This change caused too many layout problems; such as Issue 50100 and 51562. I would like to revert this change now and send another change when I fix them.

When launching an application on the text size larger than 120 DPI, Windows runs the application on the DPI-virtualization mode to hide the text size from it. Unfortunately, this virtualization mode causes some problems when using a custom frame, such as we cannot click system buttons. To fix this issue, this change disables the DPI-virtualization mode on Vista or later.

BUG=1715,36939
TEST=Run chrome.exe on the screen resolution higher than 120 DPI.
Review URL: http://codereview.chromium.org/2867031

TBR=hbono@chromium.org
Review URL: http://codereview.chromium.org/3435002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@59353 0039d316-1c4b-4281-b951-d872f2087c98

gfx::Font is a platform-neutral API shim that exists as a wrapper object to allow for the creation and lifetime of gfx::Font objects to remain consistent with past usage.

gfx::PlatformFont is an interface implemented by the platform-specific inner classes (gfx::PlatformFontWin,Mac,Gtk).

BUG=none
TEST=existing unittests

Review URL: http://codereview.chromium.org/3083022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/3071012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55034 0039d316-1c4b-4281-b951-d872f2087c98

When launching an application on the text size larger than 120 DPI, Windows runs the application on the DPI-virtualization mode to hide the text size from it. Unfortunately, this virtualization mode causes some problems when using a custom frame, such as we cannot click system buttons. To fix this issue, this change disables the DPI-virtualization mode on Vista or later.

BUG=1715,36939
TEST=Run chrome.exe on the screen resolution higher than 120 DPI.
Review URL: http://codereview.chromium.org/2867031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@52446 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1073005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42182 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42071 0039d316-1c4b-4281-b951-d872f2087c98

TBR=darin
BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41911 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/858006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@41401 0039d316-1c4b-4281-b951-d872f2087c98

Issue 32106 happens when user creates a browser window without creating
desktop shortcut. In this case, Windows does not have sufficient
relaunching info to support pinning the browser window. The fix is to
create a shortcut in "User Pinned" folder which Win7 watches and would
get relaunch info from it.

Also fix a minor bug in win_util::SetAppIdForWindow that would make the
function only work for Win7 but not above.

BUG=32106
TEST=Verify fix for 32106. See comemnts #1 and #5 for repro steps.

Review URL: http://codereview.chromium.org/660038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@39963 0039d316-1c4b-4281-b951-d872f2087c98

Split win_util.cc - we need ConvertToLongPath in the 64-bit Windows build, but would like to avoid the dependencies that would be added by including the whole win_util.cc file
Review URL: http://codereview.chromium.org/536028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@36494 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow up change after andrew's patch for win7 shortcut to
properly set app id for chromium/application shortcut.
- Move PKEY_AppUserModel_ID and code to set it from app/win_util.cc to
  base/win_util.cc as SetAppIdForPropertyStore to share with file_util
  shortcut code;
- Add an app_id args to file_util's CreateShortcutLink and
  UpdateShortcutLink;
- Update code that calls the above two function in installer and
  UserDataManager so that the chromium shortcuts are created with proper
  app id (except the uninstall shortcut which is not tagged with any app
  id).
- Move ComputeApplicationNameFromURL from Browser to web_app namespace
  and use it as app id for application shortcut. This makes pinned
  shortcut and browser window use the same app id and Win7 correctly
  groups them;

- Rename ComputeApplicationNameFromURL to GenerateApplicationNameFromURL
  per Ben's comments;

- Add a DCHECK in SetAppIdForPropertyStore to ensure app id is less than
  128 chars and contains no space per msdn;
- Change default app id from IDS_PRODUCT_NAME to chrome::kBrowserAppName

BUG=28104
TEST=On Win7, pinned shortcut should no longer be separated from running instance of chrome for both chrome and web application.

Review URL: http://codereview.chromium.org/399045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@32508 0039d316-1c4b-4281-b951-d872f2087c98

native_theme to native_theme_win since its Windows-specific.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/259047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@28300 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/251086

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@27931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=7246
TEST=Download a file with an unknown extension using the "Save as"
     option. The Save As dialog will populate the "Save Type" combo
     box with the unknown type and "All Files", instead of just
     "All files".

Review URL: http://codereview.chromium.org/202032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26160 0039d316-1c4b-4281-b951-d872f2087c98

BUG=5027
TEST=none
Review URL: http://codereview.chromium.org/171129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25298 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Patch contributed by thiago.farina@gmail.com
Review URL: http://codereview.chromium.org/173260

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@24859 0039d316-1c4b-4281-b951-d872f2087c98

This is a follow-up change for r21596.
It seems this change forgot calling pps->Release() and PropVariantClear(&pv). (InitPropVariantFromString() calls SHStrDupW() to create a copy of its input string, so we have to call PropVariantClear() and delete it.)
To avoid an object leak and a memory leak, this change uses ScopedComPtr<IPropertyStore> to call Release() in its destructor and call PropVariantClear() to clean-up PROPVARIANT.
(My JumpList class uses a class which encapsulates PROPVARIANT. We should move the class to win_util?)

BUG=none
TEST=none (Run Chromium on purify running on Windows 7.)
Review URL: http://codereview.chromium.org/160150

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21830 0039d316-1c4b-4281-b951-d872f2087c98

Partial fix to 7028 - Pinning in Win7.A complete fix will require Gears to set the application id as a property on the shortcut  As of this cl, web applications hosted by Chrome will appear in their own groups on the task bar.  However, they can not be pinned from the main application window nor can they be pinned from the shortcut.  The former results in Chrome being pinned, and the latter results in a quick start button but does not group web applications under that button.  Instead in the latter case a web appliation will form a new group.

Bug=7028
Test=None.  (When there is a Win7 trybot there may be at test to check if the windows group in the taskbar properly)
Review URL: http://codereview.chromium.org/159336

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@21595 0039d316-1c4b-4281-b951-d872f2087c98

extension developers who want to package extensions as part of a build script
and aren't there to click the message box.

R=aa,jackson
BUG=14732
TEST=Pack an extension with the --no-message-box flag and notice that there is no message box.

Review URL: http://codereview.chromium.org/149795

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@20937 0039d316-1c4b-4281-b951-d872f2087c98

BUG=12299
TEST=1) right click/save as on some image. Clicking on the download item's filename area should launch it in some image viewer (assuming xdg-open works for you---as it happens, ubuntu broke xdg-open for desktops that are not gnome, kde, or xfce). 2) Download a large file. Click on the download item before it is finished. The text should change to "opening in..." and the checkbox in the dropdown menu should show as checked. 3) completed downloads should have the "open when finished" menu item replaced by the "open" menu item. Selecting that should also open the download.
Review URL: http://codereview.chromium.org/112064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17106 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/11387

Review URL: http://codereview.chromium.org/113565

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16361 0039d316-1c4b-4281-b951-d872f2087c98

Does not rename the files yet.

http://crbug.com/11387

Review URL: http://codereview.chromium.org/113441

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@16141 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/11387

Review URL: http://codereview.chromium.org/113169

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15694 0039d316-1c4b-4281-b951-d872f2087c98

http://crbug.com/11387
Review URL: http://codereview.chromium.org/109043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@15352 0039d316-1c4b-4281-b951-d872f2087c98

Properly construct shell filters (forgetting the asterisk means it works but doesn't show existing files).

BUG=10734

Review URL: http://codereview.chromium.org/93019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@14202 0039d316-1c4b-4281-b951-d872f2087c98

Two fixes here. First was a disturbing discovery that FilePath::Extension returns an extension starting with a period. I am of the belief that this is the wrong API to expose, but that's a different fight. Fixed.

Second is a subtle behavior of the old code that wasn't preserved. In the case where the extension did not exist in the registry, the old code dropped the extension from the filter. We now also do so.

BUG=10561

Review URL: http://codereview.chromium.org/79045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13960 0039d316-1c4b-4281-b951-d872f2087c98

Reorganize fullscreen mode handling.  Now nearly everything is in WindowWin.  This also includes work area change notifications, which only really apply to Windows (and not pure Widgets) anyway.  Some parts (namely, the browser-specific things) are still in BrowserView.This allows me to fix the bug where unlocking your screen resized fullscreen mode windows incorrectly.There are probably one or two other small bits tangled in here -- this got a bit messy.  I moved the exit bubble out of browser/ because it wasn't browser-specific; in theory, any WindowWin can now go into fullscreen mode.BUG=8159
Review URL: http://codereview.chromium.org/78002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13908 0039d316-1c4b-4281-b951-d872f2087c98

For some Indian locales, the automatic font fallback by Windows UI components leads to too tiny glyphs for UI strings.  Therefore, this patch makes it possible to override the UI font family and UI font size localizable by adding two entries to locale_settings (IDS_UI_FONT_FAMILY and IDS_UI_FONT_SIZE_SCALER - percentile scale).

It's is also to fix a P1 bug for Chrome 2.0 final (so this patch needs to be merged back to the branch).

For most locales, the UI font family is set to 'default' and the UI font size scaler is set to 100, which indicates that the UI font (menu, message, etc) obtained from Windows will be used. 

For ml and bn, it's set to the 'kartica' and 'vrinda' (the default Windows fonts for those scripts) and the scaler is set to 150 and 160 respectively. For Hindi and Telugu, only the font size scaler is set to 150. 

When IDS_UI_FONT_FAMILY is 'default' and the scaler is 100, the behavior will remain the same. When it's not, their values are used to create ChromeFont (base and derived) and WindowsTitle font. In addition, menu will be drawn by 'owner' (to override the windows font) and the font for table view, tree and tooltip is also set to IDS_UI_FONT_FAMILY. 

While working on this, I replaced all the instances of 'static ChromeFont' with 'static ChromeFont*' and initialized them in a lazy manner.

The whole approach is still a hack necessary due to the size issue with the default fonts for some Indic scripts on Windows. We'd not need this on Linux and Mac. 

TEST=1. Run chrome with '--lang=bn' or '--lang=ml' and see UI strings are legible in menu, context menu, bookmark, bookmark manager, tooltips, and tab titles. With '--lang=hi' and '--lang=te', the difference is not dramatic but should be more readable. In other locales, it should remain the same. 
2.UI test in en-US locale should pass.
3. Running UI tests under Purify should not have any new leak.

BUG=7319
Review URL: http://codereview.chromium.org/62064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13773 0039d316-1c4b-4281-b951-d872f2087c98

Don't reserve space for an auto-hide taskbar that's not always-on-top.  Windows native behavior is to cover these.

BUG=9976
Review URL: http://codereview.chromium.org/66055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13683 0039d316-1c4b-4281-b951-d872f2087c98

Refactoring; switch the |filter| parameter into something that is more amenable to cross-platform implementation.

BUG=9852

Review URL: http://codereview.chromium.org/63093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13573 0039d316-1c4b-4281-b951-d872f2087c98

the bug is not there either.

Review URL: http://codereview.chromium.org/56033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@13143 0039d316-1c4b-4281-b951-d872f2087c98

save dialog on Windows 7.

BUG: 8409
Review URL: http://codereview.chromium.org/42666

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12621 0039d316-1c4b-4281-b951-d872f2087c98

Note that this only works if you are using a gnome or kde session. Support for other sessions will be added in the future.


Review URL: http://codereview.chromium.org/52034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@12395 0039d316-1c4b-4281-b951-d872f2087c98

This is very similar to r10845, but also includes a regression fix for issue 8410, where locking and unlocking the screen would cause mispositioning of child content.

BUG=20,8410

Review URL: http://codereview.chromium.org/42027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11355 0039d316-1c4b-4281-b951-d872f2087c98

Fix files with lines > 80 cols. Part 2.
Review URL: http://codereview.chromium.org/40226

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11326 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@11284 0039d316-1c4b-4281-b951-d872f2087c98