BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4685001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65374 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65373 0039d316-1c4b-4281-b951-d872f2087c98

it doesn't crash if the SSLClientSocket is leaked.

BUG=chromium-os:8179
TEST=None

Linux browser tests are consistently failing.  Example stack:

SSLUITest.TestDisplaysInsecureContentTwoTabs: 
[11279:11279:1107/212311:929558354690:WARNING:chrome/installer/util/master_preferences.cc(56)] Failed to read master prefs file. 
[11279:11279:1107/212311:929558354814:ERROR:chrome/installer/util/master_preferences.cc(137)] Failed to parse /mnt/data/build/slave/Linux_Builder__Views_dbg_/build/src/out/Debug/master_preferences
[11279:11279:1107/212311:929558672237:WARNING:views/widget/widget_gtk.cc(293)] compositing not supported; allowing anyway
LEAK: 4 WebCoreNode
[11279:11291:1107/212312:929559555051:FATAL:base/message_loop.cc(200)] Check failed: this == current(). 
Backtrace:
	base::debug::StackTrace::StackTrace() [0x124edb6]
	logging::LogMessage::~LogMessage() [0x126455b]
	MessageLoop::RemoveDestructionObserver() [0x126695d]
	net::CertVerifier::Request::Cancel() [0x1944eb5]
	net::CertVerifier::Request::~Request() [0x194505a]
	base::RefCountedThreadSafe<>::DeleteInternal() [0x194544c]
	base::DefaultRefCountedThreadSafeTraits<>::Destruct() [0x1945420]
	base::RefCountedThreadSafe<>::Release() [0x19452ec]
	RunnableMethodTraits<>::ReleaseCallee() [0x1945628]
	RunnableMethod<>::ReleaseCallee() [0x194559c]
	RunnableMethod<>::~RunnableMethod() [0x19454ce]
	(anonymous namespace)::WorkerThread::ThreadMain() [0x12c904f]
	ThreadFunc() [0x12860bf]
	start_thread [0x2afc1af6d9ca]
	0x2afc1d5156fd

[11279:11291:1107/212312:929559555051:FATAL:base/message_loop.cc(200)] Check failed: this == current(). 
Backtrace:
	base::debug::StackTrace::StackTrace() [0x124edb6]
	logging::LogMessage::~LogMessage() [0x126455b]
	MessageLoop::RemoveDestructionObserver() [0x126695d]
	net::CertVerifier::Request::Cancel() [0x1944eb5]
	net::CertVerifier::Request::~Request() [0x194505a]
	base::RefCountedThreadSafe<>::DeleteInternal() [0x194544c]
	base::DefaultRefCountedThreadSafeTraits<>::Destruct() [0x1945420]
	base::RefCountedThreadSafe<>::Release() [0x19452ec]
	RunnableMethodTraits<>::ReleaseCallee() [0x1945628]
	RunnableMethod<>::ReleaseCallee() [0x194559c]
	RunnableMethod<>::~RunnableMethod() [0x19454ce]
	(anonymous namespace)::WorkerThread::ThreadMain() [0x12c904f]
	ThreadFunc() [0x12860bf]
	start_thread [0x2afc1af6d9ca]
	0x2afc1d5156fd

Killed (timed out).

Review URL: http://codereview.chromium.org/4299001

TBR=zork@chromium.org
Review URL: http://codereview.chromium.org/4669003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65372 0039d316-1c4b-4281-b951-d872f2087c98

Adding ScopedAllowIO to GetRlzParameterValue() while we evaluate wether the access to IO is ok here.

TBR=jochen
BUG=62337
TEST=None

Review URL: http://codereview.chromium.org/4686001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65371 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62314
TBR=glider
Review URL: http://codereview.chromium.org/4682001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65370 0039d316-1c4b-4281-b951-d872f2087c98

TBR=rogerta
BUG=http://crbug.com/62328
TEST=None

Review URL: http://codereview.chromium.org/4680001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65369 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/51105, http://crbug.com/57239
TEST=Unit tests included.

Review URL: http://codereview.chromium.org/4524002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65366 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65364 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4276004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65362 0039d316-1c4b-4281-b951-d872f2087c98

- KeyboardAccessTest.TestShiftAltMenuKeyboardAccess
- KeyboardAccessTest.ReserveKeyboardAccelerators
- CollectedCookiesTest.DoubleDisplay
- CollectedCookiesTest.NavigateAway
- TabDraggingTest.Tab1Tab2
- TabDraggingTest.Tab1Tab3
- TabDraggingTest.Tab2OutOfTabStrip
- NotificationsPermissionTest.TestUserGestureInfobar
- NotificationsPermissionTest.TestNoUserGestureInfobar

TBR=hbono, pkasting, jochen, sidchat, johnnyg

BUG=62311
TEST=interactive_ui_tests

Review URL: http://codereview.chromium.org/4676001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65360 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62314
TEST=Valgrind&TSan mac bots should go green
TBR=glider
Review URL: http://codereview.chromium.org/4675001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65359 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=dumi

Review URL: http://codereview.chromium.org/4672001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65358 0039d316-1c4b-4281-b951-d872f2087c98

TEST=TSan bots on the memory waterfall should remain green
Review URL: http://codereview.chromium.org/4671001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65357 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62314
TBR=glider
TEST=Valgrind&TSan Mac bots should go green
Review URL: http://codereview.chromium.org/4670001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65356 0039d316-1c4b-4281-b951-d872f2087c98

- KeyboardAccessTest.TestMenuKeyboardAccess
- KeyboardAccessTest.TestAltMenuKeyboardAccess

TBR=dmazzoni

BUG=62310
TEST=interactive_ui_tests

Review URL: http://codereview.chromium.org/4669001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65355 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=dumi

Review URL: http://codereview.chromium.org/4666001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65354 0039d316-1c4b-4281-b951-d872f2087c98

(with a couple of minor whitespace fixes).

Without this fix, the status was only passed when network update event
happened and you would see the wrong "Enable Wifi" button even when
Wifi is actually enabled.

BUG=chromium-os:8196
TEST=login with Wifi enabled and open chrome://settings => internet and see if the "Disable Wifi" button appears properly.

Review URL: http://codereview.chromium.org/4572001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65352 0039d316-1c4b-4281-b951-d872f2087c98

it doesn't crash if the SSLClientSocket is leaked.

BUG=chromium-os:8179
TEST=None

Review URL: http://codereview.chromium.org/4299001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65349 0039d316-1c4b-4281-b951-d872f2087c98

badly.

BUG=62127
TEST=Added by Andrew

Review URL: http://codereview.chromium.org/4619001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65346 0039d316-1c4b-4281-b951-d872f2087c98

Based on a combination of the malware pages and the link
doctor page.

Also removes the "more details" expander.  Inlines the
details using a lighter font color instead.

Screenshots:
https://docs3.google.com/document/d/1GdqTtkl_gjWg1GYRNxBGToy63mwEHCAZlXGKHCk_wYw/edit?hl=en#

BUG=59096
TEST=Manual


Review URL: http://codereview.chromium.org/4464005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65344 0039d316-1c4b-4281-b951-d872f2087c98

  - total_op_b went up around r65182, bug for that
    is 62272

  - total_byte_r and total_byte_b went up around r64763,
    bug for that is 62274.

BUG=62272, 62274
TEST=xp perf is green
TBR=nsylvain@chromium.org

Review URL: http://codereview.chromium.org/4652001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65343 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=build

Review URL: http://codereview.chromium.org/4121004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65338 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65334 0039d316-1c4b-4281-b951-d872f2087c98

Move all Sandbox functions into their own class and declare functions needed by tests as private with FRIEND_TEST declarations where appropriate.

BUG=60917
TEST=Chrome on Mac should run and unit tests should pass.

Review URL: http://codereview.chromium.org/4380001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65332 0039d316-1c4b-4281-b951-d872f2087c98

This CL allows statting the following files:
1) '/'
2) '/var'

And full read access for various paths where .GlobalPreferences.plist may be present.

The first 2 seem harmless to unblock and the 3rd is used by the default system.

Bug=60917
TEST=Repro steps in bug.
Cleanup: Remove stale TODO

The code in question is no longer needed since Skia has changed to remove the #define in question.

BUG=None
TEST=Compilation shouldn't break

Review URL: http://codereview.chromium.org/4134007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65331 0039d316-1c4b-4281-b951-d872f2087c98

Revert 65329 - Revert 65272 - Autofill heapcheck and valgrind leak in PersonalDataManager unit test fixed

[Redness was not healed... so I'm reverting the revert]

An early return in the WebDataService was the source of a leak in PersonalDataManagerTest.Refresh test.  This fixes it.  Also, some small cleanup in the test itself.

BUG=61988
TEST=Memory bots stay green.

Review URL: http://codereview.chromium.org/4612001

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/4641001

TBR=jar@chromium.org
Review URL: http://codereview.chromium.org/4643001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65330 0039d316-1c4b-4281-b951-d872f2087c98

[There is a lot of red on valgrind now... so trying a revert]

An early return in the WebDataService was the source of a leak in PersonalDataManagerTest.Refresh test.  This fixes it.  Also, some small cleanup in the test itself.

BUG=61988
TEST=Memory bots stay green.

Review URL: http://codereview.chromium.org/4612001

TBR=dhollowa@chromium.org
Review URL: http://codereview.chromium.org/4641001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65329 0039d316-1c4b-4281-b951-d872f2087c98

Switch to using TimeTicks rather than Time so that we
are not dependent on changes in the system clock.

r=mbelshe,darin
Review URL: http://codereview.chromium.org/3884001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65322 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4555003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65315 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=It builds.

Review URL: http://codereview.chromium.org/4094002

TBR=cbentzel@chromium.org
Review URL: http://codereview.chromium.org/4541002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65314 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=It builds.

Review URL: http://codereview.chromium.org/4094002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65313 0039d316-1c4b-4281-b951-d872f2087c98

Many of the tests depend on a file served from one server to reference resources on a different server to exercise mixed content warnings.

To handle this, I added replace_orig and replace_new query parameters to /files/ based paths which do simple string substitution.

BUG=56814
TEST=browser_tests --gtest_filter="*SSLUI*"

Review URL: http://codereview.chromium.org/4429001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65311 0039d316-1c4b-4281-b951-d872f2087c98

fix users of same.

BUG=none
TEST=unittests

Review URL: http://codereview.chromium.org/4517004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65310 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65306 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61534
TEST=see if the feature works in an extension

Review URL: http://codereview.chromium.org/4439002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65304 0039d316-1c4b-4281-b951-d872f2087c98

CID=12682,13411
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4549003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65301 0039d316-1c4b-4281-b951-d872f2087c98

CID=13537,13538,13612
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/4525008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65300 0039d316-1c4b-4281-b951-d872f2087c98

Also changed code to use existing Browser APIs and preserved the desired disposition.
See issue for more info.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=8013
TEST=See issue

Review URL: http://codereview.chromium.org/4055004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65298 0039d316-1c4b-4281-b951-d872f2087c98

canaries, until i can figure out what's wrong with it, or find
somebody else to take a look at it.

BUG=61739
TEST=none
TBR=ukai

Review URL: http://codereview.chromium.org/4613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65296 0039d316-1c4b-4281-b951-d872f2087c98

when WebKit's version was rolled from 71400:71457.

BUG=62156
TEST=none
TBR=ukai

Review URL: http://codereview.chromium.org/4626001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65295 0039d316-1c4b-4281-b951-d872f2087c98