BUG=49828
TEST=none
Review URL: http://codereview.chromium.org/3058005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53243 0039d316-1c4b-4281-b951-d872f2087c98

TBR=krasimira@chromium.org
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2809065

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53242 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:4827
TEST=new test TestShowTwice

Review URL: http://codereview.chromium.org/2854055

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53241 0039d316-1c4b-4281-b951-d872f2087c98

null check the opener's WebView before using it.

BUG=42974
TEST=Flaky, no known repro steps


Review URL: http://codereview.chromium.org/2850037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53240 0039d316-1c4b-4281-b951-d872f2087c98

Used the service utility process host to render PDFs in a sandbox for the Windows cloud print proxy. Also made the print spooling asynchronous.
BUG=None
TEST=Test cloud print proxy on all supported platforms.

Review URL: http://codereview.chromium.org/3051006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53238 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49809
TEST=None

Review URL: http://codereview.chromium.org/2805097

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53237 0039d316-1c4b-4281-b951-d872f2087c98

A different approach to avoid crashes in buggy 3rd party BHOs.This time we're more preceise and only target the buggy components.Behaviour for components that handle browser events correctly, is unchanged even in the presence of buggy DLLs.The core class here is the BuggyBhoTls class and here's the comment for that class:

// Construct an instance of this class on the stack when firing web browser
// events that can be sent to buggy BHOs. This class will intercept those
// BHOs (see list in cc file) and ignore notifications to those components
// for as long as the BuggyBhoTls instance on the stack lives.

TEST=A better fix for bug 44463 but also fixes bug 49373 and a number of crashes that haven't been associated with bug reports yet.
BUG=44463, 49373

Review URL: http://codereview.chromium.org/3053008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53236 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:4948
TEST=manual: toggle side tab from wrench menu and side tab menu will be checked.

Review URL: http://codereview.chromium.org/3034021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53235 0039d316-1c4b-4281-b951-d872f2087c98

BUG=38222
TEST=in the bug

Patch by George Yakovleg <georgey@chromium.org>

Review URL: http://codereview.chromium.org/2832064

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53234 0039d316-1c4b-4281-b951-d872f2087c98

dropped inadvertently when landing from a machine other than one where the
original CL was written.

In addition, adjust Tamil and Malayalam UI dimensions for XP.

BUG=48202
TEST=In Tamil and Malyalam Chrome on XP, content-settings dialog do not have anytruncation.
TBR=finnur
Review URL: http://codereview.chromium.org/3015011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53233 0039d316-1c4b-4281-b951-d872f2087c98

Fix transforms to be preconcat like skia so multiple transforms are accumulated with each call to TranslateInt/ScaleInt.

BUG=none
TEST=see unittest

Review URL: http://codereview.chromium.org/3025010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53232 0039d316-1c4b-4281-b951-d872f2087c98

This cleans up much of the code involved in displaying a certificate selection
dialog to the user.

- Adds a new inner class to RenderViewHostDelegate (later to be populated
  with more SSL things).
- Adds a helper class for TabContents' implementation.
- Moves the certificate dialogs themselves to have a common entry point.
- Makes SSLClientAuthHandler call the RVHDelegate to query the user, with the
  TabContents implementation displaying the dialogs.
- Picks the correct parent window for the dialog on all platforms, instead of
  relying on BrowserList::GetLastActive
- Makes the OS X implementation use an asynchronous sheet, now that we know the
  parent.
- Fixes an index-mismatch problem in the OS X implementation, should we fail to create an identity.

R=agl,brettw,mark
BUG=148
TEST=selecting client certificates still works

Review URL: http://codereview.chromium.org/2823038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53231 0039d316-1c4b-4281-b951-d872f2087c98

TEST=altered existing tests to also cover this case
BUG=49548

Review URL: http://codereview.chromium.org/3033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53230 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:4825
TEST=none

Review URL: http://codereview.chromium.org/3031016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53229 0039d316-1c4b-4281-b951-d872f2087c98

sendRequest.

BUG=46094
TEST=no

Review URL: http://codereview.chromium.org/3005022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53228 0039d316-1c4b-4281-b951-d872f2087c98

Make NetworkLibrary::UpdateSystemInfo() externally usable, and invoke 
it before retrieving/displaying network information, so that we 
successfully display data that the user has just changed via another 
mechanism. 
BUG=chromium-os:3972 
TEST=Configure certificates via entd and log out. Log back in and select the 
network menu, then (immediately) the relevant SSID. Check for the proper 
certificate information, rather than unset fields.
Review URL: http://codereview.chromium.org/3019015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53227 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:4212
TEST=TestFullscreenExit added

Review URL: http://codereview.chromium.org/2832063

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53226 0039d316-1c4b-4281-b951-d872f2087c98

This matches what's happening in test_shell.

Review URL: http://codereview.chromium.org/3049003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=49793
TEST=visual inspection. unit tests shouldn't leak or crash on drawing.
Review URL: http://codereview.chromium.org/3042014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53224 0039d316-1c4b-4281-b951-d872f2087c98

This is still going through the trybots now.

Review URL: http://codereview.chromium.org/2805095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53223 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=tc

Review URL: http://codereview.chromium.org/3017019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53222 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Test zooming.

Review URL: http://codereview.chromium.org/3055006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53221 0039d316-1c4b-4281-b951-d872f2087c98

New versions of that script may get pushed from time to time.
Fetching the script again ensures people that don't restart their browser for long periods of time still get the new versions.

Also renamed the enum from constant style to macro-style, as it is the Chromium way to go from the Chromium style guide (which is in that regard different than the Google style guide).

BUG=None
TEST=Run the unit-tests.

Review URL: http://codereview.chromium.org/3034013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53220 0039d316-1c4b-4281-b951-d872f2087c98

"autofill_entry|$name|$value".

BUG=40876
TEST=none

Review URL: http://codereview.chromium.org/3005013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53219 0039d316-1c4b-4281-b951-d872f2087c98

Move IntersectsClipRectInt and GetClipRect functions to CanvasSkia private, since they are only used internally.

BUG=none
TEST=see unittest.

Review URL: http://codereview.chromium.org/2959014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53218 0039d316-1c4b-4281-b951-d872f2087c98

Changed the code to be more object-oriented. Instead of exposing 150 accessors
we should do as much as possible inside the object, exposing a nice API.
DownloadFile just got a small step closer to that.

Also, reduce amount of state duplication. For example, information about
the download progress was both in DownloadFile and DownloadFileManager
(maybe it's still somewhere else). The download path information
is still duplicated, removing it is going to be harder.

Finally, removed completely unused state variables from DownloadFile.

TEST=unit_tests, browser_tests, ui_tests
BUG=48913

Review URL: http://codereview.chromium.org/3026012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53217 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dhollowa

Review URL: http://codereview.chromium.org/3026014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53213 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dhollowa

Review URL: http://codereview.chromium.org/3026013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53212 0039d316-1c4b-4281-b951-d872f2087c98

Add missing first run bubble back to opening page.
Wait for search engines to load before displaying first run bubble, so correct search engine is displayed in first run.
Because some distributions use "skip-first-run-ui", add back the "import_items" code that passes values to this code path.  Because this code path is obsolete (most import is silent), this needs to be refactored in the long term.
Fix some spelling issues.

BUG= 42612
TEST= import with --skip-first-run-ui works 

Review URL: http://codereview.chromium.org/3042010

TBR=mirandac@google.com
Review URL: http://codereview.chromium.org/3025009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53211 0039d316-1c4b-4281-b951-d872f2087c98

NULLs now that encrypt it.

BUG=49593
TEST=manually tested + updated unit tests

Review URL: http://codereview.chromium.org/3058003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53210 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Open DOMUI prefs; Add and Remove buttons on Basics page should not show &s.

Review URL: http://codereview.chromium.org/2888025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53209 0039d316-1c4b-4281-b951-d872f2087c98

Marks TopSitesTest.DeleteNotifications as DISABLED.  This test has been failing to complete
on Mac 10.6 sporadically.  E.g. http://build.chromium.org/buildbot/waterfall/builders/Mac10.6%20Tests/builds/5065/steps/unit_tests/logs/DeleteNotifications

BUG=49799
TEST=TopSitesTest.DeleteNotifications
TBR=nshkrob@chromium.org

Review URL: http://codereview.chromium.org/2832066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53208 0039d316-1c4b-4281-b951-d872f2087c98

BUG=33033
TEST=None

Review URL: http://codereview.chromium.org/2883031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53207 0039d316-1c4b-4281-b951-d872f2087c98

Fix incorrect focus cycling issues in ChromeFrame full tab mode. This happens whenever a tab rendering a chrome frame
page receives focus by switching to it. Whenever we receive focus in ChromeFrame we send over an IPC to set the initial
focus to Chrome. In this IPc we invoke the FocusThroughTabTraversal function on the TabContents which basically cycles
through the focus on the page which is not correct for full tab mode.

Fix is to handle the WM_SETFOCUS message in the active document and invoke the GiveFocusToChrome with false indicating
that we don't want to invoke the FocusThroughTabTraversal function which cycles through the view. It is sufficient to
set focus to the tab.

We also handle the WM_SHOWWINDOW message in the active document and set focus to the document if it is visible. This
ensures that the page gets focused correctly.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=48459

Fixes bug http://code.google.com/p/chromium/issues/detail?id=25890

Bug=48459, 25890

Review URL: http://codereview.chromium.org/2825061

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53206 0039d316-1c4b-4281-b951-d872f2087c98

Makes the toolbar visible for apps again. Here's the set of patches I
reverted: 49016, 47119, 47177, 46930, 46775, and the UI changes for
45566) If you see anything missing, please let me know.
Also, there are some grd strings no longer necessary. I'll nuke those
separately.

BUG=49013
TEST=none
TBR=finnur

Review URL: http://codereview.chromium.org/3056003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53204 0039d316-1c4b-4281-b951-d872f2087c98

instead of directly accessing member user_data_dir_.

TBR=huanr

Review URL: http://codereview.chromium.org/3047008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53203 0039d316-1c4b-4281-b951-d872f2087c98

for each test.

TEST=ui_tests
BUG=none

Review URL: http://codereview.chromium.org/2856047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53202 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Debug build of chromeos version of chrome doesn't crash w/ DCHECK() at startup.

Review URL: http://codereview.chromium.org/3035016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53201 0039d316-1c4b-4281-b951-d872f2087c98

Also cleaned up spdy unit tests a bit.
TEST=SpdyHttpStreamTest should have no memleaks in valgrind.
BUG=48865, 47950, 46886

Review URL: http://codereview.chromium.org/3033012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53200 0039d316-1c4b-4281-b951-d872f2087c98

Changes index set traversal logic for multi-select and delete of AutoFillDialog table
elements on Mac.  This is follow-up from Thakis' review comment in review http://codereview.chromium.org/3039014.

BUG=49344
TEST=AutoFillDialogControllerTest.DeleteMultiple

Review URL: http://codereview.chromium.org/3056005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@53199 0039d316-1c4b-4281-b951-d872f2087c98