in the past saying that these should be fixed immediately, but this impedes
our ability to run the tests on the bots without turning them red.
Needing to skip these tests to avoid making the bots red is silly.
Review URL: http://codereview.chromium.org/356007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30872 0039d316-1c4b-4281-b951-d872f2087c98

- Make some vertical spacing in basics more consistent
- Make some vertical spacing in personal stuff more consistent
- Make the views a bit wider to avoid some clipping and wrapping in a few languages.
- A little code cleanup, no longer allow the pref views to be different widths, this resulted in some really odd looks, so we want to mange the layout ourselves up front (things not always being as wide as the window, etc).

TEST=window looks ok (given our strings it won't always look great, but shoot for ok).
BUG=26586
Review URL: http://codereview.chromium.org/351027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30871 0039d316-1c4b-4281-b951-d872f2087c98

xib changes:
- cell tags changed to make them styled independently
- button attribute "bordered" disabled

BUG=http://crbug.com/25644
TEST=as in bug

Review URL: http://codereview.chromium.org/341088

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30869 0039d316-1c4b-4281-b951-d872f2087c98

This helps clarify UpdateApplicator and removes SyncerSession from SyncerUtil.

Part of work to separate sync session "context" like the ConflictResolver, ServerConnectionManager,
ModelSafeWorker, etc from progress state.

BUG=25266
TEST=sync unit tests

Review URL: http://codereview.chromium.org/351026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30868 0039d316-1c4b-4281-b951-d872f2087c98

BUG= http://crbug.com/26138
TEST= none
Review URL: http://codereview.chromium.org/355013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30867 0039d316-1c4b-4281-b951-d872f2087c98

"Add Folder..." from either buttons or bar happier (always adds, doesn't edit).
"Add Folder..." now allows you to rename new folders the default name ("New Folder").


BUG=http://crbug.com/26364, http://crbug.com/26407

TEST=Over a bookmark button for a 'mark or folder, context menu --> Edit.
Make sure initial name is current name, not "New Folder".
Over button for 'mark, for folder, or bar itself: context menu --> Add Folder.
Make sure initial name is "New Folder", and that it creates a folder (not a rename).
Make sure you are allowed to create a folder named "New Folder".

Review URL: http://codereview.chromium.org/345045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30866 0039d316-1c4b-4281-b951-d872f2087c98

We set -fPIC just on the layout test plugins and only in 64-bit mode.
This fixes 44 plugin layout tests on 64-bit.

(Retry, now just npapi_layout_test_plugin and not npapi_test_plugin.)

BUG=18337,24271

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30851

Review URL: http://codereview.chromium.org/353022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30864 0039d316-1c4b-4281-b951-d872f2087c98

When drawing a Label it is important to adjust for
RTL not just when drawing, but also when computing
the size of the string.

Before this change, we'd compute using Font::GetStringWidth
(which uses ::GetTextExtentPoint32 *without* adjusting
the string for RTL) and draw using DoDrawText (which
adjusts for RTL and then draws using ::DrawText).

After this change, we now use SizeStringInt for
computing (so we now compute and draw using the
same ::DrawText function, thereby adjusting the 
string for RTL in both cases).

BUG=17949
TEST=Run chrome with --lang=he, press F11 and
the string in the bubble at the top should not
be elided.

Review URL: http://codereview.chromium.org/354014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30863 0039d316-1c4b-4281-b951-d872f2087c98

BrowserActionsContainer breaks for nobody... or maybe someone
just forgot to hit the breaks. :)

This avoids triggering a NOTREACHED in the default case that
I hit during testing.

BUG=None
TEST=Load the set_page_color sample extension in debug build
of Chrome and it should not NOTREACH (it should... um... REACH?)
when pressing the browser action icon. :)


Review URL: http://codereview.chromium.org/351023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30862 0039d316-1c4b-4281-b951-d872f2087c98

backing store when CSS styles are used to resize the Canvas. Fixed
incorrect rendering output on Mac OS X caused by similar issue.

The deeper issue is why the Canvas's backing store is incorrectly
sized in this case. http://crbug.com/26542 has been filed to track
this remaining problem.

BUG=http://crbug.com/26515
TEST=none (covered by preexisting manual WebGL tests)

Review URL: http://codereview.chromium.org/342087

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30859 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=hclam

Review URL: http://codereview.chromium.org/342102

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30856 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Resize window to 400x300, hold down ctrl+N, new windows should all be the same size.
Review URL: http://codereview.chromium.org/355007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30855 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r30851.  Build breakage.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30854 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/26071

TEST=New empty bookmark bar.  Maker sure "Open all bookmarks" in context menu is disabled.
(You'll need to click in the bottom of the bar so you don't overlap the text).
Add a bookmark.
Make sure "Open all bookmarks" in context menu is ENabled.

Review URL: http://codereview.chromium.org/351018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30853 0039d316-1c4b-4281-b951-d872f2087c98

[Mac] Adds a new view that will allow us to animate the height property of views.  This class will be the base class for any view that needs to be animated.

BUG=None
TEST=No visible impact.  New unittests should pass.
Review URL: http://codereview.chromium.org/350002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30852 0039d316-1c4b-4281-b951-d872f2087c98

We set -fPIC just on the layout test plugins and only in 64-bit mode.
This fixes 44 plugin layout tests on 64-bit.

BUG=18337,24271

Review URL: http://codereview.chromium.org/353022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30851 0039d316-1c4b-4281-b951-d872f2087c98

being rebaselined.

TBR=jorlow
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/356005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30850 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/26457
TEST=as in bug

Review URL: http://codereview.chromium.org/342103

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30849 0039d316-1c4b-4281-b951-d872f2087c98

The regex didn't work for GCC = 4.4.

Review URL: http://codereview.chromium.org/341085

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30847 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24733
TEST=go to http://jbbs.livedoor.jp/bbs/read.cgi/sports/30749/1255270799, open a history tab and type a search term. Chrome does not crash 
TBR=cevans

Original Review: http://codereview.chromium.org/339090/show


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30846 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20469
TEST=None
Review URL: http://codereview.chromium.org/326012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30845 0039d316-1c4b-4281-b951-d872f2087c98

1. Add support for V8-latest canaries.
2. Show actual results for the latest run of each bot.
Review URL: http://codereview.chromium.org/340073

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30844 0039d316-1c4b-4281-b951-d872f2087c98

comment in the code mentions that a vbox would cause a split screen,
but looking at the code, it seems like that's not possible because
we hide the old TCVG before adding new ones.  These days the vbox
contains all TCVGs and only shows one at a time (I think in the past
we tried to remove them, but we don't have that problem now).

This simplifies the code by not having to use our own size-allocate
handler.

Review URL: http://codereview.chromium.org/354018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30843 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pfeldman@chromium.org

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/348062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30842 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341074

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30841 0039d316-1c4b-4281-b951-d872f2087c98

The problem was that the ExtensionDevtoolsBridge maintained explicit knowledge of the RenderViewHost is was monitoring. This would be invalidated on page navigations where the inspected RVH would be swapped out from underneath it.

This patch removes knowledge of RenderViewHost from the ExtensionDevToolsBridge and makes sure it appropriately unregisters itself.

Patch by: Jaime Yap (jaimeyap@google.com)

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/348042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26559
TEST=build ffmpeg.  It should be smaller than before but still work.

Review URL: http://codereview.chromium.org/351022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30839 0039d316-1c4b-4281-b951-d872f2087c98

o3djs files and build / selenium to use
compiled o3djs libs.

Review URL: http://codereview.chromium.org/353017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30838 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20111,26582
Review URL: http://codereview.chromium.org/346039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30837 0039d316-1c4b-4281-b951-d872f2087c98

(1) Clicking on the Text Encoding menu item should display the submenu, not try to execute a nonexistent command.
(2) The Text Encoding menu item shouldn't be disabled, but instead the submenu's contents (so that the submenu is always visible). See Apple's HIG:
<http://developer.apple.com/mac/library/DOCUMENTATION/UserExperience/Conceptual/AppleHIGuidelines/XHIGMenus/XHIGMenus.html#//apple_ref/doc/uid/TP30000356-TPXREF122>.

Changes to MainMenu.xib: disconnected |-commandDispatch:| from the Text Encoding menu item.

BUG=25957,26593
TEST=Check that the Text Encoding submenu is always available, with its contents disabled on the NTP (for example) and enabled (and working) on a normal web page. Check that clicking (and releasing) on the Text Encoding menu item itself shows the submenu.

Review URL: http://codereview.chromium.org/345050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30836 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26540

Review URL: http://codereview.chromium.org/341078

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30835 0039d316-1c4b-4281-b951-d872f2087c98

TEST=the reset to defaults button is the right size in all languages.
BUG=20538
Review URL: http://codereview.chromium.org/345049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30834 0039d316-1c4b-4281-b951-d872f2087c98

This CL decouples the implementation of WebDevToolsAgent from the
implementation of WebViewImpl.  While this allows me to postpone
the uplift of glue/devtools into webkit/api/src, I think it also
has the advantage of simplifying dependencies.

WebDevToolsAgentPrivate is introduced for the method calls made
by the FrameLoaderClientImpl to the WebDevToolsAgentImpl.

R=dglazkov
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/342092

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30833 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=pfeldman

Review URL: http://codereview.chromium.org/345041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30832 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mad,twiz
BUG=26599

Review URL: http://codereview.chromium.org/353021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30831 0039d316-1c4b-4281-b951-d872f2087c98

First, made it possible to navigate to "invalid" hostnames in a number of additional cases, including when the user types an explicit scheme or when we have a valid TLD and no spaces.  The default action for these kinds of inputs is still search, but we'll pull up an accidental search infobar if need be now.

Second, made the HistoryURLProvider show a What You Typed match for UNKNOWN inputs when the user explicitly typed "http:" or "https:" at the front, since these have the highest probability of being navigational inputs.

BUG=26341
TEST=Type "http://foo bar baz.com" and verify you are given a (non-default) entry in the dropdown to navigate.
Review URL: http://codereview.chromium.org/353010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30830 0039d316-1c4b-4281-b951-d872f2087c98

TBR=pfeldman@chromium.org

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/355012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30829 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25962
TEST=Type in "google.com." and verify you can navigate.
Review URL: http://codereview.chromium.org/340070

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30828 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=a shade of grey now.
Review URL: http://codereview.chromium.org/348059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30827 0039d316-1c4b-4281-b951-d872f2087c98

later, with the new overview.html file.

TEST=none
BUG=26164

Review URL: http://codereview.chromium.org/348058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30826 0039d316-1c4b-4281-b951-d872f2087c98