See http://code.google.com/p/skia/source/detail?r=583

TBR=evanm

Review URL: http://codereview.chromium.org/2823032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50946 0039d316-1c4b-4281-b951-d872f2087c98

Add a BaseBubbleController. Move ContentBlockedBubbleController to use it (other bubbles will follow in later CLs), add FIrstRunBubbleController which uses it.

Move some l10n stuff to l10n_util and use that, too.

Update first run code to actually call the bubble code. Fix a double free while I'm at it (the scoped_ptr<> in DoFirstRun() already does the freeing, no need to do it in FirstRunDone())

BUG=27489,36366
TEST=Firstrun bubble shows up when starting chrome with --first-run, doesn't if starting chrome without that flag. Content blocked bubbles still work.

Review URL: http://codereview.chromium.org/2822026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50940 0039d316-1c4b-4281-b951-d872f2087c98

R=brettw
BUG=41774
TEST=none

Review URL: http://codereview.chromium.org/2822031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50939 0039d316-1c4b-4281-b951-d872f2087c98

R=wtc
BUG=47463
TEST=none

Review URL: http://codereview.chromium.org/2867026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50938 0039d316-1c4b-4281-b951-d872f2087c98

According to libpng website, this will solve the vulnerability ID CVE-2010-1205.

BUG=47633
TEST=None

Review URL: http://codereview.chromium.org/2835021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50937 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/2852021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50936 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50932 0039d316-1c4b-4281-b951-d872f2087c98

The problem was caused by a broken assumption about current_parser_.
After adding OnEndOfInput to FtpDirectoryListingParser interface,
it was possible that during processing of input we ended up
with just one parser, which returned error when OnEndOfInput was called.

In that case, we should just reset current_parser_ to NULL to avoid
a use-after-free error.

TEST=net_unittests
BUG=47528

Review URL: http://codereview.chromium.org/2846037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50930 0039d316-1c4b-4281-b951-d872f2087c98

BUG=47445

Review URL: http://codereview.chromium.org/2876009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50929 0039d316-1c4b-4281-b951-d872f2087c98

Note: That was a TODO for hclam.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/2865019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50928 0039d316-1c4b-4281-b951-d872f2087c98

http stats when alternate protocol is available but npn was not negotiated (
which means not usng spdy), and when alternate is available AND spdy is used.

Noticable changes:
1. In http_network_transaction.cc, changed the logic that always parse 
response from server for alternate protocol and remember that in 
HttpAlternateProtocols strucuture. We need to remember this to collect 
stats for servers with alternate protocol support but used http for.
2. In spdy_stream.cc, get rid of the response copy from spdy_stream. This
copy overwrites some early status in response set in http_network_transaction.


TEST=http_network_transaction_unittest.cc
BUG=46689

Review URL: http://codereview.chromium.org/2808010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50927 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50923 0039d316-1c4b-4281-b951-d872f2087c98

continued from http://codereview.chromium.org/2754002/show
changelist disappeared after machine swap.

Added a new page, about:about (or chrome://about/about)
Includes a list of most of the about:* pages (eg. Left out about:inducebrowsercrashforrealz)

Page is constructed within browser_about_handler.cc

BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work. 

Review URL: http://codereview.chromium.org/2799038

TBR=hinoka@chromium.org
Review URL: http://codereview.chromium.org/2813037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50922 0039d316-1c4b-4281-b951-d872f2087c98

(Relanding, the changed unit-test was flaky.
Turns out comparing pointers in that context to see that an object changed is a bad idea as a new object might be at the exact same address as an old object.)

This revealed that the NormalTranslate unit-test was incorrect (it was not testing that changing the source or target language from the after translate infobar causes a translation). This also revealed that returning reference string in the delegate is not a brilliant idea as when we switch infobars, the new infobar might be using a string from the old infobar that might have been deleted.

BUG=None
TEST=Linux heap check bot should be green.

Review URL: http://codereview.chromium.org/2878005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50920 0039d316-1c4b-4281-b951-d872f2087c98

Made it take options for enabled/incognito enabled state to apply
on install.

BUG=46515
TEST=unittests, manual (newly-synced disabled extensions should stay
disabled)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=50804

Review URL: http://codereview.chromium.org/2819023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50918 0039d316-1c4b-4281-b951-d872f2087c98

continued from http://codereview.chromium.org/2754002/show
changelist disappeared after machine swap.

Added a new page, about:about (or chrome://about/about)
Includes a list of most of the about:* pages (eg. Left out about:inducebrowsercrashforrealz)

Page is constructed within browser_about_handler.cc

BUG=44699
TEST=Go to about:about, and see if About page loads. Check if links work. 

Review URL: http://codereview.chromium.org/2799038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50917 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionInstallUI.

Also, fix a bug where a change to the geolocation permission
wasn't triggering the privilege increase path and refactor
code to try and reduce the chance of that kind of bug in the
future.

BUG=45715

Review URL: http://codereview.chromium.org/2846034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50916 0039d316-1c4b-4281-b951-d872f2087c98

It fails on ChromeOS.

TBR=wtc
BUG=47587
TEST=KeygenHandlerTest.ConcurrencyTest

Review URL: http://codereview.chromium.org/2880003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50915 0039d316-1c4b-4281-b951-d872f2087c98

TranslateManagerTest.NormalTranslate fails on Linux

TranslateInfoBarDelegate2 were leaked. (Yikes!)
This revealed that the NormalTranslate unit-test was incorrect (it was not testing that changing the source or target language from the after translate infobar causes a translation).
This also revealed that returning reference string in the delegate is not a brilliant idea as when we switch infobars, the new infobar might be using a string from the old infobar that might have been deleted.

BUG=None
TEST=Linux heap check bot should be green.

Review URL: http://codereview.chromium.org/2822032

TBR=jcivelli@chromium.org
Review URL: http://codereview.chromium.org/2879004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50914 0039d316-1c4b-4281-b951-d872f2087c98

This revealed that the NormalTranslate unit-test was incorrect (it was not testing that changing the source or target language from the after translate infobar causes a translation).
This also revealed that returning reference string in the delegate is not a brilliant idea as when we switch infobars, the new infobar might be using a string from the old infobar that might have been deleted.

BUG=None
TEST=Linux heap check bot should be green.

Review URL: http://codereview.chromium.org/2822032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50913 0039d316-1c4b-4281-b951-d872f2087c98

API design choice.

BUG=47539,47545

Review URL: http://codereview.chromium.org/2870027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50912 0039d316-1c4b-4281-b951-d872f2087c98

. crash when showing page menu via alt-e.
. dchecks when running on views on linux.

BUG=45734
TEST=none
TBR=erg@chromium.org

Review URL: http://codereview.chromium.org/2867029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50911 0039d316-1c4b-4281-b951-d872f2087c98

Added coverage for disabled extensions in unit tests.

BUG=none
TEST=new unit tests

Review URL: http://codereview.chromium.org/2845025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50910 0039d316-1c4b-4281-b951-d872f2087c98

The people with whom I spoke (ben, glen, alcor) think that
we should expose a better method for going back in the
browser history and are okay with removing this for now.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/2871026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50909 0039d316-1c4b-4281-b951-d872f2087c98

This ties up that loose end I mentioned in http://codereview.chromium.org/2747011 (I had put this off because I expected it would require slightly more effort).

BUG=29281
TEST=manual

Review URL: http://codereview.chromium.org/2844017

TBR=estade@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50908 0039d316-1c4b-4281-b951-d872f2087c98

This is defensive coding to avoid memory leaks.

bug=47469
r=wtc
Review URL: http://codereview.chromium.org/2869024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50907 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mikhail
TEST=Tree goes green
BUG=none

Review URL: http://codereview.chromium.org/2860027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50905 0039d316-1c4b-4281-b951-d872f2087c98

Remove 2 redundant lines.


Review URL: http://codereview.chromium.org/2810032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50904 0039d316-1c4b-4281-b951-d872f2087c98

We'll want some semblance of thread-safety when we make keygen asynchronous.

R=wtc,mattm
BUG=148
TEST=unit test

Review URL: http://codereview.chromium.org/2838010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50903 0039d316-1c4b-4281-b951-d872f2087c98

Was reverted because of a valgrind error. This is try #2.

Old flow:
- type username/password. wait for Gaia auth and initial sync (with throbber)
- success! or error.

New flow:
- type username/password. wait for Gaia auth. (with throbber)
- error, or choose your datatypes. you can choose "keep everything synced", which will sync all present and future datatypes, or you can pick one by one.
- wait for initial sync (with throbber)
- success! or error, which brings you back to the gaia auth screen.

Smaller details:
- removed the Customize button from gaia_login.html; further removal of the old native Customize dialog to follow.
- added a logging statement to log if you cancel from the Choose Data Types screen.
- added a pref to the profile for whether you want to "keep everything synced" or choose one by one.
- added a couple more strings. Not final yet, I don't think.

BUG=45869
TEST=Exercise all the different paths through the login flow.

Review URL: http://codereview.chromium.org/2880001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50902 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50901 0039d316-1c4b-4281-b951-d872f2087c98

http://codereview.chromium.org/2849018/show), except a minor
change to sha1_portable.cc.

Don't use sha1_win.cc because it may have caused a regression
to page cycler moz.

TBR=eroman
BUG=47218
TEST=none
Review URL: http://codereview.chromium.org/2865021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50900 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50899 0039d316-1c4b-4281-b951-d872f2087c98

BUG=47575
TEST=none
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/2825024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=included.
Review URL: http://codereview.chromium.org/2826019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50897 0039d316-1c4b-4281-b951-d872f2087c98

GTK: First draft of the unified cut/copy/paste and +/-/Fullscreen menu items.

Adds special menu item types that allow shoving buttons into them, along with
tracking which button is selected. We now are halfway to the mocks that the
chrome-ui-leads sent out.

Review URL: http://codereview.chromium.org/2800015
BUG=45757
TEST=none

Review URL: http://codereview.chromium.org/2879002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50896 0039d316-1c4b-4281-b951-d872f2087c98

  * Use a process-wide object (singleton pattern)
  * Create/destroy this object on the main thread, make it outlive all consumers
  * Make observer-related functions threadsafe

As a result, the notifier can now be used by any thread (eliminating things like NetworkChangeObserverProxy and NetworkChangeNotifierProxy, and expanding its usefulness); its creation and inner workings are much simplified (eliminating implementation-specific classes); and it is simpler to access (eliminating things like NetworkChangeNotifierThread and a LOT of passing pointers around).

BUG=none
TEST=Unittests; network changes still trigger notifications
Review URL: http://codereview.chromium.org/2802015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50895 0039d316-1c4b-4281-b951-d872f2087c98

Recommitting of r46101.

BUG=http://crbug.com/34481; http://crbug.com/40011
TEST=on Mac/ChromeOS, have at least 15 bookmarks on bookmarks bar or other bookmarks,
right click on one of those and click on Open all bookmarks. A confirmation
dialog box should be shown. No other visible change.

Review URL: http://codereview.chromium.org/1745024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50894 0039d316-1c4b-4281-b951-d872f2087c98

BUG=45734
TEST=make sure the new wrench menu works! Make sure and exer

Review URL: http://codereview.chromium.org/2845022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50893 0039d316-1c4b-4281-b951-d872f2087c98

(already works on mac).

BUG=44797
TEST=make sure control-alt-b shows the bookmark manager.

Review URL: http://codereview.chromium.org/2867027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@50892 0039d316-1c4b-4281-b951-d872f2087c98