- May 29, 2009
-
-
sgjesse@chromium.org authored
This fixes a number of issue, and provides some additional support and fixes needed for the dev tools. Review URL: http://codereview.chromium.org/115921 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17181 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TEST=none Review URL: http://codereview.chromium.org/115870 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17178 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
- reduce header dependencies - miscellanous cleanups (whitespace, explicit deps) Review URL: http://codereview.chromium.org/113945 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17177 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@google.com authored
DevTools: decouple class and method names from RPC message arguments. That would allow to select dispatcher wothout parsing the message argument. Review URL: http://codereview.chromium.org/115862 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17176 0039d316-1c4b-4281-b951-d872f2087c98
-
sgk@google.com authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/115915 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17175 0039d316-1c4b-4281-b951-d872f2087c98
-
sgk@google.com authored
and clean up some things: * Make <(grit_out_dir) a top-level variable, used by multiple targets. * Add precompiled.{cc,h} to various targets: common and plugin. * Add precompiled_wtl.{cc,h} to various targets: renderer, unit_tests, and url_fetch_test. * Add browser/net/test_url_fetcher_factory.cc to unit_tests. * Add dependencies on net_resources and webkit_resources to unit_tests and interactive_ui_tests. * Add a dependency on test_support_common to page_cycler_tests. * Add a dependency on net to url_fetch_test. * Pull in all of the installer/installer.gyp targets. BUG=none TEST=none Review URL: http://codereview.chromium.org/112068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17174 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/115914 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17173 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
Fix unit test bustage by making sure ExtensionView::ViewHierarchyChanged calls the base class impl first. Fix compile bustage by not compiling windows-specific code on other platforms. TBR=brettw BUG=none TEST=none Review URL: http://codereview.chromium.org/115912 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17172 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17171 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17170 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
Refactors HWNDView, NativeViewHostGtk and NativeViewHost so that they match the NativeControl pattern established for NativeButtons. NativeViewHost is a platform-neutral class that clients instantiate. Behind the scenes the platform instantiates the appropriate NativeViewHostWrapper implementation, either NativeViewHostGtk (as before) or NativeViewHostWin (replaces HWNDView). BUG=none TEST=none Review URL: http://codereview.chromium.org/114059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17169 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
BUG=10911 TEST=net_unittests passes Review URL: http://codereview.chromium.org/115700 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17168 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=visit about:crash, no dump file left over in /tmp. Review URL: http://codereview.chromium.org/113984 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17161 0039d316-1c4b-4281-b951-d872f2087c98
-
ukai@chromium.org authored
The threads in our thread pool terminate after we have called PR_Cleanup. Unless we detach them from NSPR, if we use CertVerifier, net_unittests dies with segfault on shutdown. BUG=10911 TEST=net_unittests passes with code that uses CertVerifier. Review URL: http://codereview.chromium.org/115856 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17160 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
unneeded methods from NativeTabContentsContainerWin. BUG=none TEST=none Review URL: http://codereview.chromium.org/115903 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17159 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
This is a quick hack, that will be replaced once we have the rest of prefs implemented. BUG=12736 Review URL: http://codereview.chromium.org/113977 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17158 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
accept the user's text. Review URL: http://codereview.chromium.org/114058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17157 0039d316-1c4b-4281-b951-d872f2087c98
-
hbono@chromium.org authored
vista without hebrew support the bug reason is documented in the source for all to see and the bug=12093 (http://code.google.com/p/chromium/issues/detail?id=12093) the code has been tested with and without a debugger but i have to admit, the unit_tests rarely pass on my machine (the ui ones never do)but this code i changed leaves the state EXACTLY like it was and solves this issue at least BUG=12093 TEST=run unit_tests.exe on Hebrew Windows; run Chrome; open a page which contains a <textarea dir="ltr"></textarea> element; press control+right-shift key, and; verify its "dir" attribute becomes "rtl". Review URL: http://codereview.chromium.org/115849 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17156 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
was accidentally lost in r16719. BUG=9007 Review URL: http://codereview.chromium.org/115902 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17155 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none TBR=ben Review URL: http://codereview.chromium.org/113981 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17153 0039d316-1c4b-4281-b951-d872f2087c98
-
mmoss@chromium.org authored
This makes the buildbot archive hermetic for package building, rather than pulling files from the package builder's source tree (e.g. BRANDING) and system (e.g. lib32 stuff). Note, this currently only applies to official builds since that's all we package. This depends on: http://codereview.chromium.org/115842 http://codereview.chromium.org/113966 Review URL: http://codereview.chromium.org/115843 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17151 0039d316-1c4b-4281-b951-d872f2087c98
-
arv@google.com authored
page. This allows faster prototyping (F5) of the NNTP. TEST=Start Chrome with --new-new-tab-page=path/to/file.html. The NTP should show the file. Make a visible change in the file and reload the tab page and the change should be visible immidiately. BUG=None Review URL: http://codereview.chromium.org/113927 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17150 0039d316-1c4b-4281-b951-d872f2087c98
-
jrg@chromium.org authored
One visible change: new tab page has Google icon, not Chromium. Gyp doesn't have a set environment variable facility; hence the addition of a command line option to grit. Review URL: http://codereview.chromium.org/113974 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17148 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/115879 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17146 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Make use of this in HistoryContentsProvider so results from it get their schemes trimmed appropriately. BUG=10558 Review URL: http://codereview.chromium.org/115885 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17145 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Treat alt-(arrows/pgup/pgdn) like alt was not pressed. There's no reason to ignore these keypresses. BUG=6992 TEST=Type a letter so the omnibox dropdown shows. Press alt-down. If you used the numpad down arrow, nothing should happen (until you release both keys, then a special character might appear). If you used the standalone arrow keys, the selection should move down one row. Review URL: http://codereview.chromium.org/115891 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17144 0039d316-1c4b-4281-b951-d872f2087c98
-
gspencer@google.com authored
and updates the build files so that it will build. Review URL: http://codereview.chromium.org/115847 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17142 0039d316-1c4b-4281-b951-d872f2087c98
-
rspangler@google.com authored
Add support for scanning missing source files for executable lines. Add support for HTML output. Now reports percent coverage. BUG=none TEST=by hand on experimental buildbot Review URL: http://codereview.chromium.org/113980 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17141 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
in windows that triggered status bubble (such as gmail) to always come to front. BUG=none TEST=see bug Review URL: http://codereview.chromium.org/113962 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17140 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@chromium.org authored
This will generate prettier looking sln files. Review URL: http://codereview.chromium.org/113979 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17138 0039d316-1c4b-4281-b951-d872f2087c98
-
- May 28, 2009
-
-
evan@chromium.org authored
It mostly confuses the press. Review URL: http://codereview.chromium.org/113978 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17137 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
BUG=12174 Review URL: http://codereview.chromium.org/115893 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17136 0039d316-1c4b-4281-b951-d872f2087c98
-
kuchhal@chromium.org authored
BUG=12844 TEST=Install Chromium and make sure gears.dll is present. Review URL: http://codereview.chromium.org/113976 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17135 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=5372 TEST=Navigate somewhere, focus the omnibox, and hit alt+numpad 7. You should navigate to your home page (by default, the new tab page). Review URL: http://codereview.chromium.org/113971 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17134 0039d316-1c4b-4281-b951-d872f2087c98
-
ben@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/115886 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17133 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
Also, rearrange helper code for centering things in hboxes so they don't expand to take up the full vertical space. Also, don't allow focus on gtk_chrome_button buttons. This is to prevent the "Other bookmarks" button from getting focus (which matches windows) and is in line with disallowing focus on all custom chrome buttons (see CustomDrawButton). BUG=12829 TEST=everything should look the same. Also if you tab to focus on a link button (e.g. download shelf's "show all downloads"), it should have a dotted line around the exterior. Review URL: http://codereview.chromium.org/113970 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17132 0039d316-1c4b-4281-b951-d872f2087c98
-
abarth@chromium.org authored
This should have been in my earlier CL, but I had a gcl fail. TBR=darin BUG=None TEST=No behavior change Review URL: http://codereview.chromium.org/112067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17131 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=none TEST=Linux first run dialog should be properly styled? Review URL: http://codereview.chromium.org/115890 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17130 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
Repairing tree bustage. r=jrg Review URL: http://codereview.chromium.org/113975 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17129 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
This replaces the current time based approach (chrome is given N seconds to upload all renederer histograms) with an asynch callback approach that waits until all renderers have responded (with their updates). It uses a fall-back timer to ensure that a hung renderer won't delay things forever as well. This causes faster (and complete) updates in about:histograms as well as generally assuring complete updates during UMA gatherings. This code was contributed by Raman Tenneti in CL 42496 http://codereview.chromium.org/42496 bug=12850 r=raman Review URL: http://codereview.chromium.org/113473 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@17123 0039d316-1c4b-4281-b951-d872f2087c98
-