BUG=chromium-os:8829
TEST=Run chromium. Use wrench menu to open 'Find' window. Notice that
focus is inplace.

Review URL: http://codereview.chromium.org/5009001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66427 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62478
TEST=PrefValueStore*:PrefService*

Committing for danno@chromium.org

Review URL: http://codereview.chromium.org/4876002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66426 0039d316-1c4b-4281-b951-d872f2087c98

BUG=60966
TEST=NONE

Review URL: http://codereview.chromium.org/5116002
Patch from Peter Beverloo <peter@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66424 0039d316-1c4b-4281-b951-d872f2087c98

Use special text for Guest Session instead of using standard text for
Incognito mode. Also changes icon and link which are shown.

BUG=chromium-os:6907
TEST=Enter Guest mode, open new tab. Check opened page.

Review URL: http://codereview.chromium.org/4186009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66423 0039d316-1c4b-4281-b951-d872f2087c98

(landing on behalf of kristianm)

Suppress Android warnings

Android generates warnings for comparing signed and unsigned numbers.
The ones in this CL should be safe.

BUG=62949
TEST=None

Review URL: http://codereview.chromium.org/5035002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66420 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66418 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62798
TEST=unit tests: DeviceTokenFetcherTest.StoreAndLoad

Review URL: http://codereview.chromium.org/4949003

TBR=jkummerow@chromium.org
Review URL: http://codereview.chromium.org/5166001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66416 0039d316-1c4b-4281-b951-d872f2087c98

BUG=62798
TEST=unit tests: DeviceTokenFetcherTest.StoreAndLoad

Review URL: http://codereview.chromium.org/4949003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66415 0039d316-1c4b-4281-b951-d872f2087c98

BUG=57965
TEST=greener tree

Review URL: http://codereview.chromium.org/5121001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66414 0039d316-1c4b-4281-b951-d872f2087c98

This allows the base/crypto methods to call EnsureOpenSSLInit.
Also factors out the SSL_CTX and X509_STORE to be more closely associated with their consumers (ssl socket and X509Certificate resp.) rather than process wide globals.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/4963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66413 0039d316-1c4b-4281-b951-d872f2087c98

Since we no longer pulsate the notification dot I've also removed the animation.

BUG=http://crbug.com/51105, http://crbug.com/27941
TEST=None

Review URL: http://codereview.chromium.org/5056004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66412 0039d316-1c4b-4281-b951-d872f2087c98

The original CL was:
http://codereview.chromium.org/4818002

which missed a unittest fix, and the commit(r66253) was reverted (r66258).

Changed
chrome/browser/chromeos/options/wifi_config_view_browsertest.cc
and network_library.h.

BUG=chromium-os:8193
TEST=manually open chrome://settings/internet and see if remembered networks are listed properly. For DOMUI network menu, pass --enable-domui-menu for chrome to enable and check. Also check browser_test --gtest_filter="WifiConfigViewTest.ChangeAutoConnectSaveTest"

Review URL: http://codereview.chromium.org/5094002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66411 0039d316-1c4b-4281-b951-d872f2087c98

The issue was caused by undesirable changes in r66324
probably caused by conflicts with the previous change:

http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/options.html?r1=66324&r2=66323&pathrev=66324

BUG=chromium-os:9277
TEST=confirmed that the proxy settings and language settings are back

Review URL: http://codereview.chromium.org/5145003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66410 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

TBR=antonm@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66405 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

TBR=antonm@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66403 0039d316-1c4b-4281-b951-d872f2087c98

BUG=61501
TEST=none

Review URL: http://codereview.chromium.org/5144001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66402 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5104002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66401 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66399 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 8d410ce0aae7acbbcd816425ba49e79d8d7b9a1d.

TBR=aa@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66398 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit 24e3962db61243eea4976bead441c6206cd4f21e.

TBR=aa@chromium.org

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66394 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=antonm@chromium.org

Review URL: http://codereview.chromium.org/5138002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66392 0039d316-1c4b-4281-b951-d872f2087c98

* Better handling of delegate==NULL case, not just use shortcut to return safe value, but rather exercise the following path assuming the call to delegate returns some safe default.

BUG=chromium-os:8958
TEST=Open incognito window, close all tabs in normal window, then close all tabs in incognito window and do not observe any crash

Review URL: http://codereview.chromium.org/5114001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66391 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/5065001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66390 0039d316-1c4b-4281-b951-d872f2087c98

Also changed ChormotingHost to use it.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/4975003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66389 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rjkroege@chromium.org

Review URL: http://codereview.chromium.org/5155001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66388 0039d316-1c4b-4281-b951-d872f2087c98

Simple patch to juse inject the message loop.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/4971003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66387 0039d316-1c4b-4281-b951-d872f2087c98

This required moving some code from webkit/glue to
chrome/common/web_apps.cc so that it could rely on
chrome/common/json_schema_validator.h.

BUG=49233
TEST=Convered by unit tests.

Review URL: http://codereview.chromium.org/4979003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66386 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ben@chromium.org

Review URL: http://codereview.chromium.org/5145002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66385 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=erg@chromium.org

Review URL: http://codereview.chromium.org/5108002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66384 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=erg@chromium.org

Review URL: http://codereview.chromium.org/5152001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66383 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none.
TEST=none.
Review URL: http://codereview.chromium.org/5097001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66382 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=antonm@chromium.org

Review URL: http://codereview.chromium.org/5031003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66381 0039d316-1c4b-4281-b951-d872f2087c98

Should fix build.

BUG=none
TEST=build

Review URL: http://codereview.chromium.org/5142001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66374 0039d316-1c4b-4281-b951-d872f2087c98

Revert 66350 - Add named testing interface. This allows you to connect to a pre-existing Chrome process and run tests on it. This is an addition to the low level interface underlying testing frameworks like PyAuto and WebDriver.

Normally, test frameworks communicate with Chrome over an unnamed socket pair on POSIX. The test creates the socket pair and then launches the browser as a child process, passing an open file descriptor for one end of the socket to the browser. This change adds a command line switch that, when passed to the browser, causes it to listen on a named socket instead, eliminating this parent/child process requirement. Therefore, you can potentially connect any number of tests to a preexisting browser process.

For ChromeOS, this allows you to run tests on the instance of Chrome that is launched on startup, which controls things like the login and lock screens, the battery meter, the wireless UI, etc. Currently there is no way to run tests on a pre-existing Chrome instance. Eventually this will also allow you to connect both PyAuto and WebDriver to the same Chrome instance and run both in the same test.

If you pass the browser the following command line switch:
./chrome --testing-channel=NamedTestingInterface:/path/to/file
This causes the browser to listen for incoming connections. An AutomationProxy can connect to the browser by connecting a Unix domain socket to the specified path and control the browser over the socket.

This is currently only for POSIX. Windows support will come in a future change. Also, this initial change only allows one connection; multiple connection support will come in a future change.

BUG=chromium-os:8512
TEST=Run Chrome with --testing-interface=/var/tmp/NamedTestingInterface, then run NamedInterfaceTest.BasicNamedInterface under ui_tests.

Review URL: http://codereview.chromium.org/4202004

TBR=nirnimesh@chromium.org
Review URL: http://codereview.chromium.org/5139001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66368 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66366 0039d316-1c4b-4281-b951-d872f2087c98

Also fixes typo in comment.

BUG=none
TEST=build

Review URL: http://codereview.chromium.org/5100001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66364 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63386
TEST=None
TBR=kmadhusu@chromium.org

Review URL: http://codereview.chromium.org/5132001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66363 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/5102002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66362 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=None

Review URL: http://codereview.chromium.org/5045005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66360 0039d316-1c4b-4281-b951-d872f2087c98

enter before the dim finished.

BUG=63424
TEST=see bug
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/5111002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66359 0039d316-1c4b-4281-b951-d872f2087c98