- Jan 06, 2011
-
-
oshima@chromium.org authored
Both Textfield and TextfieldViews were focusable and alt-tab was setting the focus back to the Textfield, which sets the focus to the its TextfieldViews. This fixes the issue by making Textfield non focusable. BUG=none TEST=FocusTest is added to unittest. Review URL: http://codereview.chromium.org/5988010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70624 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jan 05, 2011
-
-
oshima@chromium.org authored
It looks big, but most of change is simple signature change. Note: I need your advice on how to deal with WM_CHAR event on Win. Please see my comment below. BUG=none TEST=no new functionality. All tests should still pass. Review URL: http://codereview.chromium.org/6034002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70553 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
(1) When there's blank space at the end of the string in the textfield and the cursor is at the end, 'move cursor to previous word' should move the cursor at the beginning of the last word. (2) When there's blank space at the end of the string, and the cursor is at the end of the last word, 'move cursor to next word' should move the cursor at the end. (3) Moving the cursor should make the cursor immediately visible. This is more inline with how GTK+ cursors behave. For example, constantly pressing the home-key in a GTK+ textfield makes the cursor visible for the duration of the keypress. BUG=none TEST=NativeTextfieldViewsTest.CursorMovement Review URL: http://codereview.chromium.org/5972008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70468 0039d316-1c4b-4281-b951-d872f2087c98
-
- Jan 04, 2011
-
-
sadrul@chromium.org authored
Pressing 0-9 in a textfield with caps lock turned on would generate shifted keyevents, which it shouldn't. So distinguish between caps-lock and shift. BUG=none TEST=none Review URL: http://codereview.chromium.org/6068005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70452 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=none TEST=TestOnKeyPressReturnValue is added. Review URL: http://codereview.chromium.org/5964013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70424 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 17, 2010
-
-
oshima@chromium.org authored
This is based on the original CL http://codereview.chromium.org/3142008. The key difference is * This uses Textfield framework and NativeTextfieldView implements NativeTextfieldWrapper. This allows us to swap the implementation without recompling the tree and can start testing on bots. * Changed the name of the model to TextfieldViewModel as TextfieldModel may be confusing as other Textfield implementations are not using it. I also changed to use string16 instead of gap buffer as it's enough for single line text. We can update the model to use GapBuffer when necessary. * Changed to use string16 as that's what chrome codebase should use. * Added a switch to turn on TextfieldView. I also filled a couple of features such as: * selection by key * mouse actions (move cursor, selection) * used WordIterator, which is i18n compatible, to move cursor by word * blinking cursor This is only for linux based build due to KeyStroke difference. I'm going to move some of test utlity function in chrome/browser/automation/ui_controls to app/test and will add more test once the migration is done. BUG=none TEST=new unit tests are added : NativeTestfieldViewTest and TextfieldViewModelTest. Review URL: http://codereview.chromium.org/5857002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69523 0039d316-1c4b-4281-b951-d872f2087c98
-