- Sep 22, 2009
-
-
paul@chromium.org authored
BUG=22696 TEST=Covered by ui_tests. Review URL: http://codereview.chromium.org/211053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26868 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Review URL: http://codereview.chromium.org/217018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26865 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
why we're not going to implement some. BUG=none TEST=none Review URL: http://codereview.chromium.org/207057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26864 0039d316-1c4b-4281-b951-d872f2087c98
-
pinkerton@chromium.org authored
Remove potential for command-key equivalents to beat the file menu fix-up timer by clearing the command keys for close tab/window before we fire the timer. BUG=16689 TEST=cmd-w closes tabs/windows correctly based on number of tabs in the window and if the window is a browser window. Also comment 16 in the bug. Review URL: http://codereview.chromium.org/215056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26862 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/210027 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26860 0039d316-1c4b-4281-b951-d872f2087c98
-
paul@chromium.org authored
BUG=none. Test=Covered by layout tests. Review URL: http://codereview.chromium.org/208065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26859 0039d316-1c4b-4281-b951-d872f2087c98
-
jhawkins@chromium.org authored
CID=6212 BUG=none TEST=none Review URL: http://codereview.chromium.org/208051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26858 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@google.com authored
Added support for registering additional shared memory objects (textures and buffers etc) with the CommandBuffer. TEST=none BUG=none Review URL: http://codereview.chromium.org/216043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26857 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Eliminate a bunch of color conversions. I was going to try and clean up the code for these but discovered to my surprise that no one actually uses them. Also clean up a few other things, like my AlphaBlend() function using hex alpha values where everyone else uses decimal, or unnecessary global qualifiers, or needlessly long code. I avoided changing postincrement to preincrement :D BUG=none TEST=none Review URL: http://codereview.chromium.org/214054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26856 0039d316-1c4b-4281-b951-d872f2087c98
-
dumi@chromium.org authored
BUG=21442 TEST=none Review URL: http://codereview.chromium.org/203074 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26855 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@google.com authored
and SSLCertRequestInfo, simply declaring the forward class definition is not enough to include this header. This header is really dependent on those two class definitions. BUG=none TEST=none Review URL: http://codereview.chromium.org/216032 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26854 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
TEST=BookmarkBarControllerTest.DisplaysHelpMessageOnEmpty TEST=BookmarkBarControllerTest.HidesHelpMessageWithBookmark BUG=17360 Review URL: http://codereview.chromium.org/216052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26853 0039d316-1c4b-4281-b951-d872f2087c98
-
dank@chromium.org authored
add a couple new suppressions, widen a couple others, all found on a -O1 -fno-inlining big-redzone fishing expedition on mac 'caliban'. BUG=11134,20541,20459,20653,22450,22519 TEST="sh tools/valgrind/shard-all-tests.sh base_unittests net_unittests ui_tests unit_tests" on mac pro overnight Review URL: http://codereview.chromium.org/212028 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26851 0039d316-1c4b-4281-b951-d872f2087c98
-
dank@chromium.org authored
If https://bugs.kde.org/show_bug.cgi?id=208197 is ever fixed, we can get rid of the patch and change the redzone size with a commandline option instead. Install to /usr/local/valgrind-10880-redzone to make it easier to tell which machines have the updated valgrind. Add DIRNAME variable to valgrind build script to simplify changing name of tarball/build dir/install dir. Also give -f option to mv because macosx's mv is timid about overwriting symlinks. Review URL: http://codereview.chromium.org/216048 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26849 0039d316-1c4b-4281-b951-d872f2087c98
-
maruel@chromium.org authored
The behavior was broken in r20876. BUG=18749 TEST=window.print() on a subframe works. Review URL: http://codereview.chromium.org/206033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26847 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
- Change POINTs to gfx::Point - Get rid of 2 unused automation messages (the messages themselves are staying for now so we don't mess with the reference build) -- add new automation messages to replace GetWindowHWND, which is not portable - re-enable automated_ui_test_interactive_test (it seems to have been dropped when we converted to gyp) - compile additional tests on linux (they don't pass, so they are disabled) - stub out linux tab dragging automation implementation (browser side) - delete various cruft BUG=19758 Review URL: http://codereview.chromium.org/211033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26846 0039d316-1c4b-4281-b951-d872f2087c98
-
jrg@chromium.org authored
Review URL: http://codereview.chromium.org/209023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26845 0039d316-1c4b-4281-b951-d872f2087c98
-
michaeln@google.com authored
There is one appcache service per profile and several request context per profile. The profile holds a reference to the appcache service. Those request contexts which are subject to retrieval from appcaches hold a reference to the appcache service too. The appcache service is provided with a pointer back to the 'main' request context, this context is used when updating appcaches. Initialization is a little tricky because profiles can't be used on the IO thread and request contexts can't be used on the UI thread. BUG=22597,22125 TEST=many existing tests exercise profile/context creation Review URL: http://codereview.chromium.org/215024 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26844 0039d316-1c4b-4281-b951-d872f2087c98
-
kathyw@google.com authored
Besides the usual code.google.com analytics, there's also an account for just Chrome-related docs. Also deleted some end-of-line spaces to avoid presubmit errors. TBR=rafaelw Review URL: http://codereview.chromium.org/209067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26843 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
These keep causing bogus automatic tree closures. BUG=21538,22666 TEST=N/A Review URL: http://codereview.chromium.org/209068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26841 0039d316-1c4b-4281-b951-d872f2087c98
-
paul@chromium.org authored
BUG=None. TEST=Covered by layout tests. Review URL: http://codereview.chromium.org/212042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26840 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/215047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26839 0039d316-1c4b-4281-b951-d872f2087c98
-
kuchhal@chromium.org authored
Review URL: http://codereview.chromium.org/207056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26838 0039d316-1c4b-4281-b951-d872f2087c98
-
zork@chromium.org authored
Review URL: http://codereview.chromium.org/209026 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26837 0039d316-1c4b-4281-b951-d872f2087c98
-
zork@chromium.org authored
Review URL: http://codereview.chromium.org/211019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26835 0039d316-1c4b-4281-b951-d872f2087c98
-
mdm@chromium.org authored
BUG=21474 TEST=none Review URL: http://codereview.chromium.org/214036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26833 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/216045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26832 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
Linux fails in opt build due to strict aliasing in WebCore. BUG=21140 Review URL: http://codereview.chromium.org/215040 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26831 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TEST=Um, none? BUG=19361 Review URL: http://codereview.chromium.org/212049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26830 0039d316-1c4b-4281-b951-d872f2087c98
-
chocobo@google.com authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/215053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26829 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
works in both the edit bookmark dialog and in the bookmark manager. BUG=20328 Review URL: http://codereview.chromium.org/210036 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26828 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
* Put helper functions in a block at the top of the file (which we can then use an anonymous namespace around) * Make main function order a little more consistent BUG=none TEST=none Review URL: http://codereview.chromium.org/215049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26827 0039d316-1c4b-4281-b951-d872f2087c98
-
idanan@google.com authored
OnCookieSet changed so that a blacklist present but with no match still sets the cookie. BUG=none TEST=none Review URL: http://codereview.chromium.org/217016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26825 0039d316-1c4b-4281-b951-d872f2087c98
-
kuchhal@chromium.org authored
BUG=22055 Review URL: http://codereview.chromium.org/204051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26824 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
BUG=22517 TEST=tried it and decided it looks fine Review URL: http://codereview.chromium.org/212044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26822 0039d316-1c4b-4281-b951-d872f2087c98
-
mdm@chromium.org authored
This makes creating a new window after maximizing an existing window work as intended (reliably). BUG=15102 TEST=create a new window after maximizing an existing window on sawfish; the new window should not be maximized Review URL: http://codereview.chromium.org/212046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26821 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
As X is async, this results in annoying flicker right now. If we stick with this we're going to need to avoid creating a new window. But this is good enough for now. BUG=none TEST=none Review URL: http://codereview.chromium.org/210035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26820 0039d316-1c4b-4281-b951-d872f2087c98
-
sgk@google.com authored
window, not open a tab in an existing incognito window. (Vedran Šajatović) BUG=21175 TEST=New Incognito Window from dock with an incognito window already open Review URL: http://codereview.chromium.org/207054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26819 0039d316-1c4b-4281-b951-d872f2087c98
-
mbelshe@google.com authored
rather than the MovableIOBuffer because we weren't using it anyway. Mainly this just simplifies a little code. BUG=none TEST=none Review URL: http://codereview.chromium.org/208042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26818 0039d316-1c4b-4281-b951-d872f2087c98
-
sgk@chromium.org authored
Add USE_TCMALLOC to control its inclusion. Make browser depend on tcmalloc to get the PERFTOOLS_DLL_DECL definition. BUG=none TEST=none Review URL: http://codereview.chromium.org/216033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26816 0039d316-1c4b-4281-b951-d872f2087c98
-