Review URL: http://codereview.chromium.org/342037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30570 0039d316-1c4b-4281-b951-d872f2087c98

Finish() when entered bad state.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/345025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30569 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30568 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26296
TEST=none
Review URL: http://codereview.chromium.org/346021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30567 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/347017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30566 0039d316-1c4b-4281-b951-d872f2087c98

TBR=senorblanco
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/342049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30565 0039d316-1c4b-4281-b951-d872f2087c98

There are separate functions to set/test each feature.

R=jorlow
BUG=25286
TEST=none

Review URL: http://codereview.chromium.org/343001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30564 0039d316-1c4b-4281-b951-d872f2087c98

The functionality in the listen tests was added to the primary API tests when they were rewritten to be event driven.
TEST=ExtensionApiTest.History
BUG=none
Review URL: http://codereview.chromium.org/341047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30563 0039d316-1c4b-4281-b951-d872f2087c98

Remember: Cocoa coordinates are on 0.5.

http://imgur.com/1IIRZ

TBR=dmaclach

BUG=25941
TEST=Show NTP to ben. He shouldn't scream at you too much.

Review URL: http://codereview.chromium.org/342051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30562 0039d316-1c4b-4281-b951-d872f2087c98

Implement the Extension History API, v 0.1.The first version is a weak wrapper around the HistoryServices object in Chrome.BUG=22952TEST=browser_tests.exe --gtest_filer=ExtensionApiTest.History
Review URL: http://codereview.chromium.org/313001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30561 0039d316-1c4b-4281-b951-d872f2087c98

error status will be reported to the delegate (e.g. websocket experiment task)
Finish() should be called at most once when STATE_CLOSE to STATE_NONE.

BUG=none
TEST=net_unittests didn't crash.

Review URL: http://codereview.chromium.org/347026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30560 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yaar

Review URL: http://codereview.chromium.org/340043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30559 0039d316-1c4b-4281-b951-d872f2087c98

webkit/api/src.

R=yaar
BUG=25896,25897,25902
TEST=none

Review URL: http://codereview.chromium.org/341030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30558 0039d316-1c4b-4281-b951-d872f2087c98

Connect the various pieces for notifications... hook up NotificationUIManager to BrowserProcess to DesktopNotificationService to RenderView.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/342043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30557 0039d316-1c4b-4281-b951-d872f2087c98

This causes a CHECK to fire in the extensions service initialization which happens when we 
initialize the profile. The CHECK was added in revision 30550. Given the spate of these test
failures we should really speed up the process of moving the chrome frame builder to the main
waterfall.

TBR=tommi


Review URL: http://codereview.chromium.org/346019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30556 0039d316-1c4b-4281-b951-d872f2087c98

Now we can test CSS counters with dumpAsText().

The corresponding upstream bug:
https://bugs.webkit.org/show_bug.cgi?id=30555

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/338056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30554 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24145
TBR=jorlow

Review URL: http://codereview.chromium.org/344029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30553 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/342050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30552 0039d316-1c4b-4281-b951-d872f2087c98

error status will be reported to the delegate (e.g. websocket experiment task)

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/346010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30551 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25354
Review URL: http://codereview.chromium.org/345023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30550 0039d316-1c4b-4281-b951-d872f2087c98

The newly added AboutChromeFrame test for IE full tab mode was failing on the chrome frame builder which is
an XP machine with IE8 (It was not supposed to return on IE8 :) The reason being that the VK_UP keyboard
message we were passing in via SendInput needs the extended flag to be true. I added the extended flag
as an argument to the SendVirtualKey helper function.

On a related note, I removed the GetIEVersion check from the utility function which launches IE as a COM
server as the IE version checking function checks the version of the current module and compares it against
IE versions which is hilarious. In any case these tests work fine.

TBR=amit


Review URL: http://codereview.chromium.org/339076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30549 0039d316-1c4b-4281-b951-d872f2087c98

from WebKit/LayoutTests/websocket/tests.

This makes reusing scripts in WebKit/LayoutTests/fast/js/resources easier.  For
example, a test in WebKit/LayoutTests/websocket/tests/sample.html can include
js-test-pre.js as ../../fast/js/resources/js-test-pre.js.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/339019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30548 0039d316-1c4b-4281-b951-d872f2087c98

Surprisingly, this is not a tab-modal sheet on linux and windows, so it's window-modal on os x as well for now.

BUG=23526
TEST=Go to http://www.cs.unc.edu/~jbs/resources/perl/perl-cgi/programs/form1-POST.html , click "Do it!", hit reload. Window sheet should come up. Hitting cancel should cancel the navigation (and hitting reload again should bring up sheet again). Hitting "Resend" should trigger reload.

Review URL: http://codereview.chromium.org/327009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30547 0039d316-1c4b-4281-b951-d872f2087c98

Based on the rest of the codebase, I think we're supposed to #include chromium_strings rather than google_chrome_strings, although I doubt it would matter.

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/343050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30546 0039d316-1c4b-4281-b951-d872f2087c98

This is an experiment to see the current status of
the test.

BUG=13921
TEST=warm perf load test is greenish

Review URL: http://codereview.chromium.org/342045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30545 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30544 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30543 0039d316-1c4b-4281-b951-d872f2087c98

BUG=19980
TEST=See the steps in the bug description. 

Patch by Randy Posynick<randy.posynick@gmail.com>
http://codereview.chromium.org/287008

Review URL: http://codereview.chromium.org/339075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30542 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30541 0039d316-1c4b-4281-b951-d872f2087c98

BUG=19852
TEST=See repro steps of the bug 

Patch by Bruno Calvignac <BrunoCalvignac@gmail.com>
Original CL http://codereview.chromium.org/282004

Review URL: http://codereview.chromium.org/342046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30540 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30539 0039d316-1c4b-4281-b951-d872f2087c98

-. Rebaseline deletionUI-single-instance pixel result due to upstream change: http://trac.webkit.org/changeset/49641 
-. Update bug number in test expectations

R=japhet
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/343047

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30538 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25275
TEST=play src\media\test\data\48_aac_infinite_loop.m4a and it should not hang.

Review URL: http://codereview.chromium.org/343046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30537 0039d316-1c4b-4281-b951-d872f2087c98

Picks up making vs2008 projects by default, and adding a new variable into make/scons builds.

BUG=22307
TEST=gyp try bots were green.

Review URL: http://codereview.chromium.org/348016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30536 0039d316-1c4b-4281-b951-d872f2087c98

Add more comprehensive whitelist/blacklist logic so that we can easily switch defaults.

BUG=24918,26110
TEST=Install plugin, follow a link to a PDF; you should not get a page with nothing but a crash notification for the plugin.

Review URL: http://codereview.chromium.org/342029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30535 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23865

Review URL: http://codereview.chromium.org/341025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30534 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/342044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30533 0039d316-1c4b-4281-b951-d872f2087c98

Since bug 24721 is fixed, these might work again. They don't show up on the flakiness dashboard, suggesting that they behaved for a while.

BUG=24632,24889
TEST=Tests not super flaky

Review URL: http://codereview.chromium.org/345024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30532 0039d316-1c4b-4281-b951-d872f2087c98

We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards.

This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.

http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.

Review URL: http://codereview.chromium.org/330013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30531 0039d316-1c4b-4281-b951-d872f2087c98

BUG=16371
TEST=Check the crash logs to see if this CHECK() supplants the CHECK() failure in AsyncResourceHandler::OnWillRead()
Review URL: http://codereview.chromium.org/347012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30530 0039d316-1c4b-4281-b951-d872f2087c98