The results are now sorted before being output, so there is no need
to pass the results through a sort filter.

Byte counts are now printed with comma separators between groups of
3 digits, so that 1234567 is now output as 1,234,567.

The summary.pl now has a number of more precise matches to better 
give a quick estimate of blame for each allocation stack.


r=mbelshe
Review URL: http://codereview.chromium.org/348034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30673 0039d316-1c4b-4281-b951-d872f2087c98

I removed a leak of "stack" objects, and made them a little
more lightweight by removing an unused member.

This change is only part of an option for chrome, that is not currently
linked in during any tests.  It can only currently be used under XP, so
build-bot tests are not currently appropriate.

r=mbelshe
Review URL: http://codereview.chromium.org/345033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30672 0039d316-1c4b-4281-b951-d872f2087c98

I am splitting out the pepper-specific portions of npapi.h.
This is because his code currently relies on a version
of npapi.h different from third_party\npapi\bindings.

Review URL: http://codereview.chromium.org/343069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30671 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30670 0039d316-1c4b-4281-b951-d872f2087c98

gcc-4.4 produces the warning "declaration does not declare anything", which becomes an error due to -Werror.

BUG=26413

Review URL: http://codereview.chromium.org/343072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30669 0039d316-1c4b-4281-b951-d872f2087c98

This is a backout of r30647, but also resurrects the change from
http://codereview.chromium.org/341022 to work around the crash that r30647
solved much more elegantly.

We can't really leave things broken on 10.6, though.  I killed most of a
perfectly good Friday evening trying to figure out how to salvage r30647,
but the DeferredAutoreleasePool approach seems doomed without making private
calls.

This makes me really sad.

BUG=25857, 26399, 26402
TEST=Does it launch on Snow Leopard now?  Does it crash when you close windows?
Review URL: http://codereview.chromium.org/339095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30668 0039d316-1c4b-4281-b951-d872f2087c98

TEST=built chrome-os and non- binaries and made sure they worked as expected

Review URL: http://codereview.chromium.org/342069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30667 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30666 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dank
TEST=media should stop being flaky on TSAN/Mac bot
Review URL: http://codereview.chromium.org/344046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30665 0039d316-1c4b-4281-b951-d872f2087c98

DevTools: add all scripts from afterCompile events when scripts panel is shown for the first timeBUG=26312
TEST=DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh

Review URL: http://codereview.chromium.org/341057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30664 0039d316-1c4b-4281-b951-d872f2087c98

I added these to try to look at exit codes in crashes, but we didn't find
antyhing surprising.  I'm now removing them.

r=nsylvain
Review URL: http://codereview.chromium.org/343053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30663 0039d316-1c4b-4281-b951-d872f2087c98

We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards. I now also maintain a fallback to walk the entire registered list of browsers forward if the active scan fails. This is likely only in a testing environment where a Browser may never have been activated.

This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.

http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30531

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30659
Review URL: http://codereview.chromium.org/330013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30662 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30661 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25318
TEST=none

Review URL: http://codereview.chromium.org/339093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30660 0039d316-1c4b-4281-b951-d872f2087c98

Update: I removed TYPE_ANY to see if I could fool the builders into letting this pass without crashing in browser_tests. It makes the code uglier, but I want to debug and figure out what's going on.

Rework the way the FindBrowserWithProfile/Type methods work.

We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards.

This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.

http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30531
Review URL: http://codereview.chromium.org/330013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30658 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/342072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30657 0039d316-1c4b-4281-b951-d872f2087c98

When the user has highlighted something like a URL, in the context menu show an options to navigate rather than searching.  Original patch by Thiago Farina (see http://codereview.chromium.org/326026 ), r=me.

BUG=1978
TEST=Highlight "google.com" and right-click.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30656 0039d316-1c4b-4281-b951-d872f2087c98

TBR=atwilson
BUG=none
TEST=none



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30655 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rolandsteiner

Review URL: http://codereview.chromium.org/348030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30653 0039d316-1c4b-4281-b951-d872f2087c98

Now that the UI layer is accessible cross-platform, coalesce the DesktopNotificationService layer into one common module.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/343066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30652 0039d316-1c4b-4281-b951-d872f2087c98

reverts menu_button to what it was before the fix. This way 19597 is
still fixed, and we don't have this crash. I'm working on a
regression test for coverage of this, but I don't want to hold up
anything with the fix. 

BUG=26279
TEST=see bug

Review URL: http://codereview.chromium.org/344043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30651 0039d316-1c4b-4281-b951-d872f2087c98

I'm submitting this as a separate CL so that the binary file lands and
that I can get good try server results.

TBR=mpcomplete

Review URL: http://codereview.chromium.org/339091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30650 0039d316-1c4b-4281-b951-d872f2087c98

R=ananta
TEST=none
BUG=26372

Review URL: http://codereview.chromium.org/348026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30649 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26258
TEST=Border color of location bar matches the buttons on each side.

Review URL: http://codereview.chromium.org/348029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30648 0039d316-1c4b-4281-b951-d872f2087c98

autorelease pool in our run loop source if there is one already on the stack 
above us. This allows Cocoa to clean up all the objects at the same time as it 
expects to do. There may be more "interesting" code that can be removed now 
that this is in. Initially we were going to implement it by checking the 
nesting levels of the runloops, but it turns out by the time sendEvent is 
called at the upper level we are already out of the "CFRunloopRun" call so 
our nesting count isn't a valid indicator of our state.

TEST=1) See bug 25857. 2) Start up. Open 3+ windows. Quit.
BUG=25857

Review URL: http://codereview.chromium.org/343024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30647 0039d316-1c4b-4281-b951-d872f2087c98

the incoming index. Callers expect GL errors to be raised for out of
range indices.

BUG=http://crbug.com/26331
TEST=WebKit/LayoutTests/fast/canvas/webgl/getActiveTest.html
(preexisting test; there are two remaining failures which are bugs in
the test)

Review URL: http://codereview.chromium.org/348027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30646 0039d316-1c4b-4281-b951-d872f2087c98

In theory this should result in a slightly faster app startup.

I will do a follow up change to merge it on Windows and get rid of
the code related to the extra file.

BUG=24035

Review URL: http://codereview.chromium.org/344038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30644 0039d316-1c4b-4281-b951-d872f2087c98

BUG=22307
TEST=none

Review URL: http://codereview.chromium.org/340051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30643 0039d316-1c4b-4281-b951-d872f2087c98

This re-plumbs the existing "TooNew" codepath to handle arbitrary error messages.

BUG=25822
TEST=Make your history files non-readable, run Chrome (Release), make sure you get a warning dialog.
Review URL: http://codereview.chromium.org/342048

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30642 0039d316-1c4b-4281-b951-d872f2087c98

for messages recieved after the render view host has been NULLed, causing
crashers with select drop-downs.


BUG=25290
TEST=Make sure select drop-downs work and don't crash the browser.


Review URL: http://codereview.chromium.org/348022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30641 0039d316-1c4b-4281-b951-d872f2087c98

ajwong basic math: FAIL.

BUG=22307
TEST=Clobber built test shell in release and found sumo built.

Review URL: http://codereview.chromium.org/342066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30640 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25952
TEST=always exists "successfully"

Review URL: http://codereview.chromium.org/343068


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30639 0039d316-1c4b-4281-b951-d872f2087c98

Fix several MAJOR crashers in Chrome+LocalStorage/Extensions.  Need to explicitly call Stop() in destructor (before the vtable is torn down) since we override CleanUp().

Filed bug to make this impossible in the future: http://code.google.com/p/chromium/issues/detail?id=26365

TEST=DOMStorageTests UI tests don't fail.
BUG=25413,25746

Review URL: http://codereview.chromium.org/345028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30638 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25068
TEST=Install O3D, open about:plugins; O3D should not be listed.

Review URL: http://codereview.chromium.org/341058

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30637 0039d316-1c4b-4281-b951-d872f2087c98

My local bots (both Linux and Mac) were cycling green with this option all the last week
except for one real race (fixed tonight) and two benign reports suppressed recently.
This option will help us find more races, especially my beloved ref-counter races.

TEST=TSAN bots should remain green
Review URL: http://codereview.chromium.org/348020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30636 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dank
Review URL: http://codereview.chromium.org/344040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30635 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25822
TEST=Make your History files non-readable, run Chrome (Release), Type in "test.com" and see that the selected action is navigation.
Review URL: http://codereview.chromium.org/343051

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30633 0039d316-1c4b-4281-b951-d872f2087c98

corresponding ChromiumBridge method return false.

It turns out that NPP is always null in Chrome (due to
out-of-process plugins), and as a result, we were always
returning false anyways.

R=jam
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/346026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30632 0039d316-1c4b-4281-b951-d872f2087c98

Fall abck to the system default font if the preferred font isn't available.

Also, only create the SkPaint struct once, not on every paint.

Also, make some more things const.

BUG=25693
TEST=badge still looks good, that crash goes away

Review URL: http://codereview.chromium.org/341045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30631 0039d316-1c4b-4281-b951-d872f2087c98