Avoid calling ExecuteCode() on a NULL TabContents. The problem was an extra set of parens were missing, so the "not" operator only applied to the GetTabById() return value.

BUG=34778

Review URL: http://codereview.chromium.org/1238001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42421 0039d316-1c4b-4281-b951-d872f2087c98

BUG=8490
TBR=skrul
Review URL: http://codereview.chromium.org/1201003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42420 0039d316-1c4b-4281-b951-d872f2087c98

Fixed loader issue in unit tests caused by some test not using that mock and causing the library to appear already loaded in a failed state.


Review URL: http://codereview.chromium.org/1251001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42419 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42418 0039d316-1c4b-4281-b951-d872f2087c98

The first two tests are from rohitbm and the rest from krisrs.

testUnicodeStrings -- test bookmarks with unicode strings
testSizes -- test bookmarks with different sized strings
testAddingBookmarksToBarAndOther - add bookmarks to diff locations
testAddingFoldersToBarAndOther -- add bookmark groups to diff locations
testAddingFoldersWithChildrenToBarAndOther -- add bookmarks and groups to
                                              different locations

Review URL: http://codereview.chromium.org/1191002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42417 0039d316-1c4b-4281-b951-d872f2087c98

According to the log,
  http://src.chromium.org/viewvc/chrome/trunk/deps/third_party/icu42/?view=log
This change pulls in two ICU changes.  One is a harmless licensing adjustment;
the other claims in its changelog that "This does not affect Chrome executable
in any way.", so I hope it's safe.

Review URL: http://codereview.chromium.org/1083008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42416 0039d316-1c4b-4281-b951-d872f2087c98

Patch by sergeyu@chromium.org

BUG=23271
TEST=none

Review URL: http://codereview.chromium.org/1213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42415 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dglazkov
BUG=38610

Review URL: http://codereview.chromium.org/1247001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42414 0039d316-1c4b-4281-b951-d872f2087c98

last_sync_timestamp from the new_timestamp only, never from per-entry
timestamps.  Use what the server sends us to know whether or not there
are more updates to fetch.  Eliminate some unnecessarily complicated
logic having to do with the # of updates returned -- that's always a red
herring; with server-side filtering, it is indeed possible for 0 updates
to be returned along with a new timestamp.

BUG=37373
TEST=manual testing of 2 browser sync; unit tests.

Review URL: http://codereview.chromium.org/1161006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42413 0039d316-1c4b-4281-b951-d872f2087c98

BUG=736
TEST=Go to chrome://plugins/. Should be able to enable/disable plugins. Enabled/disabled plugins should persist between sessions.

Review URL: http://codereview.chromium.org/1085003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42412 0039d316-1c4b-4281-b951-d872f2087c98

BMM was originally only checking for the control key on non-mac platforms.

BUG=39085
TEST=Select some non-contiguous bookmarks and copy and paste them, without the
elements in between

Review URL: http://codereview.chromium.org/1225001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42411 0039d316-1c4b-4281-b951-d872f2087c98

BUG=39013

TEST=pyautolib bookmark_bar.py script will now work on Linux

Review URL: http://codereview.chromium.org/1227003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42409 0039d316-1c4b-4281-b951-d872f2087c98

Tested by loading on device and clicking fullscreen button.  (needs most recent codebase)
Review URL: http://codereview.chromium.org/1034002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42408 0039d316-1c4b-4281-b951-d872f2087c98

This is a speculative change, to hopefully get the ARM builder compiling again.
Lately it has been giving the error that |kHandshakeResponseMessage| is being used before it is initialized:
http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Arm/builds/2639/steps/compile/logs/stdio

I don't know why it would say this, but perhaps it is getting confused by the multiple statics with the same name in this file.
My proposed change removes the static keyword, to see if it has an effect.

TBR=ukai

Review URL: http://codereview.chromium.org/1217003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42407 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ajwong
TEST=none
BUG=maybe


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42406 0039d316-1c4b-4281-b951-d872f2087c98

Mocks for all libcros elements. Added library registry object that provides access to all *Libray classes that used to be singletons. This registry adds an indirection layer that will let is replace the actual objects with mocks during test runs. 

BUG=chromium-os:2026
TEST=none

Review URL: http://codereview.chromium.org/1142005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42405 0039d316-1c4b-4281-b951-d872f2087c98

Refactor BalloonViewHost, removing a lot of duplicate code that crept into notifications during the port to mac & linux and making behavior more consistent.

BUG=34826
TEST=notifications on each platform.

Review URL: http://codereview.chromium.org/1055005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42404 0039d316-1c4b-4281-b951-d872f2087c98

Remove the accessible name from Checkbox since it inherits from NativeButton. Dialogs with autogenerated buttons now have MSAA name attached to it, as well as all the checkboxes.

BUG=38987
TEST=Ran it in AccExplorer

Review URL: http://codereview.chromium.org/1102006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42401 0039d316-1c4b-4281-b951-d872f2087c98

to the translation server without the user consent).
Also added unit-tests for prefs.

BUG=38107
TEST=Visit a page that triggers the translate infobar. Translate the
     page. Select "Always translate <lang1> to <lang2>".
     Open a page in lang1. The page should automatically be translated
     to lang2.
     Open an incognito window. Navigate to a page in lang1, the page
     should not automcatically be translated, an infobar should ask
     if the user wants to translate the page.

Review URL: http://codereview.chromium.org/1184001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42400 0039d316-1c4b-4281-b951-d872f2087c98

Rather than encoding all of the supposedly metric-compatible
fonts from fontconfig, let's only whitelist fonts we know really
improve the web for users.  The Helvetica and Courier New
substitutes don't look too great.

BUB=39099

Review URL: http://codereview.chromium.org/1235001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42399 0039d316-1c4b-4281-b951-d872f2087c98

BUG=39100

Review URL: http://codereview.chromium.org/1233001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42397 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=ajwong


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42396 0039d316-1c4b-4281-b951-d872f2087c98

chromeos.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1134009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42395 0039d316-1c4b-4281-b951-d872f2087c98

- Extension disabled infobar was being shown at startup.
- Crashed extensions were persisted as unpacked extensions, regardless of how
they were installed.

BUG=30116
BUG=38856

Review URL: http://codereview.chromium.org/1157005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42394 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ajwong
TEST=none
BUG=hopefully not

Review URL: http://codereview.chromium.org/1219001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42393 0039d316-1c4b-4281-b951-d872f2087c98

run correctly in 64 bit.

BUG=27218

Review URL: http://codereview.chromium.org/1168002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42392 0039d316-1c4b-4281-b951-d872f2087c98

Patch by sergeyu@chromium.org

BUG=28100
TEST=Ran media_unittests

Review URL: http://codereview.chromium.org/1226001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42391 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24477
TEST=manual

Review URL: http://codereview.chromium.org/1170001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42389 0039d316-1c4b-4281-b951-d872f2087c98

This is used by an upcoming layout test.

Also make test_shell properly rebuild when you edit the fontconfig file.

BUG=33447

Review URL: http://codereview.chromium.org/1219002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42388 0039d316-1c4b-4281-b951-d872f2087c98

Broke another layout test.

Review URL: http://codereview.chromium.org/1223001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42387 0039d316-1c4b-4281-b951-d872f2087c98

BUG=39083
TEST=Clobber build and try to open the tab-based bookmark manager. Don't get a 404.

Review URL: http://codereview.chromium.org/1222001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42386 0039d316-1c4b-4281-b951-d872f2087c98

This is basically a rewrite of the DataTypeManager to support dynamic data type configuration.  DTM::Start() has been replaced with DTM::Configure().  Note that the callback is also gone, replaced with notification service style notifications to tell listeners that configuration has started or finished.

I also added some stuff to prepare for adding the "initial download" step for new datatype into the configure process.

Review URL: http://codereview.chromium.org/1128012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42384 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Check that the app launcher is displayed correctly on ChromeOS
     and Windows (when using the --app-launcher-new-tab)

Review URL: http://codereview.chromium.org/1171002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42383 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Http HEAD requests are now supported for IE.
BUG=none

Review URL: http://codereview.chromium.org/1186002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42382 0039d316-1c4b-4281-b951-d872f2087c98

Reimplementation of FunctionStub to avoid rewriting potentially executing code for a slight improvement in thread safety.
Make VTABLE patching treadsafe to the extent possible. As-is it's now safe against itself running on other threads at lease, as well as against other similar implementations, though the inherent VM operation race is resolved by retrying.

BUG=27415
TEST=Included unittests.

Review URL: http://codereview.chromium.org/992008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42381 0039d316-1c4b-4281-b951-d872f2087c98

BUG=38945
TEST=reloaded Pepper 3D plugins repeatedly

NOTE: encountered unrelated problems while testing. These changes
should be stress tested with CA plugins.

Review URL: http://codereview.chromium.org/1110011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42380 0039d316-1c4b-4281-b951-d872f2087c98

Allow ChromeFrame to pass infobar enabled parameter to ExternalTabContainer.
BUG=2444936

Patch contributed by ericdingle@google.com
Original review at http://codereview.chromium.org/890005


TBR=joi@chromium.org
Review URL: http://codereview.chromium.org/1205001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42378 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/1075018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42377 0039d316-1c4b-4281-b951-d872f2087c98

This time, make sure HttpRequestHeaders::FindHeader() checks key lengths are equal.
* Create HttpRequestHeaders.
* Switch HttpNetworkTransaction to build request headers.
TODO: Change extra_headers to use HttpRequestHeaders.
BUG=22588

Review URL: http://codereview.chromium.org/1110014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42376 0039d316-1c4b-4281-b951-d872f2087c98

--gpu-startup-dialog command line option to allow debugging of GPU
process.

BUG=none
TEST=none (tested manually in development workspace)

Review URL: http://codereview.chromium.org/1095005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@42375 0039d316-1c4b-4281-b951-d872f2087c98