git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68946 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky

BUG=66539
TEST=browser_tests

Review URL: http://codereview.chromium.org/5743006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68945 0039d316-1c4b-4281-b951-d872f2087c98

http://src.chromium.org/viewvc/chrome?view=rev&revision=67300

The change has been approved conditionally,
i.e. if the outstanding review comments are handled
in a follow-up as the top priority.

Two weeks have passed, and I have not seen the follow-up.
It is risky to keep this change in the tree, as it is already
non-trivial to revert.

Conflicts:

	chrome/browser/automation/automation_provider.cc
	chrome/test/ui/named_interface_uitest.cc
	ipc/ipc_channel_posix.cc

TBR=nirnimesh

BUG=chromium-os:8512
TEST=none

Review URL: http://codereview.chromium.org/5707006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68944 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68940 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=self

Review URL: http://codereview.chromium.org/5687002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68938 0039d316-1c4b-4281-b951-d872f2087c98

Revert 68932 - Make members of Singleton<T> private and only visible to the singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness.

As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file.

There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file.

BUG=65298
TEST=all existing tests should continue to pass.

Review URL: http://codereview.chromium.org/5682008

TBR=satish@chromium.org
Review URL: http://codereview.chromium.org/5721005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68936 0039d316-1c4b-4281-b951-d872f2087c98

BUG=64263
TEST=compiled locally, trybots

Review URL: http://codereview.chromium.org/5607004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68935 0039d316-1c4b-4281-b951-d872f2087c98

This is upstreaming a Gentoo Linux patch.

I have encountered this tiny compile issue
when using a more recent GCC.

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/5791001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68933 0039d316-1c4b-4281-b951-d872f2087c98

Make members of Singleton<T> private and only visible to the singleton type. This enforces that the Singleton<T> pattern can only be used within classes which want singleton-ness.

As part of this CL I have also fixed up files which got missed in my previous CLs to use a GetInstance() method and use Singleton<T> from the source file.

There are a small number of places where I have also switched to LazyInstance as that was more appropriate for types used in a single source file.

BUG=65298
TEST=all existing tests should continue to pass.

Review URL: http://codereview.chromium.org/5682008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68932 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68931 0039d316-1c4b-4281-b951-d872f2087c98

When there is no application installed on chrome we are showing two separators instead of one
in the menu.

BUG=65648
TEST=see bug

Review URL: http://codereview.chromium.org/5513008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68926 0039d316-1c4b-4281-b951-d872f2087c98

can be changed.

BUG=62875
TEST=none

Review URL: http://codereview.chromium.org/5799001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68923 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68922 0039d316-1c4b-4281-b951-d872f2087c98

Seems to have cured itself.

BUG=59208

Review URL: http://codereview.chromium.org/5713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68921 0039d316-1c4b-4281-b951-d872f2087c98

According to the log, the flakiness may be caused by http://crbug.com/65375. But I can't reproduce it manually on my local Windows 7 workstation. This CL just uses the same test flow as Mac port to try to avoid flakiness. The FLAKY label is not removed in case the test will still be flaky.

BUG=65847
TEST=The test should not flaky on Windows.

Review URL: http://codereview.chromium.org/5746002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68920 0039d316-1c4b-4281-b951-d872f2087c98

Remove the 'restart required' alert when enabling the metrics reporting option, the alert is obsolete.

BUG=none
TEST=Green tree and no 'restart required' alerts when enabling metrics in Chrome builds.
Review URL: http://codereview.chromium.org/4778002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68919 0039d316-1c4b-4281-b951-d872f2087c98

* Move the sync settings into the Personal Stuff page.
* Fix disabling input elements from JS.
* Fix handling of boolean prefs in select controls.

BUG=59279
TEST=none

Review URL: http://codereview.chromium.org/5779001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68918 0039d316-1c4b-4281-b951-d872f2087c98

Marks PlatformThread::Join() as blocking IO using ThreadRestrictions.
Whitelists existing spots where we join on the UI/IO threads.

Also noteworthy is I allow blocking IO on shutdown.

BUG=65530,66077,66082
TEST=none

Review URL: http://codereview.chromium.org/5693003

TBR=willchan@chromium.org
Review URL: http://codereview.chromium.org/5743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68915 0039d316-1c4b-4281-b951-d872f2087c98

BUG=63830
TEST=none

Review URL: http://codereview.chromium.org/5721003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68912 0039d316-1c4b-4281-b951-d872f2087c98

Also add base::win:: to ScopedComPtr where necessary.

BUG=None
TEST=trybots

Review URL: http://codereview.chromium.org/5625006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68910 0039d316-1c4b-4281-b951-d872f2087c98

Added tests
1. testRemovePasswords
2. testFetchAnotherUser
3. testNeverSavePasswords

Added a method for constructing password dictionary

Modified testSavePassword in passwords.py
MOdified GoogleAccountsLogin and VerifyGoogleAccountCredsFilled in test_utils.py to take window index and tab index

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5379007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68909 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581

Review URL: http://codereview.chromium.org/5794001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68908 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5784001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68906 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5770002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68905 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25232
TEST=1, Input text to show popup with autofill. 2. Once autofill pops up drag the browser with mouse. 4, Confirm the popup window is closes.

Review URL: http://codereview.chromium.org/5544011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68904 0039d316-1c4b-4281-b951-d872f2087c98

This is intended for the beta/stable branch.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5628006

TBR=rvargas@google.com
Review URL: http://codereview.chromium.org/5700005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68900 0039d316-1c4b-4281-b951-d872f2087c98

This is intended for the beta/stable branch.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5628006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68899 0039d316-1c4b-4281-b951-d872f2087c98

BUG=66448

Review URL: http://codereview.chromium.org/5697004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68898 0039d316-1c4b-4281-b951-d872f2087c98

tests per file so that tests do not move from file to
file. 

The problem is gles2_cmd_decoder_n_unittest_autogen.h
is dependent on gles2_cmd_decoder_n_unittest.cc

So if a test moves to another generated file then
the things it depends on do not move withit.

TEST=none
BUG=65400

Review URL: http://codereview.chromium.org/5686003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68897 0039d316-1c4b-4281-b951-d872f2087c98

( Note: Data file related to the same test is submitted in a different CL)

Verify prefs to enabled/disables omnibox suggestions

Review URL: http://codereview.chromium.org/5556010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68896 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/5748001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68895 0039d316-1c4b-4281-b951-d872f2087c98

Marks PlatformThread::Join() as blocking IO using ThreadRestrictions.
Whitelists existing spots where we join on the UI/IO threads.

Also noteworthy is I allow blocking IO on shutdown.

BUG=65530,66077,66082
TEST=none

Review URL: http://codereview.chromium.org/5693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68893 0039d316-1c4b-4281-b951-d872f2087c98

Load external extensions even when --disable-extensions is used. We do this since different environments may require users to have certain external policy extensions installed. This patch also fixes a crash when --disable-extensions is used with external extensions installed.

BUG=66070
TEST=ExtensionsServiceTest.ExternalUninstall

Review URL: http://codereview.chromium.org/5695004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68892 0039d316-1c4b-4281-b951-d872f2087c98

Added unit tests for ServerNotifierThread.

Put DISABLE_RUNNABLE_METHOD_REFCOUNT() call for MediatorThreadImpl in the right place.

BUG=57898
TEST=New unittests

Review URL: http://codereview.chromium.org/5722002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68891 0039d316-1c4b-4281-b951-d872f2087c98

Fixes bug where Instant is on even when checkbox in prefs is cleared.
BUG=66089
Review URL: http://codereview.chromium.org/5745004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68890 0039d316-1c4b-4281-b951-d872f2087c98

TEST=47250

Review URL: http://codereview.chromium.org/5557005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68889 0039d316-1c4b-4281-b951-d872f2087c98

This fixes:
- Linux output has UTF-8 quotes in it.
- Mac/Windows have DOS-style CRLF (and reading Linux with that
  coding system is ok).

TEST=new trybot-test-linux

Review URL: http://codereview.chromium.org/5778003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68888 0039d316-1c4b-4281-b951-d872f2087c98

TBR=

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68887 0039d316-1c4b-4281-b951-d872f2087c98

TEST=None
Bug=None

1. Verify content on https page - https://www.google.com. Verify in regular,
incognito window

2. Verify that chrome works with some top websites. Browse a list of urls, each
time verify some key strings. This test will verify that chrome is not getting
blocked by user-agent test by those websites.

Review URL: http://codereview.chromium.org/5726001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68886 0039d316-1c4b-4281-b951-d872f2087c98