git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=40090
TEST=none

Review URL: http://codereview.chromium.org/1567014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43709 0039d316-1c4b-4281-b951-d872f2087c98

[Mac] Get theme providers from a window's delegate, not its window controller.  These are actually the same object, but they are set at different times during the switch to fullscreen.

BUG=39323
TEST=Go fullscreen with the Android Robot theme installed.  Tab text for unselected tabs should be grey, not black.
Review URL: http://codereview.chromium.org/1576019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43708 0039d316-1c4b-4281-b951-d872f2087c98

generate menu item notifications for gtk menus.

The code to generate menu open and close events is a little more complicated
and will come in a future patch.

BUG=none
TEST=navigated menus with keyboard, watched notifications fire

Review URL: http://codereview.chromium.org/1585011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43707 0039d316-1c4b-4281-b951-d872f2087c98

I hit the NOTREACHED() inside it while debugging an unrelated problem.

Also, now there is one less special case in this function's contract.

TEST=none
BUG=38048

Review URL: http://codereview.chromium.org/1315009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43706 0039d316-1c4b-4281-b951-d872f2087c98

The normalization is needed to avoid duplicates in the language table in
the language config diloag, as well as the combobox in the "add language"
dialog, when engines return "jpn" and "ja" as language codes.

Along the way, fixed typos in function names.

TEST=added unit tests, and manually

Review URL: http://codereview.chromium.org/1512022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43705 0039d316-1c4b-4281-b951-d872f2087c98

BUG=36616
TEST=see the linux valgrind bot keeps green
TBR=dpranke

Review URL: http://codereview.chromium.org/1559017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43704 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43703 0039d316-1c4b-4281-b951-d872f2087c98

This change just relaxes the suppression rule for Issue 40505 to cover Linux bots.

TBR=georgey
BUG=40505
TEST=make valgrind bots green.
Review URL: http://codereview.chromium.org/1561015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43702 0039d316-1c4b-4281-b951-d872f2087c98

 * changed DCHECK in tree_node_model to make it easy to find how it failed.
 * Fixed compilation error in find_bar_host_interactive_uitest.cc on linux/views.
 * Disabled BrowserKeyEventsTest.AccessKeys for Chromeos
   Added/Changed ui_test_utils::RunAllPendingInMessageLoop where necessary.
 * Disabled tab_dragging_tests. I included the source so that we can catch
   compilation error even if tests do not run. Changed the comment from // -> /*
   as GCC complains the use of "\" (and potentially dangerous)
 * Added SleepInMessageLoop to allow event loop to execute the tasks/events
   while waiting.
 * For RunAllPendingInMessageLoop change, please see
   http://codereview.chromium.org/1591004

BUG=39736
TEST=interactive_ui_tests should pass with following cls
http://codereview.chromium.org/1594003
http://codereview.chromium.org/1545011.

Review URL: http://codereview.chromium.org/1576008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43701 0039d316-1c4b-4281-b951-d872f2087c98

BookmarkBarView tests fixes
 * Add BOOKMARK_CONTEXT_MENU_SHOWN notification. On Linux, event handling is asynchronous, but the showing context menu is blocking,
    so we can't use RunAllPending().
 * Convert gtk keycode to Win when checking accelerator.

BUG=39736
TEST=none (interactive_ui_tests should pass once enabled
it'll be enabled by http://codereview.chromium.org/1576008

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43699

Review URL: http://codereview.chromium.org/1545011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43700 0039d316-1c4b-4281-b951-d872f2087c98

BUG=40505
TEST= chromium os valgrind (4) should cycle green
TBR=mrossetti@chromium.org

Review URL: http://codereview.chromium.org/1562013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43699 0039d316-1c4b-4281-b951-d872f2087c98

xib changes: Anchor bubble view on right side, make it autoresize horizontally. Same for divider line, radio groups, and title. Make widthbased tweakers at bottom horizontally autoresize. Hook up manage and done buttons to controller.

BUG=39393
TEST=See bug.

Review URL: http://codereview.chromium.org/1527012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43698 0039d316-1c4b-4281-b951-d872f2087c98

BUG=40499
TBR=mrossetti

Review URL: http://codereview.chromium.org/1570014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43697 0039d316-1c4b-4281-b951-d872f2087c98

bounds_animator/tab_strip.

BUG=40475
TEST=none
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/1609008

TBR=sky@chromium.org
Review URL: http://codereview.chromium.org/1512021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43696 0039d316-1c4b-4281-b951-d872f2087c98

Improve the underlying escaping function JsonDoubleQuoteT to escape < and > characters BY DEFAULT to prevent script execution.
BUG=40147
TEST=StringEscapeTest.*
Review URL: http://codereview.chromium.org/1512013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43695 0039d316-1c4b-4281-b951-d872f2087c98

Change how the calculation is performed for determining the location of the arrow tip in a bubble window.

BUG=40406
TEST=1) Not in full-screen and with language set to English, press Cmd-D and verify bubble is properly positioned with arrow tip pointing to star. Change language to Espanol and repeat test. 2) Now in full-screen, repeat the tests.

Review URL: http://codereview.chromium.org/1623002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43694 0039d316-1c4b-4281-b951-d872f2087c98

Reviewed in http://codereview.chromium.org/1512013

BUG=40147
Test=None


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43693 0039d316-1c4b-4281-b951-d872f2087c98

bounds_animator/tab_strip.

BUG=40475
TEST=none
TBR=jcivelli@chromium.org

Review URL: http://codereview.chromium.org/1609008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43692 0039d316-1c4b-4281-b951-d872f2087c98

Patch from Thiago Farina. Previously reviewed here:
http://codereview.chromium.org/931001

BUG=23086
TEST=Chrome should work as before (no visible change).


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=40499
TBR=mrossetti

Review URL: http://codereview.chromium.org/1585018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43687 0039d316-1c4b-4281-b951-d872f2087c98

BUG=35198
TEST=none
Review URL: http://codereview.chromium.org/1528018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43686 0039d316-1c4b-4281-b951-d872f2087c98

BUG=39172
TEST=visual

Review URL: http://codereview.chromium.org/1549021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43685 0039d316-1c4b-4281-b951-d872f2087c98

Add UserScriptSlave unittest.

BUG=39899
TEST=List css file in content_scripts section of the manifest. Refer to an image using url(chrome-extension://__MSG_@@extension_id_/image.png); within that css. @@extension_id message should be replaced with actual id of the extension.

Review URL: http://codereview.chromium.org/1585013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43684 0039d316-1c4b-4281-b951-d872f2087c98

BUG=39228
TEST=Create lots of nested folders (more than 10 levels deep).

Review URL: http://codereview.chromium.org/1539023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43683 0039d316-1c4b-4281-b951-d872f2087c98

TBR=amit

Review URL: http://codereview.chromium.org/1562012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43682 0039d316-1c4b-4281-b951-d872f2087c98

BUG=27570
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43680 0039d316-1c4b-4281-b951-d872f2087c98

This plumbs the actual dropEffect that occurred back into WebKit so that dragend is dispatched with the correct dropEffect.

BUG=39399
TEST=Manual testing using the attached test case on the bug.

Review URL: http://codereview.chromium.org/1589015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43679 0039d316-1c4b-4281-b951-d872f2087c98

Other options included subclassing the pref value types, making the firenotifications public, or just friend classing.

Since values can contain other values, such as dictionary within dictionary, it didn't seem like a good idea to subclass. We might want to consider combining the scoped lookup with the GetMutableList call at some point, but some callers keep a long reference so that might be a bad idea.

BUG=38557
TEST=manual

Review URL: http://codereview.chromium.org/1549020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43678 0039d316-1c4b-4281-b951-d872f2087c98

BUG=27570
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43677 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jnj
BUG=27570
TEST=Type "paypal.com", watch as it loads, ensure address doesn't shift sideways when the lock appears.
Review URL: http://codereview.chromium.org/1560015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43676 0039d316-1c4b-4281-b951-d872f2087c98

sync: Specify linking dependencies correctly. The browser library contains lots of files in chrome/browser/sync. They need to depend on the syncapi library and not just sync_proto.

BUG=none
TEST=Random CLs don't trigger linking errors.
TBR=nick
Review URL: http://codereview.chromium.org/1564010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43675 0039d316-1c4b-4281-b951-d872f2087c98

I don't understand why this is still causing the problem, but reverting this for now.

This reverts commit 6bb4f22703226e093644c28afe34d975cc7d549d.

Review URL: http://codereview.chromium.org/1612005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43674 0039d316-1c4b-4281-b951-d872f2087c98

BUG=38559
TEST=Manual test.

Review URL: http://codereview.chromium.org/1562011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43673 0039d316-1c4b-4281-b951-d872f2087c98

The way that breakpad calculates module ids has changed so we need to change
our tools to match.

(Note. The original change accidently landed with another change in r43662 so
this is just the review changes.)

http://codereview.chromium.org/1508019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43672 0039d316-1c4b-4281-b951-d872f2087c98

Safari deletes bookmarks using the backspace key, so we should too.

BUG=39211
TEST=Highlight a bookmark and press the backspace key, the delete key, or
meta+backspace.  All should delete the bookmark.

Review URL: http://codereview.chromium.org/1513017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43671 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/1545019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43670 0039d316-1c4b-4281-b951-d872f2087c98

This also makes some correctness/consistency fixes to the model that affect other OSes, e.g. we now allow "remove" on the selected exception set iff all selected exceptions are removable.

BUG=39817
TEST=Geolocation exceptions window exists on windows, allows sorting by either column
Review URL: http://codereview.chromium.org/1539021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43669 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43668 0039d316-1c4b-4281-b951-d872f2087c98

BUG=35038
TEST=LoginDatabaseTest

Review URL: http://codereview.chromium.org/1567022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@43667 0039d316-1c4b-4281-b951-d872f2087c98