- Nov 04, 2010
-
-
mdm@chromium.org authored
Loosely based on http://codereview.chromium.org/3038006 by estade. BUG=57437 TEST=cool zippy exception lists in DOMUI content settings Review URL: http://codereview.chromium.org/4191005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64998 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
BUG=none TEST=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64997 0039d316-1c4b-4281-b951-d872f2087c98
-
fbarchard@chromium.org authored
BUG=55165 TEST=tools/licenses.py Review URL: http://codereview.chromium.org/4341005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64996 0039d316-1c4b-4281-b951-d872f2087c98
-
- Nov 03, 2010
-
-
davej@chromium.org authored
Until volume key grabbing is removed from window manager, Chrome needs to keep responding to the key messages from window manager. This patch puts that functionality back in until this is done. BUG=chromium-os:6074, chromium-os:8635 TEST=Volume Up/Down and Mute keys should work when screen is locked and when logged in normally. Review URL: http://codereview.chromium.org/4420001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64994 0039d316-1c4b-4281-b951-d872f2087c98
-
xiyuan@chromium.org authored
This is a sad change that we have to hard code this. :( And hopefully, we will get the enterprise feature complete soon and could remove this hack. BUG=none. TEST=Verify that screen lock is enabled for google.com logins. Review URL: http://codereview.chromium.org/4347001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64992 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
The Jankometer is monitoring durations for each task, but most of the time, this work is not used. I changed the system to only sample the durations, unless someone turns on a watchdog, and then we monitor every event. The sampling is deterministic, (every N events is sampled) but should be fine when we aggregate across thousands of users in a histogram. r=brettw Review URL: http://codereview.chromium.org/4279003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64991 0039d316-1c4b-4281-b951-d872f2087c98
-
jar@chromium.org authored
This is a relanding of http://codereview.chromium.org/4174002 The change in this CL is that I've made the function to look for errors virtual, and over-rode it in StatsHistograms. The current override doesn't actually check for inconsistencies, so that the UMA checks (and renderer-to-histogram checks) won't complain and refuse to transport the histograms. BUG=61281 r=rvargas Review URL: http://codereview.chromium.org/4364001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64990 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
lib needs to be generated and included in the chrome frame binary. This may need a clobber. Bug=61011 TBR=amit Review URL: http://codereview.chromium.org/4445001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64989 0039d316-1c4b-4281-b951-d872f2087c98
-
rsimha@chromium.org authored
This patch exposes hooks for sync in TestingAutomationProvider that the chrome pyauto test suite can use. It contains the following changes: - Partial revert of an earlier change to ProfileSyncServiceHarness. Some of its methods were made pure virtual, but this ended up being unnecessary. Also ripped out unnecessary code from LiveSyncTest. - Minor refactor of ProfileSyncServiceHarness to allow for scenarios where the browser is restarted. - A bunch of new methods in TestingAutomationProvider: SignInToSync, GetSyncInfo, AwaitSyncCycleCompletion, EnableSyncForDatatypes and DisableSyncForDatatypes. - A new method in model_type.h/cc called ModelTypeFromString. Required for automation. - New APIs in pyauto.py for sync. - New test suite sync.py with sample tests. BUG=53651, 60970, 56460, 61639 TEST=run pyauto sync tests Review URL: http://codereview.chromium.org/4096004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64988 0039d316-1c4b-4281-b951-d872f2087c98
-
jshin@chromium.org authored
It's not generic, but is only used for 'filename' param. The CL is originally by James Simonsen I reviewed at http://codereview.chromium.org/4254001/show I added a check for ASCIIness for RFC 5987 extended header and a few tests to NetUti*.GetFileNameFromCD (net_unittests) and I*.ConvertCo*Norma* (base_unittests). I also replaced '\uxxxx' notation with the corresponding UTF-8 byte sequence because Visual Studio does not understand it yet. BUG=57830 TEST="net_unittests --gtest_filter=NetU*.GetFil*", "base_unittests --gtest_filter=I*.Conver*Norm*" and tests at http://greenbytes.de/tech/tc2231/ Original CL / Review: By James Simonsen; at http://codereview.chromium.org/4254001/show Review URL: http://codereview.chromium.org/4435001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64987 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
This CL causes Snap Start to only trigger if the certificate verification has completed by the time we are ready to send out the handshake message. It also adds a couple of NetLog entries and histograms around the Snap Start code. BUG=none TEST=none http://codereview.chromium.org/4408001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64986 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
and 3 xcode changes. Review URL: http://codereview.chromium.org/4106017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64985 0039d316-1c4b-4281-b951-d872f2087c98
-
arv@chromium.org authored
Re-design the malware interstitial page. The change is mostly about: make the 'go back' button big and green in a central place, to encourage people go back to safety; and more clear description about why we block the page. Sample screenshots at: https://docs.google.com/document/edit?id=1Kk2wxsj8JjIjlC1WUPamDlEPWZH-iWUoECMRdyQ9t_4&hl=en&authkey=CJKfrM0D Patch from Ke Wang <kewang@google.com> BUG=60813 TEST=unit_tests. To see the UI change, start the browser and try load some sites in malware blacklist. Review URL: http://codereview.chromium.org/4175003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64984 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@chromium.org authored
Compiling 32-bit mesa shared libraries with -fPIC did not help. http://build.chromium.org/p/chromium.memory/builders/Linux%20Tests%20%28valgrind%29%282%29/builds/232/steps/memory%20test%3A%20ui_1/logs/stdio [----------] 1 test from GPUUITest [ RUN ] GPUUITest.UITestLaunchedWithOSMesa Started Valgrind wrapper for this test, PID=6448 [6449:6449:1270472640591:ERROR:master_preferences.cc(137)] Failed to parse /mnt/data/build/slave/chromium-rel-linux-valgrind-tests-2/build/src/sconsbuild/Release/master_preferences valgrind: mmap(0x38000000, 2039808) failed in UME with error 22 (Invalid argument). valgrind: this can be caused by executables with very large text, data or bss segments. [6397:6397:1103/142706:1270745403157:ERROR:automation_proxy.cc(461)] Disconnecting channel after error! chrome/test/ui/ui_test.cc:444: Failure Value of: tab_proxy->NavigateToURLBlockUntilNavigationsComplete( url, number_of_navigations) Actual: 0 Expected: AUTOMATION_MSG_NAVIGATION_SUCCESS Which is: 1 file:///mnt/data/build/slave/chromium-rel-linux-valgrind-tests-2/build/src/chrome/test/data/gpu/webgl.html [6397:6397:1103/142706:1270745404805:ERROR:automation_proxy.cc(448)] Automation channel has been closed; dropping message! chrome/test/ui/ui_test.cc:380: Failure Value of: automation()->GetBrowserWindowCount(&window_count) Actual: false Expected: true chrome/test/ui/ui_test.cc:495: Failure Value of: tab_proxy.get() Actual: false Expected: true chrome/test/ui/gpu_uitest.cc:37: Failure Value of: GetActiveTabTitle() Actual: L"" Expected: std::wstring(L"SUCCESS: Mesa OffScreen") Which is: L"SUCCESS: Mesa OffScreen" [6397:6397:1103/142706:1270745405095:ERROR:automation_proxy.cc(448)] Automation channel has been closed; dropping message! chrome/test/ui/ui_test.cc:263: Failure Value of: automation()->SetFilteredInet(false) Actual: false Expected: true [6397:6397:1103/142706:1270745405175:ERROR:automation_proxy.cc(448)] Automation channel has been closed; dropping message! chrome/test/ui/ui_test.cc:267: Failure Value of: automation()->GetBrowserWindowCount(&window_count) Actual: false Expected: true [6397:6397:1103/142706:1270745405232:ERROR:automation_proxy.cc(448)] Automation channel has been closed; dropping message! chrome/test/ui/ui_test.cc:288: Failure Value of: browser_proxy.get() Actual: false Expected: true [ FAILED ] GPUUITest.UITestLaunchedWithOSMesa (305498 ms) [----------] 1 test from GPUUITest (305498 ms total) TEST=none BUG=61601 Review URL: http://codereview.chromium.org/4437001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64983 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=61816 TEST=Mac Valgrind goes green Review URL: http://codereview.chromium.org/4434001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64982 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Manually submitting http://codereview.chromium.org/4413001/show git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64981 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Removing some obsolete entries. DEPS found from using "gclient recurse pwd" and then examining redundant entries manually to verify they weren't used on other platforms. Review URL: http://codereview.chromium.org/4426001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64980 0039d316-1c4b-4281-b951-d872f2087c98
-
tessamac@google.com authored
This reverts commit fbf3155bc7b82cbf56c9e6bdbd806a81daf2f2ce. Also update docs. BUG=61650 TEST=Successfully ran build.py Review URL: http://codereview.chromium.org/4421001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64979 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
TEST=make sure we don't show WEP passphrase in UI, make sure forget network button works again BUG=chromium-os:8413, chomium-os:8441 Review URL: http://codereview.chromium.org/4162004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64976 0039d316-1c4b-4281-b951-d872f2087c98
-
bryeung@google.com authored
It isn't quite ready. BUG=none TEST=build and run chrome, can type in the omnibox again Review URL: http://codereview.chromium.org/4425001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64975 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
BUG=60211 Review URL: http://codereview.chromium.org/4222005 TBR=jam@chromium.org Review URL: http://codereview.chromium.org/4431001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64974 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
ImageCache remains on Extension, on the expectation that it will eventually be loaded at startup. BUG=56558 TEST=no functional change Review URL: http://codereview.chromium.org/4132005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64973 0039d316-1c4b-4281-b951-d872f2087c98
-
garykac@chromium.org authored
ChromotocolServer -> protocol::SessionManager ChromotocolConnection -> protocol::Session BUG=none TEST=compiles + make chromoting connection Review URL: http://codereview.chromium.org/4313001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64971 0039d316-1c4b-4281-b951-d872f2087c98
-
gene@google.com authored
Add notifications for printer settings changed, and periodic update to check for new printers. BUG=none TEST=Make sure CP proxy works on Linux. Review URL: http://codereview.chromium.org/4233004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64970 0039d316-1c4b-4281-b951-d872f2087c98
-
bryeung@google.com authored
BUG=none TEST=still compiles, passes try bots Review URL: http://codereview.chromium.org/4405001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64968 0039d316-1c4b-4281-b951-d872f2087c98
-
kkania@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/4337001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64967 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
It needs to launch a confirmation dialog, which it doesn't do yet. BUG=61042 TEST=manual Review URL: http://codereview.chromium.org/4245002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64966 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
replace the flag with a pref. There is still a flag for verbatim matching, which sky just added. BUG=58937 TEST=manual Review URL: http://codereview.chromium.org/4277001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64965 0039d316-1c4b-4281-b951-d872f2087c98
-
mpcomplete@chromium.org authored
Also moved a shared method from ExtensionEventRouter to ExtensionsService. BUG=58210 TEST=Install the extension in chrome/common/extensions/docs/examples/extensions/chrome_search. You should not see the UI artifacts described in the bug. Review URL: http://codereview.chromium.org/4234004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64964 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@google.com authored
GL_CHROMIUM_map_sub extensions by default. These are needed in WebGraphicsContext3D instances in support of the accelerated 2D canvas and video rendering functionality. Associated WebKit bug is https://bugs.webkit.org/show_bug.cgi?id=46894 . Tested on Linux with this refactoring, accelerated 2D canvas, and HTML5 video. BUG=none TEST=none Review URL: http://codereview.chromium.org/4268004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64963 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
BUG=http://code.google.com/p/chromium-os/issues/detail?id=8641 TEST=Disable cellular; enable cellular; activate cellular network. Verify no crash. Review URL: http://codereview.chromium.org/4374003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64962 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=60211 Review URL: http://codereview.chromium.org/4222005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64960 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Adding reliability suppression for crash in ICU's unicodestring::toutf8 called from CLD's NormalizeText routine. BUG=61800 TEST=None TBR=rafaelw Review URL: http://codereview.chromium.org/4415001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64959 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
Incur a delay of 5 seconds to reduce probability of of blocking shutdown on an http request. This is intended to be a temporary workaround hack. BUG=8429 TEST=none Review URL: http://codereview.chromium.org/4347003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64958 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
BUG=59146 TEST= Review URL: http://codereview.chromium.org/4327001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64957 0039d316-1c4b-4281-b951-d872f2087c98
-
robertshield@chromium.org authored
Re-disable ExtensionGalleryInstallApiTest.InstallAndUninstall that looks like it got accidentally re-enabled in r64517. BUG=55642 TEST=None Review URL: http://codereview.chromium.org/4311003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64956 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
don't build by themselves, this is part of a larger patch. You can see most of the serialization mechanics already checked in to the same directory. TEST=none BUG=none Review URL: http://codereview.chromium.org/4369001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64955 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@google.com authored
(This copies one line I missed during my previous incognito man patch.) BUG=61596 TEST=no gap between the tabs and toolbar as described in bug. Review URL: http://codereview.chromium.org/4387001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64954 0039d316-1c4b-4281-b951-d872f2087c98
-
agl@chromium.org authored
The Snap Start code in NSS worked like the prototype implementation in tlsclient. This had the library take care of resending the application data in the event of a mispredict. However, that was safe because it did certificate verification as the message was received. However, in Chrome, it's possible that a mispret could be triggered by the server having a different certificate and NSS would resend the application data before Chrome verified the certificate. This change removes that behaviour from NSS and makes the retransmission the job of ssl_client_socket_nss.cc. BUG=none TEST=none http://codereview.chromium.org/4213003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64953 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=49551 Review URL: http://codereview.chromium.org/4365001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64952 0039d316-1c4b-4281-b951-d872f2087c98
-