Skip to content
Snippets Groups Projects
  1. Apr 28, 2010
  2. Apr 27, 2010
  3. Apr 26, 2010
    • willchan@chromium.org's avatar
      SPDY: Fix Alternate-Protocol. · 2ff8b313
      willchan@chromium.org authored
      (1) In DoInitConnection() we do the existing spdy session check.  If it exists there, then we assuem it exists in DoSpdySendRequest().  Unfortunately, we didn't do the same check.  Use a member variable to store the HostPortPair.
      (2) In DoInitConnection(), we used the scheme://urlhost:urlport as the connection group.  With Alternate-Protocol, we used the scheme://urlhost:urlport even though we were connecting to a different port, with a different protocol (TLS).  This means we would mix conflicting sockets in the ClientSocketPool.  I fix this by dropping scheme://, since it's unnecessary, and would cause us not to share SSL sockets in different connection groups (since the specified scheme might be http://, but due to Alternate-Protocol, we actually do an SSL connect).  I also don't use the urlhost:urlport, but use the host:port that we actually connect to.
      
      TODO(willchan):
      Fix Alternate-Protocol so it works properly with proxies.  I need to change CONNECT for http proxies and patch the SOCKs connects.
      
      Review URL: http://codereview.chromium.org/1755005
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45627 0039d316-1c4b-4281-b951-d872f2087c98
      2ff8b313
  4. Apr 23, 2010
    • shess@chromium.org's avatar
      Re-instate the temporary revert from r45267. That reverted certain · 69c579e5
      shess@chromium.org authored
      Omnibox, toolbar, tab animations, and other UI changes for purposes of
      testing and merging into mstone-5.
      
      Additionally reverts these CLs to fix the earlier revert:
      r45271: [Mac] Image references missing from Omnibox revert.
      r45268: GTK fix merge failure in uber-revert.
      
      Additional revert which fixed a bug for the branch:
      r45381: [Mac] Omnibox popup icons and text lined up under toolbar.
      
      Slight merge conflict which should be good:
      r45322: GTK: Implement OnDragCanceled() for autocomplete...
      
      Also ++kThemePackVersion and regenerate the cached theme pak.
      
      Re-instated changes:
      r45213: GTK: Override cursor colors in chrome-theme mode.
      r45103: Support drawing nano tabs in the tabstrip.
      r45084: GTK: Position the EV certificate stuff inside a green bubble.
      r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon...
      r44957: GTK: Tint the geolocation icons in gtk mode.
      r44943: Changes FormatURL to not strip http if the host starts with ft...
      r44930: Remove an icon that is no longer used.
      r44929: SSL UI changes, Windows, code side (images are separate).
      r44859: SSL UI changes (icons).  TBRed since trybots hate binary patches.
      r44822: GTK: Select better greens in the native omnibox popup.
      r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat...
      r44789: [Mac] Bookmark star missing on NTP and BMM.
      r44775: [Mac] Centralize hack to make tests work with AutocompleteClas...
      r44678: Display the SECURITY_WARNING status in the location bar for the
      r44648: [Mac] Add an arrow cursor rect for the location image.
      r44615: Revert r44611 because it may have broken "unit_tests" on "Vist...
      r44611: Display the SECURITY_WARNING status in the location bar for the
      r44577: Revert 44572 - [Mac] Update locationbar icon as user types.
      r44572: [Mac] Update location-bar icon as user types.
      r44555: GTK: Use correct button mask on reload button.
      r44545: [Mac] Omnibox text drag drag URL when select-all.
      r44523: GTK: Prevent inappropriate drag of location bar location icon.
      r44519: GTK: make the primary selection include the url's scheme when ...
      r44492: [Mac] Fix search icon in keyword search to be right-side-up.
      r44415: GTK: Update top padding on icons in the autocomplete popup.
      r44401: GTK: Tint omnibox icons in GTK mode differently.
      r44380: GTK: Move reload in gtk mode and fix omnibox popup location.
      r44282: Fixes crash in autocomplete when typing some URLs. The problem
      r44273: [Mac] PDF icons for omnibox nits.
      r44269: Fix build break due to bad merge resolve
      r44268: Shift omnibox dropdown in and up on Windows, and square off th...
      r44178: GTK: fix TTS padding.
      r44177: Round the top left and right edges of the toolbar.
      r44171: Images only checkin for try server goodness.
      r44163: GTK: fix padding of autocomplete popup.
      r44152: [Mac] PDF icons for omnibox.
      r44145: GTK: Theme the icons in the location bar and use GTK colors fo...
      r44140: Strips http from the omnibox
      r44131: Fixes bugs in new tab strip animations where they weren't doin...
      r44116: Change the default theme colors.
      r44117: Add newline to EOF to fix CrOS builder.
      r44115: Make the bottom edges of the opaque frame rounded.
      r44091: [Mac] No star icon or page actions in omnibox on popups.
      r44087: Don't allow drag or click on location icon when editing in omn...
      r44021: [GTK] Add TTS lens graphic to linux TTS box.
      r44008: [Mac] Tweak location icon spacing in omnibox.
      r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca...
      r43972: Make the firstrun bubble point at a better spot now that the l...
      r43971: [Mac] Location icon in omnibox as drag source.
      r43970: Make the star and page action icons not appear on popup windows.
      r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly
      r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip:
      r43787: Allow location icon to be dragged & dropped.  This also fixes ...
      r43759: Changes end cap of tab-to-search images.
      r43740: Change bookmark bar toggle to ctrl-shift-b.
      r43723: Show Page Info dialog on mouse up, not mouse down.
      r43677: Fix Mac build failure.
      r43676: Replace omnibox icons with new set that are all the same size ...
      r43596: Fix browser test TestStarButtonAccObj.
      r43593: Disables TestStarButtonAccObj.
      r43582: Changes tab strip to use BoundsAnimator for tab strip animatio...
      r43563: GTK: don't show reload button for popup/app windows.
      r43562: Star/reload shuffle, Windows version.
      r43540: [Mac] Magnifying glass in keyword-search bubble.
      r43482: Adds images needed for new tab animation. I'm separating this ...
      r43422: Add reload mask resource.
      r43392: GTK: make the location icon a drag source.
      r43376: [Mac] Move star button into page-actions area of omnibox.
      r43357: [Mac] Line up omnibox popup under field.
      r43290: gtk: fix display of icons in omnibox popup
      r43269: GTK: fix reload button.
      r43249: [Mac] Rearrange SSL status icon/label in omnibox.
      r43248: BrowserThemePack: Adds persistant ids for the reload endcaps.
      r43241: GTK: more location bar updates.
      r43191: Fix memory leak in BrowserThemePack.
      r43154: GTK: set the new star button's ID
      r43151: Fix bad conflict resolution for r43146.
      r43146: GTK: toolbar reload/star shuffle.
      r43025: Show the location bar icon (almost) all the time, and have its...
      r43023: Add new images for new reload button. No code change.
      r42782: Remove this icon, now that it's no longer used (due to my secu...
      r42502: Omnibox M5 work, part 1: Security changes
      r42245: Check in new icons for omnibox security changes alone, so that...
      
      BUG=none
      TEST=People go back to complaining about missing http://.
      R=pkasting@chromium.org,beng@chromium.org
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45474 0039d316-1c4b-4281-b951-d872f2087c98
      69c579e5
    • vandebo@chromium.org's avatar
      Add net log entries that summarize transmit and receive byte counts. · a2006ece
      vandebo@chromium.org authored
      Tx/Rx summaries are integrated into the net log at the last point that bytes were transmitted or received.
      
      Hopefully this will help resolve http://crbug.com/37729 by showing if we've received bytes over the network when we hit the "Waiting for cache" bug.
      
      This change also modernizes the use of NetLog:
       - ClientSocket now has a net_log() accessor
       - ClientSocket::Connect no longer takes a NetLog, instead the TCPClientSocket constructor takes one, others use their transport socket's NetLog
       - TCPClientSocket creates a new source id with source type SOCKET
      
      Also updates PassiveLogCollector infrastructure:
       - The LiveRequestsObserver lets a RequestTracker update a RequestInfo just before it is displayed.  This allows ConnectJobs to be associated with URLRequests while connecting and then reassociated if they are late-bound to a different request.
      
      BUG=37729
      TEST=tx/rx lines show up in chrome://net-internals/
      
      Review URL: http://codereview.chromium.org/1696005
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45449 0039d316-1c4b-4281-b951-d872f2087c98
      a2006ece
    • jochen@chromium.org's avatar
      Send content settings based on the URL to the renderer instead of just the host. · 9d797f39
      jochen@chromium.org authored
      BUG=36025
      TEST=manual
      
      Review URL: http://codereview.chromium.org/1744003
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45424 0039d316-1c4b-4281-b951-d872f2087c98
      9d797f39
  5. Apr 22, 2010
    • phajdan.jr@chromium.org's avatar
      Mark TelnetServerTest.ServerClientSend as flaky. · 59a03882
      phajdan.jr@chromium.org authored
      TBR=apavlov
      
      TEST=still flaky
      BUG=38093
      
      Review URL: http://codereview.chromium.org/1730006
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45314 0039d316-1c4b-4281-b951-d872f2087c98
      59a03882
    • shess@chromium.org's avatar
      Temporarily revert certain Omnibox, toolbar, tab animations, and other · c5b90374
      shess@chromium.org authored
      UI changes for purposes of testing and merging into mstone-5.
      
      Also ++kThemePackVersion and regenerate the cached theme pak.
      
      Reverted changes:
      r45213: GTK: Override cursor colors in chrome-theme mode.
      r45103: Support drawing nano tabs in the tabstrip.
      r45084: GTK: Position the EV certificate stuff inside a green bubble.
      r44979: Subclassing the InfoBubble to handle anchoring bubbles basedon...
      r44957: GTK: Tint the geolocation icons in gtk mode.
      r44943: Changes FormatURL to not strip http if the host starts with ft...
      r44930: Remove an icon that is no longer used.
      r44929: SSL UI changes, Windows, code side (images are separate).
      r44859: SSL UI changes (icons).  TBRed since trybots hate binary patches.
      r44822: GTK: Select better greens in the native omnibox popup.
      r44814: GTK: navigate to URL on PRIMARY when middle-clicking the locat...
      r44789: [Mac] Bookmark star missing on NTP and BMM.
      r44775: [Mac] Centralize hack to make tests work with AutocompleteClas...
      r44678: Display the SECURITY_WARNING status in the location bar for the
      r44648: [Mac] Add an arrow cursor rect for the location image.
      r44615: Revert r44611 because it may have broken "unit_tests" on "Vist...
      r44611: Display the SECURITY_WARNING status in the location bar for the
      r44577: Revert 44572 - [Mac] Update locationbar icon as user types.
      r44572: [Mac] Update location-bar icon as user types.
      r44555: GTK: Use correct button mask on reload button.
      r44545: [Mac] Omnibox text drag drag URL when select-all.
      r44523: GTK: Prevent inappropriate drag of location bar location icon.
      r44519: GTK: make the primary selection include the url's scheme when ...
      r44492: [Mac] Fix search icon in keyword search to be right-side-up.
      r44415: GTK: Update top padding on icons in the autocomplete popup.
      r44401: GTK: Tint omnibox icons in GTK mode differently.
      r44380: GTK: Move reload in gtk mode and fix omnibox popup location.
      r44282: Fixes crash in autocomplete when typing some URLs. The problem
      r44273: [Mac] PDF icons for omnibox nits.
      r44269: Fix build break due to bad merge resolve
      r44268: Shift omnibox dropdown in and up on Windows, and square off th...
      r44178: GTK: fix TTS padding.
      r44177: Round the top left and right edges of the toolbar.
      r44171: Images only checkin for try server goodness.
      r44163: GTK: fix padding of autocomplete popup.
      r44152: [Mac] PDF icons for omnibox.
      r44145: GTK: Theme the icons in the location bar and use GTK colors fo...
      r44140: Strips http from the omnibox
      r44131: Fixes bugs in new tab strip animations where they weren't doin...
      r44116: Change the default theme colors.
      r44117: Add newline to EOF to fix CrOS builder.
      r44115: Make the bottom edges of the opaque frame rounded.
      r44091: [Mac] No star icon or page actions in omnibox on popups.
      r44087: Don't allow drag or click on location icon when editing in omn...
      r44021: [GTK] Add TTS lens graphic to linux TTS box.
      r44008: [Mac] Tweak location icon spacing in omnibox.
      r43977: GTK: don't show the star or page actions in ShouldOnlyShowLoca...
      r43972: Make the firstrun bubble point at a better spot now that the l...
      r43971: [Mac] Location icon in omnibox as drag source.
      r43970: Make the star and page action icons not appear on popup windows.
      r43954: Fixes bug in TabStrip where dragging tab out then back in rapidly
      r43864: Tweaks to BoundsAnimator/SlideAnimation and TabStrip:
      r43787: Allow location icon to be dragged & dropped.  This also fixes ...
      r43759: Changes end cap of tab-to-search images.
      r43740: Change bookmark bar toggle to ctrl-shift-b.
      r43723: Show Page Info dialog on mouse up, not mouse down.
      r43677: Fix Mac build failure.
      r43676: Replace omnibox icons with new set that are all the same size ...
      r43596: Fix browser test TestStarButtonAccObj.
      r43593: Disables TestStarButtonAccObj.
      r43582: Changes tab strip to use BoundsAnimator for tab strip animatio...
      r43563: GTK: don't show reload button for popup/app windows.
      r43562: Star/reload shuffle, Windows version.
      r43540: [Mac] Magnifying glass in keyword-search bubble.
      r43482: Adds images needed for new tab animation. I'm separating this ...
      r43422: Add reload mask resource.
      r43392: GTK: make the location icon a drag source.
      r43376: [Mac] Move star button into page-actions area of omnibox.
      r43357: [Mac] Line up omnibox popup under field.
      r43290: gtk: fix display of icons in omnibox popup
      r43269: GTK: fix reload button.
      r43249: [Mac] Rearrange SSL status icon/label in omnibox.
      r43248: BrowserThemePack: Adds persistant ids for the reload endcaps.
      r43241: GTK: more location bar updates.
      r43191: Fix memory leak in BrowserThemePack.
      r43154: GTK: set the new star button's ID
      r43151: Fix bad conflict resolution for r43146.
      r43146: GTK: toolbar reload/star shuffle.
      r43025: Show the location bar icon (almost) all the time, and have its...
      r43023: Add new images for new reload button. No code change.
      r42782: Remove this icon, now that it's no longer used (due to my secu...
      r42502: Omnibox M5 work, part 1: Security changes
      r42245: Check in new icons for omnibox security changes alone, so that...
      
      BUG=none
      TEST=Eyjafjallajokull
      R=pkasting@chromium.org,beng@chromium.org
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@45267 0039d316-1c4b-4281-b951-d872f2087c98
      c5b90374
  6. Apr 20, 2010
  7. Apr 19, 2010
  8. Apr 16, 2010
  9. Apr 14, 2010
    • cbentzel@chromium.org's avatar
      Kerberos uses an SPN (Service Principal Name) to identify a server. This is... · e5ae96a1
      cbentzel@chromium.org authored
      Kerberos uses an SPN (Service Principal Name) to identify a server. This is typically in the form "HTTP/host:port", with the ":port" suffix being optional, and the "HTTP/" prefix is fixed regardless of whether the service is accessed over HTTP or HTTPS.
      
      The issue this is fixing is that the URL host may be an incomplete domain name, a numerical address, or an alias for a canonical DNS name.
      
      By default, Chrome will skip adding the optional port to the SPN, and will use the canonical DNS name for the server (which may be the original server name if it is an A or AAAA record). This matches IE and Firefox's default behavior.
      
      Some intranets are set up so the original host name should be used rather than the canonical name. The canonical name resolution can be disabled with the --disable-spnego-cname-lookup command line flag.
      
      Some intranets are also set up so the optional port should be specified when it is non-standard (non 80 or 443). Use the --enable-spnego-port command line flag.
      
      BUG=29862
      TEST=net_unittests.exe --gtest_filter="*CanonicalName*"
      
      Review URL: http://codereview.chromium.org/1535019
      
      git-svn-id: svn://svn.chromium.org/chrome/trunk/src@44526 0039d316-1c4b-4281-b951-d872f2087c98
      e5ae96a1
  10. Apr 12, 2010
  11. Apr 09, 2010
  12. Apr 08, 2010
  13. Apr 07, 2010
  14. Apr 06, 2010
  15. Apr 05, 2010
  16. Apr 02, 2010
  17. Apr 01, 2010
  18. Mar 31, 2010
  19. Mar 29, 2010
  20. Mar 26, 2010
Loading