- Sep 02, 2010
-
-
tfarina@chromium.org authored
BUG=None TEST=trybots Review URL: http://codereview.chromium.org/3284005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58300 0039d316-1c4b-4281-b951-d872f2087c98
-
wtc@chromium.org authored
Don't call SSL_SetSessionOption after the initial handshake is done because it'll fail with the badReqErr (-909) error. R=rsleevi BUG=45576,52152 TEST=Visit any site that requests SSL client auth over renegotiation. Review URL: http://codereview.chromium.org/3208003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58299 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
The cookies test used to sometimes fail because it would load google.com twice and try to match cookies, but google.com can set slightly different cookies. While attempting to fix that I relaxed the test and refactored to make it more straightforward. BUG= TEST= Review URL: http://codereview.chromium.org/3353006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58298 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
Review URL: http://codereview.chromium.org/3367001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58297 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
BUG=chromium-os:6364 TEST=make sure EULA screen has 'crash report' checkbox checked by default even after the machine is reimaged. Review URL: http://codereview.chromium.org/3342004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58296 0039d316-1c4b-4281-b951-d872f2087c98
-
zelidrag@chromium.org authored
Fix for ChromeOS build, included linux version of plugin.vch file for now to please FILES.cfg requirements (we don't dump this file in ChromeOS image right now anyway).^M TEST=none BUG=none Review URL: http://codereview.chromium.org/3351003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58295 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
Sending try jobs to linux_view is a strong signal that we should also send the try jobs to linux_chromeos, and vice versa. BUG=none TEST=none Review URL: http://codereview.chromium.org/3291005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58294 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
ServiceProcesControlTest.LaunchTwice is timing out. Disable the test for now. TBR=tc@chromium.org BUG= TEST= Review URL: http://codereview.chromium.org/3349005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58291 0039d316-1c4b-4281-b951-d872f2087c98
-
phajdan.jr@chromium.org authored
TBR=jcivelli Review URL: http://codereview.chromium.org/3360003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58289 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
TBR=antonm,zmo Review URL: http://codereview.chromium.org/3347004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58281 0039d316-1c4b-4281-b951-d872f2087c98
-
mirandac@chromium.org authored
Read "make_default_for_user" preference from master_preferences file and set Chrome to default in installer if we are updating Chrome instead of installing a new version. The problem here is that now that we set the default browser preference from a web page, we are using master_preferences to communicate this desire to the browser. Because the user already has Chrome installed on his/her machine, the master_preferences file will not be written to their machine. Instead, we check for this preference in the installer itself, and set Chrome to be default for the user here. BUG=53656 TEST=Have Chrome installed on your machine, but *not* default browser. Run setup.exe to install a new version of Chrome, with a master_preferences file that includes the distribution preference "make_default_for_user":true. (This reflects what happens when the user downloads Chrome with the "make default" option checked). Chrome should be default browser. Review URL: http://codereview.chromium.org/3342002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58280 0039d316-1c4b-4281-b951-d872f2087c98
-
jiesun@google.com authored
1. ffmpeg use direct rendering for ogg/h264. webm still do not use direct rendering. for both cases, decoder owns buffers. 2. video renderer change to support flush in a more flexible way. 3. openmax 's both path had been merged and both recycle buffer, 4. finish/fine tune seek logic in openmax code . TEST=test matrix/player_x11/layout test. BUG = None Review URL: http://codereview.chromium.org/3014059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58279 0039d316-1c4b-4281-b951-d872f2087c98
-
ananta@chromium.org authored
the ViewHostMsg_AccessibilityObjectChildrenChange message. The crash occurs because we fail to find the BrowserAccessibility interface for the child id passed in. Fix is to NULL check the same. Bug=54142 Review URL: http://codereview.chromium.org/3295005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58278 0039d316-1c4b-4281-b951-d872f2087c98
-
tkent@chromium.org authored
This is needed to remove base/task.h base/timer.h dependency from the DRT code. BUG=none TEST=none Review URL: http://codereview.chromium.org/3298003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58277 0039d316-1c4b-4281-b951-d872f2087c98
-
sergeyu@chromium.org authored
Compilation on OpenBSD was broken by previous commits in the audio code. BUG=None TEST=None Review URL: http://codereview.chromium.org/3301007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58276 0039d316-1c4b-4281-b951-d872f2087c98
-
cmasone@google.com authored
BUG=chromium-os:4488 TEST=unit tests Review URL: http://codereview.chromium.org/3278001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58275 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
so it's implemented on all platforms. This makes the method available on Linux+Mac, while removing BitmapPlatformDevice::processPixels from Mac (doesn't appear to be used anywhere). Review URL: http://codereview.chromium.org/3227007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58274 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
Replaced use of NetAddress::Adopt() in ChromeAsyncSocket with the single-IP constructor. Clarified comment for NetAddress::Adopt(). BUG=54108 TEST=Windows sync integration tests Review URL: http://codereview.chromium.org/3353003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58273 0039d316-1c4b-4281-b951-d872f2087c98
-
aa@chromium.org authored
BUG=52913 TEST=Visual inspection. Review URL: http://codereview.chromium.org/3340005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58272 0039d316-1c4b-4281-b951-d872f2087c98
-
- Sep 01, 2010
-
-
erg@google.com authored
This reverts commit 4a76b908daffee441d9ebf9fbc74b4015d9145df (r58256) due to chromeos compile fail. TBR=akalin Review URL: http://codereview.chromium.org/3340007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58271 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58269 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@google.com authored
TBR=akalin git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58268 0039d316-1c4b-4281-b951-d872f2087c98
-
akalin@chromium.org authored
TBR=erg@chromium.org Review URL: http://codereview.chromium.org/3304005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58267 0039d316-1c4b-4281-b951-d872f2087c98
-
panayiotis@google.com authored
Review URL: http://codereview.chromium.org/3259004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58266 0039d316-1c4b-4281-b951-d872f2087c98
-
hclam@chromium.org authored
BUG=52891 TEST=browser_tests --gtest_filter=ServiceProcess* Removed ServiceProcessControl::Connect() and just have a Launch() method. The Launch() method will connect to the service process if the it has already been launched but not connected. The method will simply return if the process is already been launched connected. Review URL: http://codereview.chromium.org/3306001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58265 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=54052 TEST=none Review URL: http://codereview.chromium.org/3300004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58264 0039d316-1c4b-4281-b951-d872f2087c98
-
isherman@chromium.org authored
BUG=44591,18431 TEST=none Review URL: http://codereview.chromium.org/3322001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58263 0039d316-1c4b-4281-b951-d872f2087c98
-
georgey@chromium.org authored
BUG=49566 TEST=If there is any obfuscation, editing the field clears it. Review URL: http://codereview.chromium.org/3265005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58262 0039d316-1c4b-4281-b951-d872f2087c98
-
jcivelli@chromium.org authored
If the page reloads while such a navigation happens, we could end up with the wrong pending entry. Also make sure TestTabContents::NavigateAndCommit() does commit on the right RVH. BUG=51680 TEST=See bug for steps. Review URL: http://codereview.chromium.org/3257002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58261 0039d316-1c4b-4281-b951-d872f2087c98
-
johnnyg@chromium.org authored
BUG=52545 TEST=notifications on windows Review URL: http://codereview.chromium.org/3311006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58260 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
[GTK] a couple of constrained window fixes: 1) don't grab focus when the parent tab isn't showing. Grab the focus when the tab is brought to the front. 2) handle escape via normal key handling rather than accelerator keys 3) don't allow the content view to take focus (via tab) when the constrained window is showing. BUG=53242, 50799 TEST=see bugs. Also, tabbing between constrained window and url bar should work as expected. Review URL: http://codereview.chromium.org/3235010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58259 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
1) on ubuntu, firefox3 search engines are stored in a slightly different place. See bug 53899 for more info. 2) fix parse error in ReadPrefJsValue. Firefox pref values may contain parentheses, e.g. "Wikipedia (en)" BUG=53899 TEST=create a new firefox profile and set it as the default profile, and set firefox3 as the default browser. Launch chrome with --user-data-dir=/tmp/foo. The default set of firefox search engines should be silently imported. (Also, after I write a patch to do so, the first run ballot box should show the default ffox search engine along side the 3 defaults, if it is not one of the three defaults). Review URL: http://codereview.chromium.org/3221007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58258 0039d316-1c4b-4281-b951-d872f2087c98
-
jcivelli@chromium.org authored
BUG=53979 TEST=None (wish I knew how to repro...) Review URL: http://codereview.chromium.org/3341004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58257 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@google.com authored
This means browser.h no longer includes a large chunk of the tab restore system. BUG=none TEST=compiles Review URL: http://codereview.chromium.org/3296003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58256 0039d316-1c4b-4281-b951-d872f2087c98
-
erikkay@chromium.org authored
BUG=54006 TEST=install an extension with history permission. it should warn you about access to your browser history. Review URL: http://codereview.chromium.org/3357002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58251 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
BUG=19991 TEST=CertDatabaseNSSTest.ListCerts Review URL: http://codereview.chromium.org/3192021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58250 0039d316-1c4b-4281-b951-d872f2087c98
-
mattm@chromium.org authored
BUG=52916 TEST=run chrome with --enable-new-page-info-bubble, click on page info Review URL: http://codereview.chromium.org/3310002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58249 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=27038 TEST=Type in "site:yahoo.com foo". You should not go into keyword search mode. Review URL: http://codereview.chromium.org/3259010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58248 0039d316-1c4b-4281-b951-d872f2087c98
-
dhollowa@chromium.org authored
Adds migration unit tests to web database for missing images on the search ballot. This is follow-up from review http://codereview.chromium.org/3189004. BUG=52452, 50699, 10913 TEST=WebDatabaseMigrationTest.MigrateVersion22ToCurrent, WebDatabaseMigrationTest.MigrateVersion22CorruptToCurrent, WebDatabaseMigrationTest.MigrateVersion24ToCurrent Review URL: http://codereview.chromium.org/3295002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58247 0039d316-1c4b-4281-b951-d872f2087c98
-
sanjeevr@chromium.org authored
Registered the service process to AutoRun (for Windows) if any service (CloudPrint or Remoting) is enabled. When all services are disabled, we delete the AutoRun key. Also remembered the enabled state of the Cloud Print Proxy in the service prefs. BUG=None TEST=After enabling cloud print or chromoting on Windows, the service process should auto start on user login. Review URL: http://codereview.chromium.org/3257011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@58246 0039d316-1c4b-4281-b951-d872f2087c98
-