- Dec 30, 2010
-
-
brettw@google.com authored
Fix the circular dependency between gfx and app. This temporarily disables the Direct2D test while I fix this. TEST=none BUG=none git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70313 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@google.com authored
Remove win_util::FormatMessage and FormatLastWin32Error. These were only used in a couple of diagnostic places and one can always use the "Error Lookup" utility. Move window HWND-specific functions from base/win_util.h to a new file app/win/hwnd_util.h. I plan to put some more stuff from app/win_util into this file as well. Move gfx/window_impl.h into app/win TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6019007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70312 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
and bug 68304 (leaks in ResourceDispatcherHostTest.*) TBR=jam BUG=68290,68304 Review URL: http://codereview.chromium.org/6029007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70311 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70307 0039d316-1c4b-4281-b951-d872f2087c98
-
hamaji@chromium.org authored
BUG=none TEST=canary Review URL: http://codereview.chromium.org/6059009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70305 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
BUG=68292 TBR=timurrrr Review URL: http://codereview.chromium.org/6014011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70304 0039d316-1c4b-4281-b951-d872f2087c98
-
glider@chromium.org authored
BUG=68290 TBR=timurrrr Review URL: http://codereview.chromium.org/5975010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70303 0039d316-1c4b-4281-b951-d872f2087c98
-
hamaji@chromium.org authored
BUG=none TEST=canary Review URL: http://codereview.chromium.org/5961014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70302 0039d316-1c4b-4281-b951-d872f2087c98
-
hamaji@chromium.org authored
BUG=none TEST=canary Review URL: http://codereview.chromium.org/6037014 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70301 0039d316-1c4b-4281-b951-d872f2087c98
-
hamaji@chromium.org authored
BUG=68287 TEST=none Review URL: http://codereview.chromium.org/6046008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70300 0039d316-1c4b-4281-b951-d872f2087c98
-
hamaji@chromium.org authored
This reverts commit 8fe8d75034b59a29a11dcba674487f7733aa827f. BUG=none TEST=none Review URL: http://codereview.chromium.org/6009008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70299 0039d316-1c4b-4281-b951-d872f2087c98
-
hamaji@chromium.org authored
BUG=none TEST=canary Review URL: http://codereview.chromium.org/6079008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70298 0039d316-1c4b-4281-b951-d872f2087c98
-
sadrul@chromium.org authored
This should fix compile in the touch buildbot. BUG=touch buildbot is broken TEST=see bug Review URL: http://codereview.chromium.org/6038006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70297 0039d316-1c4b-4281-b951-d872f2087c98
-
viettrungluu@chromium.org authored
The placement of the new tab button was wrong when a placeholder is present ... but in that case the new tab button wasn't shown. BUG=none TEST=none Review URL: http://codereview.chromium.org/6036005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70296 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Review URL: http://codereview.chromium.org/6025009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70292 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=64263 TEST=compiled locally and trybots Review URL: http://codereview.chromium.org/5958008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70291 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=23581 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6044007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70290 0039d316-1c4b-4281-b951-d872f2087c98
-
suzhe@google.com authored
In order to fix https://bugs.webkit.org/show_bug.cgi?id=51693, I'm going to add following new method into WebKit::WebWidget interface: bool confirmComposition(const WebString& text) = 0; As PepperWidget implements WebKit::WebWidget interface directly, we need to add a dummy implementation of this new method into PepperWidget first to prevent chromium build from being broken. BUG=none TEST=none Review URL: http://codereview.chromium.org/5984006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70289 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6033008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70288 0039d316-1c4b-4281-b951-d872f2087c98
-
- Dec 29, 2010
-
-
acolwell@chromium.org authored
Revert 70277 - Revert 70275 - Revert 70267 - Refactor PipelineImpl to use CompositeFilter to manage Filter state transitions. BUG=54110 TEST=media_unittests CompositeFilterTest.* Review URL: http://codereview.chromium.org/5744002 TBR=acolwell@chromium.org Review URL: http://codereview.chromium.org/6026013 TBR=acolwell@chromium.org TBR=acolwell@chromium.org Review URL: http://codereview.chromium.org/5974011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70287 0039d316-1c4b-4281-b951-d872f2087c98
-
tfarina@chromium.org authored
BUG=None TEST=trybots Review URL: http://codereview.chromium.org/6040002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70286 0039d316-1c4b-4281-b951-d872f2087c98
-
mihaip@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/6042008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70285 0039d316-1c4b-4281-b951-d872f2087c98
-
rsimha@chromium.org authored
This patch contains a logging tweak to help debug an occasional sync integration test failure that repros only on the buildbots. TBR=tim@chromium.org BUG=68207 TEST=sync_integration_tests Review URL: http://codereview.chromium.org/6010007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70284 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6044006 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6051012 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/5989012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70283 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6044006 TBR=avi@chromium.org Review URL: http://codereview.chromium.org/6051012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70281 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
TEST=it compiles BUG=none Review URL: http://codereview.chromium.org/6041007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70280 0039d316-1c4b-4281-b951-d872f2087c98
-
chase@chromium.org authored
BUG=68218 TEST=page cycler timings results are printed without quotes TBR=phajdan.jr@chromium.org Review URL: http://codereview.chromium.org/6092004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70279 0039d316-1c4b-4281-b951-d872f2087c98
-
mihaip@chromium.org authored
http://webkit.org/b/51507). This allows scrollbar thumb rendering to be overridden, so that we can match the Mac port's when running under the DRT. BUG=23498 TEST=Layout tests Review URL: http://codereview.chromium.org/6041005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70278 0039d316-1c4b-4281-b951-d872f2087c98
-
acolwell@chromium.org authored
Revert 70275 - Revert 70267 - Refactor PipelineImpl to use CompositeFilter to manage Filter state transitions. BUG=54110 TEST=media_unittests CompositeFilterTest.* Review URL: http://codereview.chromium.org/5744002 TBR=acolwell@chromium.org Review URL: http://codereview.chromium.org/6026013 TBR=acolwell@chromium.org git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70277 0039d316-1c4b-4281-b951-d872f2087c98
-
brettw@chromium.org authored
used to support the weird way Chrome manages processes, so doesn't belong in the central CommandLine class. This also provides an empty implementation on Mac & Windows to avoid some ifdefs in the main functions. TEST=everything compiles BUG=none Review URL: http://codereview.chromium.org/6002013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70276 0039d316-1c4b-4281-b951-d872f2087c98
-
acolwell@chromium.org authored
BUG=54110 TEST=media_unittests CompositeFilterTest.* Review URL: http://codereview.chromium.org/5744002 TBR=acolwell@chromium.org Review URL: http://codereview.chromium.org/6026013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70275 0039d316-1c4b-4281-b951-d872f2087c98
-
avi@chromium.org authored
BUG=9911 TEST=no visible changes; all tests pass Review URL: http://codereview.chromium.org/6044006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70271 0039d316-1c4b-4281-b951-d872f2087c98
-
derat@chromium.org authored
This makes us send a message to the window manager when the user is logging out so the window manager can display a more graceful transition (currently, you can sometimes see the browser windows getting closed one by one). The power manager already sends a similar message to the window manager when we're shutting down. BUG=chromium-os:9915 TEST=built and tried it with an updated window manager. try bots pass too Review URL: http://codereview.chromium.org/6047005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70270 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
BUG:66795 Review URL: http://codereview.chromium.org/6079007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70269 0039d316-1c4b-4281-b951-d872f2087c98
-
tommi@chromium.org authored
When installing Chrome [x]or Chrome Frame in multi mode, check if the other product (CF xor Chrome) is installed. If it is, also include it in the installation as we need to update both products in sync. For Chrome Frame, I also added checks to see if CEEE is already enabled or if the user has already opted into GCF. If CEEE has been enabled, we implicitly include it when the install is run even though ceee is not on the command line. If ready-mode is set on the command line but Chrome Frame is already installed without it, we won't enable ready mode. TEST=Try installing Chrome Frame in multi mode. Then install a more recent version of Chrome in multi mode. Both product should be updated. Secondly, for Chrome Frame, install it first and then try to run the installer again, but with ready-mode ont the command line. Chrome Frame should not be switched to ready mode. BUG=61609 Review URL: http://codereview.chromium.org/6091008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70268 0039d316-1c4b-4281-b951-d872f2087c98
-
acolwell@chromium.org authored
BUG=54110 TEST=media_unittests CompositeFilterTest.* Review URL: http://codereview.chromium.org/5744002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70267 0039d316-1c4b-4281-b951-d872f2087c98
-
thakis@chromium.org authored
All the stacks are always in the destructors. Wild guess: Maybe NSSavePanel takes the context object from the delegate instead of self. Pass in the delegate as described by the docs. BUG=58959 TEST=maybe fewer crashes on the crash server Review URL: http://codereview.chromium.org/6031008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70265 0039d316-1c4b-4281-b951-d872f2087c98
-
dpolukhin@chromium.org authored
Crash dump from the bug shows that crash happened during call "bug_report_->UpdateData(...)" that was inlined into HandleSendReport. It looks like bug_report_ is NULL. bug_report_ is initialized with new object in HandleGetDialogDefaults that is called from JavaScript in window onload handler. So it looks like user clicked on send report button before the page is loaded and onload handler was called. BUG=chromium-os:10240 TEST=none Review URL: http://codereview.chromium.org/5958016 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70264 0039d316-1c4b-4281-b951-d872f2087c98
-
altimofeev@chromium.org authored
It fixes the problem with wrong native textfield size is used by the bookmark bubble. BUG=chromium-os:9853 TEST=manual Review URL: http://codereview.chromium.org/5981008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70262 0039d316-1c4b-4281-b951-d872f2087c98
-
danno@chromium.org authored
BUG=68099 TEST=manual testing of proxy policy Review URL: http://codereview.chromium.org/6021010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70259 0039d316-1c4b-4281-b951-d872f2087c98
-