- Aug 10, 2024
-
-
Koji Ishii authored
crrev.com/c/5776342 fixed a range `CHECK` in `CollectFallbackHintChars`, but depends on the CSS and font configurations, it's possible that the code doesn't go to `CollectFallbackHintChars` and the following code may hit the same issue. This patch adds another `CHECK` for the case. Bug: 355731798, 357622693 Change-Id: Ieb4ada7699c80564e8a4b866cb6a6ffbc665ebc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776204 Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1340006}
-
Koji Ishii authored
This patch fixes `SECURITY_DCHECK` in `StringView` for when `offset + length` overflows the `unsigned`. Bug: 357622693, 355731798 Change-Id: I5a7a7979192fe132496661b1272c5902cdbdb09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5775486 Auto-Submit: Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1340005}
-
Chrome Release Bot (LUCI) authored
* This is an automated release commit. * Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true Change-Id: Id82502c30de9de9b3a244b0d231eda5cd6c70528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778899 Bot-Commit: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1340004}
-
Tao Wu authored
We add a switch to provide a fake device registered time for testing. Bug: 358675970 Test: Added tests Change-Id: I99f29e909190e56d4c8ae34e6cf6637b4c44ba6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5777175 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Li Lin <llin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1340003}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1723247939-d3f20becf05dd0c6e63bbfec4254f641c57c8489-fa2b0dd3.profdata to chrome-mac-arm-main-1723255011-68ebfbbc1b19663a4c07b0716c63a4e38a40bc2c-850940ad.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I966f44f776e89cb7eb480de19fd6cb1a802b94d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778880 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1340002}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/clank/internal/apps.git/+log/2704e1265347..ebeed4c62d5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/clank-apps-chromium-autoroll Please CC chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: No-Try: true Change-Id: I19f21f30446ddc7570af7f4d26167f361f09361c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778427 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1340001}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-main-1723237160-98bdbd94226671bf220883eef4329b933361b89d-b0e64ff9.profdata to chrome-win32-main-1723247939-a72048440c587606e126d51f2eed0bd8b6ed1058-fa2b0dd3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic238b9a9f0a61bb4b4fd328507b805b3eb88eb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5777757 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1340000}
-
Chromium WPT Sync authored
https://github.com/web-platform-tests/wpt/compare/d4ae0ac58...c16b988b9 Using wpt-import in Chromium 7fd13225. With Chromium commits locally applied on WPT: 29472422 "webnn: Initialize memory allocated for CoreML and [...] 716e5d1c "Allow anchor attribute to be used on Element, not [...] 2db74c9f "webnn: Add a BYOB version of readBuffer()" Note to gardeners: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md NOAUTOREVERT=true R=rubber-stamper@appspot.gserviceaccount.com No-Export: true Validate-Test-Flakiness: skip Cq-Include-Trybots: luci.chromium.try:linux-blink-rel Change-Id: I27cae7d325035e5db7f11ba19b7e87dd13ceb6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778040 Auto-Submit: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1339999}
-
Qi Bao authored
The current logic will use old coordinator for new tab. Change-Id: I19a9ee671471f874ca952a8cf74591d634b3d893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776305 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Auto-Submit: Qi Bao <qib@google.com> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Qi Bao <qib@google.com> Reviewed-by:
Salvador Guerrero Ramos <salg@google.com> Cr-Commit-Position: refs/heads/main@{#1339998}
-
Vipul Vinod Koul authored
These flags were not added in the initial implementation due to misunderstanding that server flags would be able to control the rollout. Without these checks, a Chrome client which receives a Verve card without the flags being enabled, would crash during checkout. Bug: 358691307 Change-Id: I45ce35f733c91bf9a23c25f98163e1742bd9d93a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5777805 Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by:
Olivia Saul <jsaul@google.com> Commit-Queue: Vipul Koul <koulvipul@google.com> Cr-Commit-Position: refs/heads/main@{#1339997}
-
Kenichi Ishibashi authored
So that we can call the function for both HostResolverEndpointResult and ServiceEndpoint. This is a preparation for supporting ECH in HttpStreamPool. No behavior changes. Bug: 346835898 Change-Id: I31be2c8a2057c8a78690454c0d9fd5c152da3db1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5775902 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/main@{#1339996}
-
Keren Zhu authored
If a ui::PaintCache is used by two paint recorders, one of them might think it has a cache while the cache actually stores the draw OPs from the other recorder. This patch prevents this from happening with a DCHECK. See a bug caused by this issue in https://crrev.com/c/5778160. Bug: None Change-Id: I014c04ae548aa226ae65088538578a644b667fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778320 Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1339995}
-
chromium-autoroll authored
https://chromium.googlesource.com/v8/v8.git/+log/4c7435a792c0..7da667faa6aa 2024-08-10 v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Version 12.9.155 2024-08-09 pkasting@chromium.org .editorconfig should not set root = true. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/v8-chromium-autoroll Please CC liviurau@google.com,machenbach@google.com,v8-waterfall-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:dawn-linux-x64-deps-rel Change-Id: I8c56901ac87017947714848242240106d6a735ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778762 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1339994}
-
Sophie Chang authored
Update user annotations API to return the protos instead of a struct so the API is easier to inject into future model exec calls Bug: 356633475 Change-Id: I6136443ae857ea29568337957b40a4fdb2e00902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5775519 Reviewed-by:
Raj T <rajendrant@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1339993}
-
Liam Brady authored
A fix was checked in to attempt to de-flake the document-activeelement WPT. This CL removes the flakiness expectation from TestExpectations to check if the flakes are actually gone. Bug: 353256758 Change-Id: I6b8c92932ee0d87819a5a279bfb846cbd518182c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5777404 Reviewed-by:
Andrew Verge <averge@chromium.org> Commit-Queue: Andrew Verge <averge@chromium.org> Cr-Commit-Position: refs/heads/main@{#1339992}
-
John Rummell authored
This allows for determining if calls to RequestMediaKeySystemAccess are made using MediaCapabilities or not. UKM collection review doc: https://docs.google.com/document/d/1p8QuiSLAoT-l9GLvVGb5N8vEzviYF4jTmBJOQ_sezbM/edit?resourcekey=0-AkYq1xpDaCJiw-t4X8WpNw&tab=t.0 Bug: 348148930 Change-Id: Ia7fac899748bb861340378f0568fcfcef2cdbcb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5742578 Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/main@{#1339991}
-
Lei Zhang authored
Move this function out of an anonymous namespace, and make it a static method in PdfInkBrush. Then the function can be used in more places. Bug: 342602620 Change-Id: Id0b445b8ef672bc213acadab20573c5e7fb88dd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778759 Commit-Queue: Lei Zhang <thestig@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by:
Andy Phan <andyphan@chromium.org> Cr-Commit-Position: refs/heads/main@{#1339990}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file go/crostc-bug. Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium Please CC c-compiler-chrome@google.com,mobiletc-prebuild@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Main: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: mobiletc-prebuild@google.com Change-Id: Iccf2ad0be519cbfcef9aab4583917cf5d17cb07d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778455 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1339989}
-
BruceDai authored
This CL is to add some float32 conformance tests for gru and gruCell operators based from existed gru tests of ONNX CTS. Bug: 356298361 Change-Id: I24eff51c2e45384311946801831c9bae2e02a36f Cq-Include-Trybots: luci.chromium.try:win11-blink-rel,mac14-blink-rel,mac14.arm64-blink-rel Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5764428 Auto-Submit: Feng Dai <feng.dai@intel.com> Reviewed-by:
Austin Sullivan <asully@chromium.org> Commit-Queue: Feng Dai <feng.dai@intel.com> Reviewed-by:
David Baron <dbaron@chromium.org> Cr-Commit-Position: refs/heads/main@{#1339988}
-
chromium-autoroll authored
Roll Chrome Android ARM32 PGO profile from chrome-android32-main-1723226392-7d0d4d568a6efb8ce792cebb1eba932d4b3fcc97-5c577f79.profdata to chrome-android32-main-1723247939-7d9bc93a66df211391629580e35c1318b581b06b-fa2b0dd3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm32-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Icd8744307979a62ecd6a2b14040cf5135fbf9fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778819 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1339987}
-
Devlin Cronin authored
We are experimenting with desktop-android configurations for Chrome. Add a stub browsertest in //chrome/browser/extensions that will be included in desktop-android builds. This currently doesn't do much, but can be expanded to test extension capabilities. In the long term, we should *not* typically have separate tests for desktop-android; it's important that we re-use existing tests whenever possible. However, during this initial experimentation phase, having a separate test target will allow us to bootstrap an extension system without needing to have all components of extensions running. This allows us to add at least trivial test coverage for the components in extensions that we are enabling. Cq-Include-Trybots: luci.chromium.try:android-desktop-arm64-compile-rel,android-desktop-x64-compile-rel Bug: 356905053 Change-Id: I1be2c292b2cea1e40dbb4a638ecee9ef45b6e40f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778359 Reviewed-by:
David Bertoni <dbertoni@chromium.org> Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/main@{#1339986}
-
chrome-weblayer-builder authored
This CL updates the ash version ['128.0.6613.28'] for Lacros version skew testing. This cl only affect linux-lacros config builders like linux-lacros-tester-rel, linux-lacros-rel. This cl will certainly NOT affect Lacros on-device builders (lacros-amd64-generic-rel, lacros-amd64-generic-chrome-skylab, etc) or any other platforms. If this CL caused regressions, please revert and stop the autoroller at https://luci-scheduler.appspot.com/jobs/chrome/lacros-version-skew-roller Also please file a bug to OS>LaCrOS>Partner, and CC kuanhuang@chromium.org. R=rubber-stamper@appspot.gserviceaccount.com Bug: None Change-Id: Iabf905ad312e3cd8064a8f4de825bcda65e93e69 Requires-Testing: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5777394 Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Auto-Submit: chrome-weblayer-builder <chrome-weblayer-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1339985}
-
chromium-autoroll authored
Roll Chrome Win ARM64 PGO profile from chrome-win-arm64-main-1723226392-6c6c45f879bfdff0feb91623785d1cf2d095709e-5c577f79.profdata to chrome-win-arm64-main-1723247939-081920adfb9985fb25ae746944e9ec596fd521ca-fa2b0dd3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win-arm64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: I2d31555321d7d354a705f4a4f6783bbb8d82081e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778763 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1339984}
-
Andrey Kosyakov authored
Change-Id: I679ccff5ce3c09ba83d0a6e7d548a8ef146612b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5769798 Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/main@{#1339983}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1723240706-21bdc10843d1a9365a44357a089cf3da266a41d7-af9797b4.profdata to chrome-mac-arm-main-1723247939-d3f20becf05dd0c6e63bbfec4254f641c57c8489-fa2b0dd3.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1e68a6b438cb784f3d09a633850d7c2722491f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778625 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1339982}
-
Bryan Bernhart authored
Fixes an issue where a staging buffer was always created on first use because its last used fence value was initially set to UINT64_MAX which could never be considered "not in use" until a submission occurred first. Instead, this fence value should of been set the initial value of the queue's fence, which is considered "not in use" without requiring a submission first. Bug: 358594662 Change-Id: I960d4b55f468f92a8a34bcae896816f2d5e18fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5777470 Commit-Queue: ningxin hu <ningxin.hu@intel.com> Reviewed-by:
ningxin hu <ningxin.hu@intel.com> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/main@{#1339981}
-
EmiliaPaz authored
Disable all the tests in Mv2DisabledDialogControllerInteractiveUITest since they have consistent failures. Bug: 358567086 Change-Id: Iae05c0aa0c55c0d688f9d6ffe5b362d0e761ba3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778527 Commit-Queue: Devlin Cronin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Reviewed-by:
Devlin Cronin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Auto-Submit: Emilia Paz <emiliapaz@chromium.org> Commit-Queue: Emilia Paz <emiliapaz@chromium.org> Cr-Commit-Position: refs/heads/main@{#1339980}
-
Lei Zhang authored
Now that the frontend is only using the side bar and not the older annotation bar, the brush sizes sent to the backend are always in the expected range. Validate them. Also use base::checked_cast() to make sure there is no funny business when converting from doubles to floats, and consolidate the size handling code, now that every tool has a size. Bug: 341282609 Change-Id: I7fd2bee6cbec6d980bb82ee986ca5506d8fd5a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778127 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Andy Phan <andyphan@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1339979}
-
Cheick Cisse authored
This change ensures that the area is drawn beneath the line, with the point mark above it. Additionally, it adds a symbol to the point mark. Screenshot: https://screenshot.googleplex.com/5MvXJEcYepJsxcA.png Bug: chromium:354007195 Change-Id: I8375d0be95458b2344ede4bdd44322e334dd0157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5777380 Auto-Submit: Cheick Cisse <cheickcisse@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Cheick Cisse <cheickcisse@google.com> Cr-Commit-Position: refs/heads/main@{#1339978}
-
Vinny Persky authored
Bug: 40937065 Change-Id: Ifccb32113696d90e0245a7d9a3c4a9f772be3f88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5772969 Reviewed-by:
Olivia Saul <jsaul@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Reviewed-by:
Jan Keitel <jkeitel@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Vinny Persky <vinnypersky@google.com> Cr-Commit-Position: refs/heads/main@{#1339977}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/adcf51dd4480..bc01bf2277f4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5a6fba641c155a7c7f874c58fe249014e3b0ce3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5775438 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1339976}
-
Tomasz Wiszkowski authored
This is important for testing purposes; keeping these files in sync will allow us to improve internal definitions testing. NO_IFTTT=cl/661442612 Bug: b/358683018 Change-Id: I68879266d8ae88c9810744b643752191c371c920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778153 Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/main@{#1339975}
-
chromium-autoroll authored
Roll Chrome Android ARM64 PGO profile from chrome-android64-main-1723233487-ca6cc1c6eba320a724d1d6022181ffd7e20077cc-79c55741.profdata to chrome-android64-main-1723240706-f20f4b4bee13d906d50518f900678fd0f7e2e4e6-af9797b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-android-arm64-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: pgo-profile-sheriffs@google.com Change-Id: Icde0616cc385afb9931cc3f868ac346234747093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5777538 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1339974}
-
Jason Hu authored
Bug: 339455387 Change-Id: I6034d8133a03289cf9b06091e5653b8247c7d368 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5763336 Commit-Queue: Jason Hu <hujasonx@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ali Stanfield <stanfield@google.com> Cr-Commit-Position: refs/heads/main@{#1339973}
-
Mike Wasserman authored
Crash reports indicate `delegate_` may be null here in some cases. Bug: 358629543, 358618048 Test: No more crashes in known corner cases. Change-Id: I7bcb97b93c4f3c369ab9a6ecaffaddb2a1709ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778421 Auto-Submit: Mike Wasserman <msw@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/main@{#1339972}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-main-1723226120-ac0c0e9be3387fb43fffb954df673905506dac43-664efb6a.profdata to chrome-win32-main-1723237160-98bdbd94226671bf220883eef4329b933361b89d-b0e64ff9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ibbb2d2b297c039045ac23f490c01e244e8dbd5b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5777874 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1339971}
-
Gyuyoung Kim authored
This CL implements ExecuteUserJavaScript() method using RenderFrameHost::ExecuteJavaScript() method. Bug: 40257932 Change-Id: Icadee1ce1fe3e2d97a62920183449e4eca682c6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5772196 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/main@{#1339970}
-
Qihui Zhao authored
Screenshot: https://screenshot.googleplex.com/qpPyvnWhswPhNVi Mock: https://screenshot.googleplex.com/AzvkNFLx5strDiQ Bug: 296651802 Change-Id: I78b190ce711045eb58b86cedb3cfee6701383156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5777464 Reviewed-by:
Vinny Persky <vinnypersky@google.com> Reviewed-by:
Olivia Saul <jsaul@google.com> Commit-Queue: Qihui Zhao <qihuizhao@google.com> Cr-Commit-Position: refs/heads/main@{#1339969}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/bc89bb6cc1a1..adcf51dd4480 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC chrometto-team@google.com,perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ib262ec9f42d6cb80b9be500e4ab99c97343cd3f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5778126 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1339968}
-
Bo Liu authored
Let webview use kWebViewFrameRateHints to control enabling FrameIntervalDecider. * Add features::IsUsingFrameIntervalDecider() function and update existing feature checks. * Move kWebViewFrameRateHints to viz features and check it in features::IsUsingFrameIntervalDecider * Explicitly disable kUseFrameIntervalDecider in webview to avoid it being accidentally turned on. Bug: 346732738 Change-Id: I0b297e3ede6e687c7d45d3e68af63d73626b9a02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5776597 Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Kyle Charbonneau <kylechar@chromium.org> Commit-Queue: Bo Liu <boliu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1339967}
-