Use own our bzip2 error handler instead of the default which prints error messages to STDERR and calls exit(1).  This is better, since we will now crash instead of exiting.  This also removes some unnecessary code and error strings from bzip2.

BUG=1289861

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@115 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113 0039d316-1c4b-4281-b951-d872f2087c98

BUG=1282556

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@112 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111 0039d316-1c4b-4281-b951-d872f2087c98

M    base/message_loop.h
M    base/message_loop.cc
M    chrome/common/ipc_sync_channel.cc



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@110 0039d316-1c4b-4281-b951-d872f2087c98

M    base/message_loop.h
M    base/message_loop.cc
M    chrome/common/ipc_sync_channel.cc


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@109 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108 0039d316-1c4b-4281-b951-d872f2087c98

We had only kHomePage pref before, which if blank/set to chrome-internal: meant that the New Tab page should be shown when Home is pressed. Now we add a pref called kHomePageIsNewTabPage for this purpose, which allows us to set the kHomePage value during import without actually using it as the HomePage (effectively importing home page becomes importing a default suggestion for when the users want a home page instead of the New Tab page).

BUG=1295677


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@106 0039d316-1c4b-4281-b951-d872f2087c98

This is needed as a first step in further adjustments I'm going to be making to
Window, ClientView, etc.

B=1280060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@105 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@104 0039d316-1c4b-4281-b951-d872f2087c98

Move static utility functions to FrameUtil class.

B=1294302


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@100 0039d316-1c4b-4281-b951-d872f2087c98

Move the initial sizing of a Window into a separate function  (SetInitialBounds) to tidy up the Init method a bit. Move SetInitialFocus into private section since it's not used by subclasses.

B=1293984

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@99 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@98 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@97 0039d316-1c4b-4281-b951-d872f2087c98

- Windows now must have a Delegate. Just construct the default WindowDelegate
if
you don't want to have to write one in testing.
- Windows now obtain their contents view by asking the delegate via
WindowDelegate::GetContentsView.
- Contents views no longer need to manually store a pointer to the Window that
contains them, WindowDelegate does this automatically via its window()
accessor.

Reviewer notes:
- review window_delegate.h first, then
- window.h/cc
- custom frame window.h/cc
- constrained_window_impl.h/cc
- then everything else (just updating all call sites)

B=1280060

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@96 0039d316-1c4b-4281-b951-d872f2087c98

Fix one more glitch when drag-attaching a tab to the tabstrip. Other tabs in the strip were instantly sized to their start size for the insert tab animation (which is their current size) but this calculation didn't take into account the fact that a newly inserted tab has a minimum size so their initial size isn't just the width / n other tabs, it's (width / n other tabs) - (min width / n other tabs)

B=1285677

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@90 0039d316-1c4b-4281-b951-d872f2087c98

When run chrome with --no-sandbox, the renderer process calls the dtor of BrokerServicesBase. There some API calls have invalid parameters.

BUG=1296316



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86 0039d316-1c4b-4281-b951-d872f2087c98

Do the same in the overridden method in TestRenderViewHost.

TBR=abarth


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@85 0039d316-1c4b-4281-b951-d872f2087c98

B=1297990

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@84 0039d316-1c4b-4281-b951-d872f2087c98

This is actually a much simpler approach. Get the TabContents that the context menu was brought up for and reverse walk the list closing all Tabs that don't match. Duh.

B=1298878

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@83 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@82 0039d316-1c4b-4281-b951-d872f2087c98

Fix not closing the browser with hung, crashed and interstitial tabs. Adds a 1 second hang monitor for the beforeunload/unload events to fire.

BUG=1296059

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@81 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@80 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@74 0039d316-1c4b-4281-b951-d872f2087c98

Made changes to display the tooltip window when user navigates through the icons in the toolbar using keyboard arrow keys.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@73 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@72 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@71 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@70 0039d316-1c4b-4281-b951-d872f2087c98

but unclickable -- when something goes wrong and the page is fed garbage
input.  (I don't expect new users will ever see this, but migration bugs
in previous versions have made this a recurring problem.)



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68 0039d316-1c4b-4281-b951-d872f2087c98

TBR=glen

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@67 0039d316-1c4b-4281-b951-d872f2087c98

Puts back the optional unescaping of control characters and URL parse-affecting characters. That patch was reverted due to build problems.

This is heavily modified from the original patch. That patch required an additional function and a bunch of internal boolean flags. This one uses the new flags enum I wrote to add this to the existing functionality more cleanly.

BUG=1271340
BUG=1258819
Review URL: http://chrome-reviews.prom.corp.google.com/804

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@66 0039d316-1c4b-4281-b951-d872f2087c98

Makes the process model heuristic for generated searches only apply in --process-per-site, since it isn't relevant otherwise.  (This matters now that process-per-site-instance is the default.)

BUG=1256259
TEST=Visit a non-Google page, then run a search from the location bar.  The tab should switch renderer processes.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@65 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@64 0039d316-1c4b-4281-b951-d872f2087c98

Add a return value to InternalCloseTabContentsAt, indicating whether or not the TabContents was closed immediately or if we're waiting for an unload handler to fire.

Adjust indices in Close other tabs handler to take into account the fact that some tabs may not close immediately

B=1295790

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@63 0039d316-1c4b-4281-b951-d872f2087c98

Ugh. It turns out we were never properly removing the dragged tab from the source tabstrip when a drag was completed. This was causing various problems, which were highlighted when you reverted a drag (e.g. press esc or alt+tab while dragging).

See my comments inline in the diff for explanations.

This manifests as Venkat's latest repro in:

B=1262392

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@57 0039d316-1c4b-4281-b951-d872f2087c98

Save a few lines since I don't need a test fixture.  This was just silly oversight on my part due to not having written a new unittest in a while.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@56 0039d316-1c4b-4281-b951-d872f2087c98

Add a unittest for the JSONValueSerializer::set_allow_trailing_comma() method.  Fixes the return type in the header.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@55 0039d316-1c4b-4281-b951-d872f2087c98