to an Xcode variable, $(BUILT_PRODUCTS_DIR), which is not a shell variable.
The shell tries to treat it as a command expansion.  Use ${BUILT_PRODUCTS_DIR}
directly.

BUG=none
TEST=Nico
Review URL: http://codereview.chromium.org/353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30686 0039d316-1c4b-4281-b951-d872f2087c98

So when you select:
"http://www.google.com"

The context menu that will appear will be:
"Go to http://www.google.com"

Instead of:
"Search Google for http://www.google.com"

BUG=1978
TEST=open chromium, select a text that is a url, see if appears the menu "Go to..."; click on it,
see if it goes to the desired page.

Review URL: http://codereview.chromium.org/326026
Patch from tfarina.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30685 0039d316-1c4b-4281-b951-d872f2087c98

Lots of fixes to deal better with the floating bar on the
  NTP (e.g. chevron resize, chevron enabling only when there is
  overflow, ...)

Move layoutSubviews logic from bookmark_bar_toolbar_view to
  bookmark_bar_controller to better honor MVC.

BUG=http://crbug.com/24985, http://crbug.com/24827, http://crbug.com/22018

TEST=Lots of moves:
New browser with no bookmarks.
Go to New Tab Page.  Show Bookmark Bar.  
See "Other Bookmarks" button on right.
Do NOT see chevron.
Hover over and click on Other Bookmarks to be sure it doesn't draw out of bounds.
Disable bookmark bar (so it is now floating).
Repeat hover/click test.
Enable (so now attached).
Add bookmarks until chevron shows up.
Repeat hover/click test with chevron and Other Bookmarks.
Make browser wider and thinner; each time repeat hover/click test.
Detach bookmark bar (so floating on NTP).
Make browser wider and thinner; each time repeat hover/click test.
Carefully make browser wider/thinner so chevron appears/disappears.
Make sure chevron never overlaps a bookmark.
With chevron visible, quit & relaunch.  Make sure chevron visible.
With chevron NOT visible, quit & relaunch.  Make sure chevron not visible.


Review URL: http://codereview.chromium.org/348017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30684 0039d316-1c4b-4281-b951-d872f2087c98

These do not build, but are for experimentation.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/344041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30683 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/341062

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30681 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None
TBR=sgk

Review URL: http://codereview.chromium.org/351003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30680 0039d316-1c4b-4281-b951-d872f2087c98

So when you select:
"http://www.google.com"

The context menu that will appear will be:
"Go to http://www.google.com"

Instead of:
"Search Google for http://www.google.com"

BUG=1978
TEST=open chromium, select a text that is a url, see if appears the menu "Go to..."; click on it,
see if it goes to the desired page.

Review URL: http://codereview.chromium.org/326026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30679 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30678 0039d316-1c4b-4281-b951-d872f2087c98

A random side effect of this change is that it changes page action hover from bubble to tool tip.

BUG=24645
TEST=ExtensionApiTest.PageActionPopup

Review URL: http://codereview.chromium.org/347016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30677 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit f6429666a47eac17a18409d1743841bc44ed9a7a.

Review URL: http://codereview.chromium.org/351001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30676 0039d316-1c4b-4281-b951-d872f2087c98

BUG=24604
TEST=None

Review URL: http://codereview.chromium.org/344018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30675 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/341042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30674 0039d316-1c4b-4281-b951-d872f2087c98

The results are now sorted before being output, so there is no need
to pass the results through a sort filter.

Byte counts are now printed with comma separators between groups of
3 digits, so that 1234567 is now output as 1,234,567.

The summary.pl now has a number of more precise matches to better 
give a quick estimate of blame for each allocation stack.


r=mbelshe
Review URL: http://codereview.chromium.org/348034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30673 0039d316-1c4b-4281-b951-d872f2087c98

I removed a leak of "stack" objects, and made them a little
more lightweight by removing an unused member.

This change is only part of an option for chrome, that is not currently
linked in during any tests.  It can only currently be used under XP, so
build-bot tests are not currently appropriate.

r=mbelshe
Review URL: http://codereview.chromium.org/345033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30672 0039d316-1c4b-4281-b951-d872f2087c98

I am splitting out the pepper-specific portions of npapi.h.
This is because his code currently relies on a version
of npapi.h different from third_party\npapi\bindings.

Review URL: http://codereview.chromium.org/343069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30671 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30670 0039d316-1c4b-4281-b951-d872f2087c98

gcc-4.4 produces the warning "declaration does not declare anything", which becomes an error due to -Werror.

BUG=26413

Review URL: http://codereview.chromium.org/343072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30669 0039d316-1c4b-4281-b951-d872f2087c98

This is a backout of r30647, but also resurrects the change from
http://codereview.chromium.org/341022 to work around the crash that r30647
solved much more elegantly.

We can't really leave things broken on 10.6, though.  I killed most of a
perfectly good Friday evening trying to figure out how to salvage r30647,
but the DeferredAutoreleasePool approach seems doomed without making private
calls.

This makes me really sad.

BUG=25857, 26399, 26402
TEST=Does it launch on Snow Leopard now?  Does it crash when you close windows?
Review URL: http://codereview.chromium.org/339095

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30668 0039d316-1c4b-4281-b951-d872f2087c98

TEST=built chrome-os and non- binaries and made sure they worked as expected

Review URL: http://codereview.chromium.org/342069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30667 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30666 0039d316-1c4b-4281-b951-d872f2087c98

TBR=dank
TEST=media should stop being flaky on TSAN/Mac bot
Review URL: http://codereview.chromium.org/344046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30665 0039d316-1c4b-4281-b951-d872f2087c98

DevTools: add all scripts from afterCompile events when scripts panel is shown for the first timeBUG=26312
TEST=DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh

Review URL: http://codereview.chromium.org/341057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30664 0039d316-1c4b-4281-b951-d872f2087c98

I added these to try to look at exit codes in crashes, but we didn't find
antyhing surprising.  I'm now removing them.

r=nsylvain
Review URL: http://codereview.chromium.org/343053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30663 0039d316-1c4b-4281-b951-d872f2087c98

We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards. I now also maintain a fallback to walk the entire registered list of browsers forward if the active scan fails. This is likely only in a testing environment where a Browser may never have been activated.

This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.

http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30531

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30659
Review URL: http://codereview.chromium.org/330013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30662 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30661 0039d316-1c4b-4281-b951-d872f2087c98

BUG=25318
TEST=none

Review URL: http://codereview.chromium.org/339093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30660 0039d316-1c4b-4281-b951-d872f2087c98

Update: I removed TYPE_ANY to see if I could fool the builders into letting this pass without crashing in browser_tests. It makes the code uglier, but I want to debug and figure out what's going on.

Rework the way the FindBrowserWithProfile/Type methods work.

We now always walk the last active list backwards rather than consulting the last active then walking the registered browser list forwards.

This ensures that when the last active browser is a popup or app frame the last active TYPE_NORMAL browser is located when opening a new tab.

http://crbug.com/17498
TEST=Open an app frame. Open a browser window (Ctrl+N) and load a page. Minimize it. Open another browser window and minimize it. Activate the app frame. Press Ctrl+T. The second browser window should be restored and have a new tab added to it rather than the first.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30531
Review URL: http://codereview.chromium.org/330013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30659 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30658 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/342072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30657 0039d316-1c4b-4281-b951-d872f2087c98

When the user has highlighted something like a URL, in the context menu show an options to navigate rather than searching.  Original patch by Thiago Farina (see http://codereview.chromium.org/326026 ), r=me.

BUG=1978
TEST=Highlight "google.com" and right-click.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30656 0039d316-1c4b-4281-b951-d872f2087c98

TBR=atwilson
BUG=none
TEST=none



git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30655 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=rolandsteiner

Review URL: http://codereview.chromium.org/348030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30653 0039d316-1c4b-4281-b951-d872f2087c98

Now that the UI layer is accessible cross-platform, coalesce the DesktopNotificationService layer into one common module.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/343066

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30652 0039d316-1c4b-4281-b951-d872f2087c98

reverts menu_button to what it was before the fix. This way 19597 is
still fixed, and we don't have this crash. I'm working on a
regression test for coverage of this, but I don't want to hold up
anything with the fix. 

BUG=26279
TEST=see bug

Review URL: http://codereview.chromium.org/344043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30651 0039d316-1c4b-4281-b951-d872f2087c98

I'm submitting this as a separate CL so that the binary file lands and
that I can get good try server results.

TBR=mpcomplete

Review URL: http://codereview.chromium.org/339091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30650 0039d316-1c4b-4281-b951-d872f2087c98

R=ananta
TEST=none
BUG=26372

Review URL: http://codereview.chromium.org/348026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30649 0039d316-1c4b-4281-b951-d872f2087c98

BUG=26258
TEST=Border color of location bar matches the buttons on each side.

Review URL: http://codereview.chromium.org/348029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30648 0039d316-1c4b-4281-b951-d872f2087c98

autorelease pool in our run loop source if there is one already on the stack 
above us. This allows Cocoa to clean up all the objects at the same time as it 
expects to do. There may be more "interesting" code that can be removed now 
that this is in. Initially we were going to implement it by checking the 
nesting levels of the runloops, but it turns out by the time sendEvent is 
called at the upper level we are already out of the "CFRunloopRun" call so 
our nesting count isn't a valid indicator of our state.

TEST=1) See bug 25857. 2) Start up. Open 3+ windows. Quit.
BUG=25857

Review URL: http://codereview.chromium.org/343024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30647 0039d316-1c4b-4281-b951-d872f2087c98

the incoming index. Callers expect GL errors to be raised for out of
range indices.

BUG=http://crbug.com/26331
TEST=WebKit/LayoutTests/fast/canvas/webgl/getActiveTest.html
(preexisting test; there are two remaining failures which are bugs in
the test)

Review URL: http://codereview.chromium.org/348027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30646 0039d316-1c4b-4281-b951-d872f2087c98

In theory this should result in a slightly faster app startup.

I will do a follow up change to merge it on Windows and get rid of
the code related to the extra file.

BUG=24035

Review URL: http://codereview.chromium.org/344038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30644 0039d316-1c4b-4281-b951-d872f2087c98