- Sep 23, 2009
-
-
ager@chromium.org authored
Only one change to the V8 gyp file to fix problem for gcc 4.4. BUG=none TEST=none Review URL: http://codereview.chromium.org/220005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26918 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@google.com authored
TBR=pfeldman Review URL: http://codereview.chromium.org/218003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26917 0039d316-1c4b-4281-b951-d872f2087c98
-
ager@chromium.org authored
Uninitialized memory read fix. This time without the change that causes test shell test failures. Review URL: http://codereview.chromium.org/225006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26916 0039d316-1c4b-4281-b951-d872f2087c98
-
ager@chromium.org authored
Review URL: http://codereview.chromium.org/219009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26914 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@google.com authored
Review URL: http://codereview.chromium.org/229002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26913 0039d316-1c4b-4281-b951-d872f2087c98
-
ager@chromium.org authored
This version contains a fix for an uninitialized memory read. BUG=22702 TEST=none Review URL: http://codereview.chromium.org/229003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26912 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
(This changelist is prepared by Alexander Potapenko, cc'ed) This is a small refactoring that moves the GDB querying logic into a separate module to allow us using it from tsan_analyze as well (we need it finally). The diff is almost equal to http://codereview.chromium.org/175026, I've only swapped two lines to make it applicable to the current trunk version. Review URL: http://codereview.chromium.org/211023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26911 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
Review URL: http://codereview.chromium.org/216050 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26910 0039d316-1c4b-4281-b951-d872f2087c98
-
pfeldman@chromium.org authored
BUG=22570 Review URL: http://codereview.chromium.org/212047 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26909 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@google.com authored
evaluateInCallFrame is called on InjectedScriptAccess instead of InspectorController in ScriptsPanel.js so we need to update Chrome-specific devtools code. Review URL: http://codereview.chromium.org/208059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26908 0039d316-1c4b-4281-b951-d872f2087c98
-
ojan@chromium.org authored
Review URL: http://codereview.chromium.org/215054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26907 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
BUG=None TEST=None TBR=sgk Review URL: http://codereview.chromium.org/219007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26906 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
directories to prevent them from stomping each other when they have names that are the same. Also adding some dependencies on theme_resources, webkit_resources, that were missing, but undetected due to everyone sharing the same output directory. BUG=22385 TEST=None Review URL: http://codereview.chromium.org/208056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26904 0039d316-1c4b-4281-b951-d872f2087c98
-
sgk@google.com authored
files to be included in the build (common.gypi and */supplement.gypi). BUG=none TEST=successful "gclient runhooks" Review URL: http://codereview.chromium.org/214058 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26901 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
Review URL: http://codereview.chromium.org/222002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26899 0039d316-1c4b-4281-b951-d872f2087c98
-
davemoore@chromium.org authored
functionality. Call into it and show new battery images Review URL: http://codereview.chromium.org/215025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26898 0039d316-1c4b-4281-b951-d872f2087c98
-
mal@chromium.org authored
We need to start using the /edgedl prefix. BUG= b/2111073 Review URL: http://codereview.chromium.org/217021 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26897 0039d316-1c4b-4281-b951-d872f2087c98
-
arv@chromium.org authored
BUG=None TEST=The theme promo should show up in the lower right corner and when clicked should navigate to the Chrome theme gallery. The promo should go away after 5 runs of chrome Review URL: http://codereview.chromium.org/217020 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26894 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
TBR=stuartmorgan Review URL: http://codereview.chromium.org/224001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26893 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26892 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
- Change hardcoded "Google Chrome" to product name. - Implement for GTK. BUG=21652 Review URL: http://codereview.chromium.org/212051 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26891 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
BUG=22372 Review URL: http://codereview.chromium.org/211056 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26890 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=dank BUG=22702 TEST=Linux valgrind bots Review URL: http://codereview.chromium.org/222001 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26889 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=paul BUG=None TEST=Webkit Mac10.5 Debug Review URL: http://codereview.chromium.org/219002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26888 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@google.com authored
I didn't update the big_test although I'm happy to do that in another CL. I changed the CB renderer code to use this. The only place I didn't is the state handling code. I'll consider changing that in another CL. I changed DoCommand so it gets passed the entire command data including the command itself where as it used to get passed the command buffer entry after the command. I wanted to put the commands into the structures as I think it makes them easier to use since they can then correctly set their header. I could have left DoCommand as is but there would have been a lot of funky pointer math and I thought this change made it cleaner. Some questions I had while doing this. There are a few places in the code that use unsigned int instead of uint32. It seems we should use uint32 because unsigned int is not guarnteed to be 32bits. So for example ResourceID is unsigned int right now. The CMD::Set/CMD::Init/CommandBufferHelper commands are currently fairly untyped. For example DESTROY_TEXTURE takes a uint32 id. Should it take a ResourceID instead? DRAW should maybe take an enum for primitive_type? If we decide to do that I'd like to do it in another CL. There's no checking for overflow. We could add a bunch of DCHECK like DCHECK_LE(width, 65536) or DCHECK_LE(semantic_index, 16). I'd like to do those in another CL as well as I think we need to discuss what commands we want to change. All the code is in .h files because we want all of this code to inline. Theoretically this should be just as efficient as poking values into arrays in the opt builds. Review URL: http://codereview.chromium.org/212018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26886 0039d316-1c4b-4281-b951-d872f2087c98
-
ojan@chromium.org authored
the number of skipped results on sharded builders. This has been true forever. I'll have a partial fix for that in a separate change. This time, the data format is really done and ready to be turned into pretty graphs. The data for each row in this table is created as an array, then getHTMLForTableRow is called. The graph version of this should be able to just rewrite getHTMLForTableRow to use canvas instead. Review URL: http://codereview.chromium.org/208062 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26885 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=nsylvain BUG=22711 TEST=Selenium test bot Review URL: http://codereview.chromium.org/212054 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26884 0039d316-1c4b-4281-b951-d872f2087c98
-
- Sep 22, 2009
-
-
stuartmorgan@chromium.org authored
TBR=paul BUG=None TEST=Linux webkit dbg Review URL: http://codereview.chromium.org/215061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26882 0039d316-1c4b-4281-b951-d872f2087c98
-
nsylvain@chromium.org authored
TBR:paulg BUG:22702 Review URL: http://codereview.chromium.org/212052 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26881 0039d316-1c4b-4281-b951-d872f2087c98
-
gspencer@google.com authored
the product dir. Review URL: http://codereview.chromium.org/210044 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26880 0039d316-1c4b-4281-b951-d872f2087c98
-
gman@google.com authored
August 3rd rev 22348. The scary thing is that's a little hard to believe it's been broken that long and no one noticed so I hope this is the correct fix but it does appear to be wrong. The '/'s that were removed are used in a string concat in the HTML templates. Sometimes they need to be '' and sometimes 'folder/' so that urls become http://foo/bar.html or http://foo/folder/bar.html Review URL: http://codereview.chromium.org/213033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26879 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=dank BUG=22702 TEST=Mac and Linux valgrind bots Review URL: http://codereview.chromium.org/214059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26874 0039d316-1c4b-4281-b951-d872f2087c98
-
paul@chromium.org authored
BUG=To be created. TEST=Covered by layout tests. Review URL: http://codereview.chromium.org/207064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26873 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
Keep TIMEOUT for Windows. TBR=dumi BUG=21442,22296,19766 TEST=N/A Review URL: http://codereview.chromium.org/207063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26872 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@google.com authored
See o3d/command_buffer/service/cross/cmd_buffer_engine.h. TEST=none BUG=none Review URL: http://codereview.chromium.org/207061 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26871 0039d316-1c4b-4281-b951-d872f2087c98
-
kbr@google.com authored
full-screen changes in http://codereview.chromium.org/210005 . Call CComControlBase::IOleInPlaceObject_SetObjectRects directly as the superclass implementation of CHostControl::SetObjectRects. Review URL: http://codereview.chromium.org/216055 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26870 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
TBR=dumi BUG=21442,22296,19766 TEST=N/A Review URL: http://codereview.chromium.org/217023 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26869 0039d316-1c4b-4281-b951-d872f2087c98
-
paul@chromium.org authored
BUG=22696 TEST=Covered by ui_tests. Review URL: http://codereview.chromium.org/211053 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26868 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
Review URL: http://codereview.chromium.org/217018 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26865 0039d316-1c4b-4281-b951-d872f2087c98
-
sky@chromium.org authored
why we're not going to implement some. BUG=none TEST=none Review URL: http://codereview.chromium.org/207057 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@26864 0039d316-1c4b-4281-b951-d872f2087c98
-