- Nov 02, 2009
-
-
yaar@chromium.org authored
(in preparation for upstreaming the api) Review URL: http://codereview.chromium.org/340049 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30764 0039d316-1c4b-4281-b951-d872f2087c98
-
gwilson@google.com authored
Changes the layout test formatter to apply lenient permissions on created files. This is so buildbots can easily scp these files to the right place and clean them up. R=ojan TEST=run test_output_formatter.sh, all created files should be rwxrwxrwx BUG=none Review URL: http://codereview.chromium.org/341059 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30763 0039d316-1c4b-4281-b951-d872f2087c98
-
jrg@chromium.org authored
BUG=http://crbug.com/19408 TEST=Create a bookmark. Create 2 bookmark folders both with the same name, "foo". Go to your bookmarked page. Click STAR to get bookmark bubble. Change parent folder to the 1st "foo". Confirm it's there on the bar. Click STAR to get bookmark bubble. Change parent folder to the 2nd "foo". Confirm it's there on the bar. Click STAR to get bookmark bubble. Chose "choose another folder" to be sure that logic still works. Review URL: http://codereview.chromium.org/340042 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30762 0039d316-1c4b-4281-b951-d872f2087c98
-
nirnimesh@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/348045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30761 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Avoid a CHECK when the modal_loop_pump_messages_event handle comes in as NULL to the renderer. This happens with some "virus scanners". BUG=25583 Review URL: http://codereview.chromium.org/348046 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30760 0039d316-1c4b-4281-b951-d872f2087c98
-
sehr@google.com authored
native client build (and in the toolchain, which is where the #ifdef stuff comes from). Review URL: http://codereview.chromium.org/342079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30759 0039d316-1c4b-4281-b951-d872f2087c98
-
erikkay@chromium.org authored
BUG=26502 TEST=none Review URL: http://codereview.chromium.org/345043 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30758 0039d316-1c4b-4281-b951-d872f2087c98
-
stuartmorgan@chromium.org authored
BUG=26386 TEST=Try to print from the Page menu on the Mac; the Print item should be enabled. Review URL: http://codereview.chromium.org/341071 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30757 0039d316-1c4b-4281-b951-d872f2087c98
-
joi@chromium.org authored
TEST=none BUG=none Review URL: http://codereview.chromium.org/354012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30756 0039d316-1c4b-4281-b951-d872f2087c98
-
tc@google.com authored
This gives us one less file to load on startup. This does mean that some tests need to explicitly include theme_resources.rc. BUG=24035 Review URL: http://codereview.chromium.org/348033 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30755 0039d316-1c4b-4281-b951-d872f2087c98
-
creis@chromium.org authored
(Related to http://codereview.chromium.org/348025) BUG=25097 TEST=RenderWidgetHostTest.ResizeThenCrash Review URL: http://codereview.chromium.org/353008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30753 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=25354 Review URL: http://codereview.chromium.org/348037 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30751 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
Some more test_expectations cleanup. Trying to document some flakiness from the past 50 runs or so. BUG=9798,13907,22014,24182,26195 TEST=none TBR=hclam Review URL: http://codereview.chromium.org/340068 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30750 0039d316-1c4b-4281-b951-d872f2087c98
-
craig.schlenter@chromium.org authored
Needed since r732 of gyp. TEST=Shared build on linux finds libs now without needing to manually adjust LD_LIBRARY_PATH. Review URL: http://codereview.chromium.org/340060 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30749 0039d316-1c4b-4281-b951-d872f2087c98
-
rvargas@google.com authored
If the last pair of headers match the entry that we have we allow the server response to update the entry. BUG=23222 TEST=unittests Review URL: http://codereview.chromium.org/345019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30748 0039d316-1c4b-4281-b951-d872f2087c98
-
dumi@chromium.org authored
BUG=none TEST=none Review URL: http://codereview.chromium.org/334039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30747 0039d316-1c4b-4281-b951-d872f2087c98
-
craig.schlenter@chromium.org authored
Error was: third_party/libjingle/files/talk/base/asynctcpsocket.cc:172: error: ‘strerror’ is not a member of ‘std’ Filed upstream: http://code.google.com/p/libjingle/issues/detail?id=54 TEST=builds with gcc 4.4 now Review URL: http://codereview.chromium.org/341067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30746 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
Fix a problem in the implementation of search-vs.-go-in-context-menus. We were eliding the text before passing it to the classifier, resulting in wrong destination URLs for elided strings. This also eliminates a couple string conversions and shortens the EscapeAmpersand() algorithm. BUG=1978 TEST=Highlight a long string in a page. Right-click it. Verify the string is elided in the context menu. Click the search entry. Verify the string you searched for is not elided. Review URL: http://codereview.chromium.org/343081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30745 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=25822 TEST=none Review URL: http://codereview.chromium.org/343067 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30744 0039d316-1c4b-4281-b951-d872f2087c98
-
thomasvl@chromium.org authored
See http://codereview.chromium.org/340045 for the original code. This includes a newer version of GTM that solves the problem with nib loading on 10.6. TEST=http://codereview.chromium.org/340045 BUG=none Review URL: http://codereview.chromium.org/343082 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30743 0039d316-1c4b-4281-b951-d872f2087c98
-
slightlyoff@chromium.org authored
BUG=26506 TEST=None Review URL: http://codereview.chromium.org/343085 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30742 0039d316-1c4b-4281-b951-d872f2087c98
-
apatrick@google.com authored
Conditionally added pepper_test_plugin.gyp as all.gyp dependency based on whether enable_pepper variable is set to 1. Defaults to 0. Added run_as block to automatically launch chrome and load the plugin when the pepper_test_plugin project is run or debugged. See new instructions in updated README. TEST=none BUG=none Review URL: http://codereview.chromium.org/343070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30741 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
Mark failing layout tests from WebKit 50407:50416. Sorry for the redness -- trybots were failing to patch, and canaries were dead, so I had to fly blind. BUG=none TEST=green? TBR=slightlyoff Review URL: http://codereview.chromium.org/341070 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30739 0039d316-1c4b-4281-b951-d872f2087c98
-
piman@chromium.org authored
Review URL: http://codereview.chromium.org/339079 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30738 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=25354 Review URL: http://codereview.chromium.org/354002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30737 0039d316-1c4b-4281-b951-d872f2087c98
-
ojan@chromium.org authored
This should fix issues with the layout_test_results.zip files on the bots have results from other runs, which makes debugging flakiness and other failures harder. Add a flag, clobber-old-results that defaults to false. We'll need to add the flag to the bots, but this will maintain the old behavior for local runs of run_webkit_tests. I'd also be fine not having a flag and always clobbering, but I don't know if people rely on the current behavior for their workflows. Review URL: http://codereview.chromium.org/340064 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30736 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
This brings several bugfixes needed for turning on the heap leak checker inside tcmalloc. Unforked malloc_hook.cc for Linux This patch was prepared by Alexander Potapenko (cc'ed) and originally reviewed as http://codereview.chromium.org/339065 Review URL: http://codereview.chromium.org/340065 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30735 0039d316-1c4b-4281-b951-d872f2087c98
-
senorblanco@chromium.org authored
BUG=none TEST=will it blend? Review URL: http://codereview.chromium.org/340063 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30734 0039d316-1c4b-4281-b951-d872f2087c98
-
timurrrr@chromium.org authored
Review URL: http://codereview.chromium.org/345039 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30732 0039d316-1c4b-4281-b951-d872f2087c98
-
rafaelw@chromium.org authored
This reverts http://src.chromium.org/viewvc/chrome?view=rev&revision=30726 TBR=estade Review URL: http://codereview.chromium.org/343080 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30731 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@google.com authored
TEST=DevToolsSanityTest.TestResourceContentLength TBR=pfeldman@chromium.org Review URL: http://codereview.chromium.org/346031 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30730 0039d316-1c4b-4281-b951-d872f2087c98
-
gspencer@google.com authored
over to GYP. It also copies the contents of DEPS_gyp to DEPS, and removes the DEPS_gyp file. Review URL: http://codereview.chromium.org/354011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30729 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=26493 TBR=tim Review URL: http://codereview.chromium.org/342081 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30728 0039d316-1c4b-4281-b951-d872f2087c98
-
evan@chromium.org authored
BUG=24672 TEST=Compiles Patch by Thiago Farina <thiago.farina@gmail.com>. Review URL: http://codereview.chromium.org/348035 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30727 0039d316-1c4b-4281-b951-d872f2087c98
-
estade@chromium.org authored
mouse move events. This prevents an HTML widget from staying in the mouseover state when the cursor leaves the window. Add a new ui test that checks the specific case that was broken by warping the mouse pointer inside and outside the content area. BUG=24660 TEST=ui_tests patch by Dominic Mazzoni <dmazzoni [at] google> original review: http://codereview.chromium.org/274010/show Review URL: http://codereview.chromium.org/354010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30726 0039d316-1c4b-4281-b951-d872f2087c98
-
yurys@google.com authored
Currently lengthReceived always has the same value as dataLength when Safari calls ResourceHandle::didReceiveData. In Chrome expected content length is passed as lengthReceived parameter which leads to incorrect content length to be stored in InspectorResource. InspectorResource expects lengthReceived to be the length of current data chunk(see InspectorResource::addLength). So I changed lengthReceived parameter to be dataLength. Darin, I see your TODO comment at line 581 in http://src.chromium.org/viewvc/chrome/trunk/src/webkit/glue/weburlloader_impl.cc?annotate=6296 (the comment was deleted later) so I think you are right person to review the change in weburlloader_impl.cc. Please look at weburlloader_impl.cc and feel free to leave devtools specific changes to Alex and Pavel. BUG=25213 TEST=DevToolsSanityTest.TestResourceContentLength Review URL: http://codereview.chromium.org/295041 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30725 0039d316-1c4b-4281-b951-d872f2087c98
-
tony@chromium.org authored
It was removed in r30644. Review URL: http://codereview.chromium.org/350011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30724 0039d316-1c4b-4281-b951-d872f2087c98
-
pkasting@chromium.org authored
BUG=23400 TEST=none Review URL: http://codereview.chromium.org/350012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30723 0039d316-1c4b-4281-b951-d872f2087c98
-
creis@chromium.org authored
Needed to clear RenderWidgetHost::in_flight_size_ if the renderer crashed. BUG=25097 TEST=RenderWidgetHostTest.ResizeThenCrash Review URL: http://codereview.chromium.org/348025 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30722 0039d316-1c4b-4281-b951-d872f2087c98
-
willchan@chromium.org authored
Review URL: http://codereview.chromium.org/344045 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@30721 0039d316-1c4b-4281-b951-d872f2087c98
-