Skip to content
Snippets Groups Projects
Commit fca80a4d authored by Andrej Shadura's avatar Andrej Shadura Committed by Sjoerd Simons
Browse files

Allow new SSO logins in "deny" mode


The can_register check is actually only suitable for preventing new
unverified registrations; in SSO mode, we normally trust the SSO
provider have performed the checks and only gives us users we’re
supposed to let in.

Ideally, this should be a separate set of settings to allow e.g.
optionally requiring confirmation on SSO logins or to configure
different levels of trust per SSO provider.

Signed-off-by: Andrej Shadura's avatarAndrej Shadura <andrew.shadura@collabora.co.uk>
parent c743b6a3
No related branches found
No related tags found
1 merge request!19Allow new SSO logins in "deny" mode
Pipeline #39772 passed
...@@ -3,7 +3,6 @@ ...@@ -3,7 +3,6 @@
.card .card
.card-body#loginform .card-body#loginform
.col-lg-6.pl-0 .col-lg-6.pl-0
- if can_register
%h3= @pagetitle %h3= @pagetitle
%p Since this is your first time you sign in, you need to choose your username. %p Since this is your first time you sign in, you need to choose your username.
= form_tag({ controller: 'session', action: 'sso_confirm', method: :post }, class: 'sign-up', autocomplete: 'off') do = form_tag({ controller: 'session', action: 'sso_confirm', method: :post }, class: 'sign-up', autocomplete: 'off') do
...@@ -12,6 +11,4 @@ ...@@ -12,6 +11,4 @@
%abbr.text-danger{ title: 'required' } * %abbr.text-danger{ title: 'required' } *
= text_field_tag 'login', @derived_username, placeholder: 'Username', autocomplete: 'off', class: 'form-control', required: true = text_field_tag 'login', @derived_username, placeholder: 'Username', autocomplete: 'off', class: 'form-control', required: true
= submit_tag('Confirm and Log In', class: 'btn btn-primary') = submit_tag('Confirm and Log In', class: 'btn btn-primary')
- else
%p Sorry, only existing users can sign in.
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment