Repeat SSO user lookup by emails in username/nickname fields (!42) · Merge requests · obs / open-build-service · GitLab

Snippets Groups Projects

Merged Andrej Shadura requested to merge azure-compat into collabora/staging 2 years ago

1 unresolved thread

When logging in with e.g. OpenID Connect/Azure, two email addresses may be provided, one in "email" field and another in "username" or "nickname". Since this is exactly the opposite of what the separate Azure backend does, migration from Azure to OpenID Connect/Azure needs to try both emails which may be different.

Activity

Sjoerd Simons added 17 commits 2 years ago
added 17 commits

f42313c8...c201aa35 - 16 commits from branch collabora/staging

fbe02409 - Repeat SSO user lookup by emails in username/nickname fields

Compare with previous version
Sjoerd Simons @sjoerd started a thread on the diff 2 years ago

src/api/app/models/user.rb

         return user
       end
       username = auth['username'] || auth['nickname']
       if username.include? '@'
         user = find_by_email(username)
         if user
           user.mark_login!
           return user
         end
       end

Sjoerd Simons merged 2 years ago

merged

Please register or sign in to reply