Make publisher capture errors from hooks

We want the publisher to capture stdout+stderr output from failing publisher hooks.

This implementation requires the hook to always return an error code (non-zero) for the output to be captured. Both stdout and stderr are captured.

This MR also included changes from !77 (merged).

https://phabricator.collabora.com/T55858

changed the description

assigned to @em

requested review from @em

unassigned @em

This implementation is a bit limited: it requires the hook to always return an error code (non-zero), and doesn’t capture stdout.

I assume "always" means "iff there's an error return an error code, otherwise 0 to report success", right? In that case it does not seem to be a limitation, but a pretty sensible assumption.

As for stdout, does it still get printed on stdout or somewhere else?

Again, as long as it does not go into the void, it seems to be a sensible thing to do.

And it is then up for the publisher to print useful/clear error messages and use an appropriate return code.

added 4 commits

• 1df55dae - [backend] XML::Structured: fix pure perl encoding of '[' and ']'
• 71d2880b - backend: Do not strip out newlines when generating XML
• bb044db8 - bs_publish: Preserve error output when calling hooks
• 0c031472 - backend: Don't install XML::Structured from Debian

Compare with previous version

added 4 commits

• 1ac37837 - [backend] XML::Structured: fix pure perl encoding of '[' and ']'
• 07d7ad67 - backend: Do not strip out newlines when generating XML
• 43dff20a - bs_publish: Preserve error output when calling hooks
• b6d087cc - backend: Don't install XML::Structured from Debian

Compare with previous version

added 4 commits

• e5e02665 - [backend] XML::Structured: fix pure perl encoding of '[' and ']'
• 38483517 - backend: Do not strip out newlines when generating XML
• 88cdc89e - bs_publish: Preserve error output when calling hooks
• b26acc4b - backend: Don't install XML::Structured from Debian

Compare with previous version

added 5 commits

• f1e38dda - bs_publish: Store the complete error output in the repo state
• ab863e58 - [backend] XML::Structured: fix pure perl encoding of '[' and ']'
• 843a928d - backend: Do not strip out newlines when generating XML
• c2b0872e - bs_publish: Preserve error output when calling hooks
• 05d057e9 - backend: Don't install XML::Structured from Debian

Compare with previous version

added 1 commit

• f6a2c075 - backend: Add libcapture-tiny-perl to Dockerfile

Compare with previous version

added 6 commits

• 76994288 - bs_publish: Store the complete error output in the repo state
• ecc4dd45 - [backend] XML::Structured: fix pure perl encoding of '[' and ']'
• 1905e813 - backend: Do not strip out newlines when generating XML
• 8b4528b1 - bs_publish: Preserve error output when calling hooks
• dfe48e14 - backend: Add libcapture-tiny-perl to Dockerfile
• 53e3d237 - backend: Don't install XML::Structured from Debian

Compare with previous version

resolved all threads

changed the description

added 2 commits

• 10d5918e - frontend: Indicate clearly when publishing has failed
• 6cc0b800 - Add uninteresting files to .gitignore and .dockerignore

Compare with previous version

resolved all threads

resolved all threads

approved this merge request