• Fabrice Bellet's avatar
    agent: make candidate username and password immutable · 5a644f45
    Fabrice Bellet authored
    With this patch we prevent the username and the password of a candidate
    to be modified during a session, as required by the RFC, sect 9.1.2.
    This is also needed from a memory management point of view, because the
    password string pointer may be recorded in the components stun agent
    sent_ids[] struct key member, and freeing these values there may cause
    an use-after-free condition, when an inbound stun is received from this
    candidate. This behavior has been observed with pidgin, xmpp, and
    farstream when a same remote candidates are "updated" several times,
    even if the credentials don't change in this case.
    Reviewed-by: Olivier Crête's avatarOlivier Crête <olivier.crete@collabora.com>
    Differential Revision: https://phabricator.freedesktop.org/D1917
    5a644f45
Name
Last commit
Last update
..
Makefile.am Loading commit data...
address.c Loading commit data...
address.h Loading commit data...
agent-priv.h Loading commit data...
agent.c Loading commit data...
agent.h Loading commit data...
candidate.c Loading commit data...
candidate.h Loading commit data...
component.c Loading commit data...
component.h Loading commit data...
conncheck.c Loading commit data...
conncheck.h Loading commit data...
debug.c Loading commit data...
debug.h Loading commit data...
discovery.c Loading commit data...
discovery.h Loading commit data...
inputstream.c Loading commit data...
inputstream.h Loading commit data...
interfaces.c Loading commit data...
interfaces.h Loading commit data...
iostream.c Loading commit data...
iostream.h Loading commit data...
outputstream.c Loading commit data...
outputstream.h Loading commit data...
pseudotcp.c Loading commit data...
pseudotcp.h Loading commit data...
stream.c Loading commit data...
stream.h Loading commit data...