Skip to content
  • Jens Axboe's avatar
    io_uring: don't use iov_iter_advance() for fixed buffers · bd11b3a3
    Jens Axboe authored
    
    
    Hrvoje reports that when a large fixed buffer is registered and IO is
    being done to the latter pages of said buffer, the IO submission time
    is much worse:
    
    reading to the start of the buffer: 11238 ns
    reading to the end of the buffer:   1039879 ns
    
    In fact, it's worse by two orders of magnitude. The reason for that is
    how io_uring figures out how to setup the iov_iter. We point the iter
    at the first bvec, and then use iov_iter_advance() to fast-forward to
    the offset within that buffer we need.
    
    However, that is abysmally slow, as it entails iterating the bvecs
    that we setup as part of buffer registration. There's really no need
    to use this generic helper, as we know it's a BVEC type iterator, and
    we also know that each bvec is PAGE_SIZE in size, apart from possibly
    the first and last. Hence we can just use a shift on the offset to
    find the right index, and then adjust the iov_iter appropriately.
    After this fix, the timings are:
    
    reading to the start of the buffer: 10135 ns
    reading to the end of the buffer:   1377 ns
    
    Or about an 755x improvement for the tail page.
    
    Reported-by: default avatarHrvoje Zeba <zeba.hrvoje@gmail.com>
    Tested-by: default avatarHrvoje Zeba <zeba.hrvoje@gmail.com>
    Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
    bd11b3a3