Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P phabricator
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Merge requests 1
    • Merge requests 1
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Commits
Collapse sidebar
  • Phabricator
  • phabricator
  • Merge requests
  • !8

CCU: Ignore restricted child tasks for progress bar

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Daniel Stone requested to merge fix-progress-vs-restricted-tasks into deploy/production May 21, 2020
  • Overview 1
  • Commits 1
  • Changes 1

If we have a child task which we can't access, ManiphestTaskQuery will raise an exception; trying to view the workboard, this will bubble up as a policy exception which will (incorrectly) tell the viewer they can't access the project.

Catch any exceptions whilst trying to calculate overall progress, and ignore those restricted child tasks.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-progress-vs-restricted-tasks