Skip to content
Snippets Groups Projects
  1. May 18, 2015
  2. May 16, 2015
  3. May 15, 2015
  4. May 12, 2015
  5. May 11, 2015
  6. May 08, 2015
  7. May 07, 2015
  8. May 05, 2015
  9. May 02, 2015
  10. May 01, 2015
  11. Apr 30, 2015
    • Pekka Paalanen's avatar
      compositor: change weston_surface::destroy_signal argument · ca79076b
      Pekka Paalanen authored
      
      Pass 'this' weston_surface as the data argument to
      weston_surface::destroy_signal listeners. The old &surface->resource was
      really just an offsetted pointer to the weston_surface anyway. And,
      because 'resource' happened to be the first member in struct weston_surface,
      it was actually 'this' weston_surface.
      
      The argument type was accidentally changed in commit
      26ed73ce from wl_resource* to
      wl_resource**.
      
      Signed-off-by: Pekka Paalanen's avatarPekka Paalanen <pekka.paalanen@collabora.co.uk>
      ca79076b
    • Pekka Paalanen's avatar
      compositor: inert wl_surface objects do not exist · 08d3fb76
      Pekka Paalanen authored
      
      There is no valid case, where you would actually destroy a
      weston_surface, while leaving the wl_surface protocol object in
      existence. Therefore, inert wl_surface objects do not exist, except
      because of bugs.
      
      To catch such bugs, check that the resource is really NULL before
      actually destroying the weston_surface.
      
      We actually used to have this check, but it was removed by:
      
      	commit 9dadfb53
      	Author: Kristian Høgsberg <krh@bitplanet.net>
      	Date:   Mon Jul 8 13:49:36 2013 -0400
      
      	    compositor: Eliminate marshalling warning for leave events
      
      However, the invariant was put back in:
      
      	commit 0d379744
      	Author: Giulio Camuffo <giuliocamuffo@gmail.com>
      	Date:   Fri Nov 15 22:06:15 2013 +0100
      
      	    compositor: set weston_surface:resource to NULL when destroyed
      
      So apparently the issue fixed by 9dadfb53 was fixed another way later.
      
      Signed-off-by: Pekka Paalanen's avatarPekka Paalanen <pekka.paalanen@collabora.co.uk>
      08d3fb76
  12. Apr 28, 2015
Loading