Skip to content
  • James Hogan's avatar
    MIPS: CM: Drop WARN_ON(vp != 0) · c04de7b1
    James Hogan authored
    Since commit 68923cdc ("MIPS: CM: Add cluster & block args to
    mips_cm_lock_other()"), mips_smp_send_ipi_mask() has used
    mips_cm_lock_other_cpu() with each CPU number, rather than
    mips_cm_lock_other() with the first VPE in each core. Prior to r6,
    multicore multithreaded systems such as dual-core dual-thread
    interAptivs with CPU Idle enabled (e.g. MIPS Creator Ci40) results in
    mips_cm_lock_other() repeatedly hitting WARN_ON(vp != 0).
    
    There doesn't appear to be anything fundamentally wrong about passing a
    non-zero VP/VPE number, even if it is a core's region that is locked
    into the other region before r6, so remove that particular WARN_ON().
    
    Fixes: 68923cdc
    
     ("MIPS: CM: Add cluster & block args to mips_cm_lock_other()")
    Signed-off-by: default avatarJames Hogan <jhogan@kernel.org>
    Reviewed-by: default avatarPaul Burton <paul.burton@mips.com>
    Cc: linux-mips@linux-mips.org
    Cc: stable@vger.kernel.org # 4.14+
    Patchwork: https://patchwork.linux-mips.org/patch/17883/
    
    
    Signed-off-by: default avatarRalf Baechle <ralf@linux-mips.org>
    c04de7b1