Skip to content
  • Vladimir Oltean's avatar
    cmd: mdio: Fix access to arbitrary PHY addresses · b4c20f20
    Vladimir Oltean authored
    Alex reported the following:
    
      "
      I'm doing some MDIO work on a freescale/NXP platform and I bumped into
      errors with this command:
      => mdio r emdio#3 5 3
      Reading from bus emdio#3
      "Synchronous Abort" handler, esr 0x8600000e
      elr: ffffffff862b8000 lr : 000000008200cce4 (reloc)
      ...
    
      mdio list does not list any PHYs currently because ethernet is using DM
      and the interfaces are not probed at this time.  The PHY does exist
      on the bus though.
      The above scenario works with this commit reverted:
      e55047ec cmd: mdio: Switch to generic
      helpers when accessing the registers
    
      The current code using generic helpers only works for PHYs that have
      been registered and show up in bus->phymap and crashes for arbitrary
      IDs.  I find it useful to allow reading from other addresses over MDIO
      too, certainly helpful for people debugging MDIO on various boards.
      "
    
    Fix this by reverting to use the raw MDIO bus operations in case there
    is no PHY probed based on DT at the specified address.
    
    This restores the old behavior for these PHYs, which means that the
    newly introduced MMD-over-C22 helpers won't be available for them, but
    at least they will be accessible again without crashing the system.
    
    Fixes: commit e55047ec
    
     ("cmd: mdio: Switch to generic helpers when accessing the registers")
    Reported-by: default avatarAlex Marginean <alexm.osslist@gmail.com>
    Signed-off-by: default avatarVladimir Oltean <olteanv@gmail.com>
    Reviewed-by: default avatarAlex Marginean <alexm.osslist@gmail.com>
    Acked-by: default avatarJoe Hershberger <joe.hershberger@ni.com>
    b4c20f20