Skip to content
  • Colin Walters's avatar
    dbus-common: Add helper method to handle no-reply messages · 1a37b9b9
    Colin Walters authored
    [Tested in latest gnome-ostree; if accepted, I'll look at a followup
     patch which fixes the other dbus_connection_send(reply, ...) calls
     besides logind]
    
    DBus messages can have a flag NO_REPLY associated that means "I don't
    need a reply".  This is for efficiency reasons - for one-off requests
    that can't return an error, etc.
    
    However, it's up to users to manually check
    dbus_message_get_no_reply() from a message.  libdbus will happily send
    out a reply if you don't.
    
    Unfortunately, doing so is not just less efficient - it also triggers
    a security error, for complex reasons.  This is something that will
    eventually be fixed in dbus, but it's also correct to handle it in
    client applications.
    
    This new helper API is slightly nicer in that you don't have to pass
    NULL to say you don't want a reply serial for your reply.
    
    This patch also tweaks logind to use the API - there are more areas of
    the code that need this treatment too.
    1a37b9b9