Skip to content
  • Harald Hoyer's avatar
    Add ugly CMP_F_TYPE() macro · fc6e6d24
    Harald Hoyer authored
    On some architectures (like s390x) the kernel has the type int for
    f_type, but long in userspace.
    Assigning the 32 bit magic constants from linux/magic.h to the 31 bit
    signed f_type in the kernel, causes f_type to be negative for some
    constants.
    glibc extends the int to long for those architecures in 64 bit mode, so
    the negative int becomes a negative long, which cannot be simply
    compared to the original magic constant, because the compiler would
    automatically cast the constant to long.
    To workaround this issue, we also compare to the (int)MAGIC value in a
    macro. Of course, we could do #ifdef with the architecure, but it has to
    be maintained, and the magic constants are 32 bit anyway.
    
    Someday, when the int is unsigned or long for all architectures, we can
    remove this macro again. Until then, keep it as simple as it can be.
    fc6e6d24