Skip to content
Snippets Groups Projects
Select Git revision
  • 9d0513d82f1a8fe17b41f113ac5922fa57dbaf5c
  • master default
  • android-container
  • nanopc-t4
  • for-kernelci
  • WIP-syscall
  • v4.16-rc5
  • v4.16-rc4
  • v4.16-rc3
  • v4.16-rc2
  • v4.16-rc1
  • v4.15
  • v4.15-rc9
  • v4.15-rc8
  • v4.15-rc7
  • v4.15-rc6
  • v4.15-rc5
  • v4.15-rc4
  • v4.15-rc3
  • v4.15-rc2
  • v4.15-rc1
  • v4.14
  • v4.14-rc8
  • v4.14-rc7
  • v4.14-rc6
  • v4.14-rc5
26 results

linux

  • Clone with SSH
  • Clone with HTTPS
  • user avatar
    Andy Shevchenko authored and Ingo Molnar committed
    So one of the constification patches unearthed a type casting fragility
    of the underlying code:
    
      276c8705 ("x86/platform/intel-mid: Make 'bt_sfi_data' const")
    
    converted the struct to be const while it is also used as a temporary
    container for important data that is used to fill 'parent' and 'name'
    fields in struct platform_device_info.
    
    The compiler doesn't notice this due to an explicit type cast that loses
    the const - which fragility will be fixed separately.
    
    This type cast turned a seemingly trivial const propagation patch into a
    hard to debug data corruptor and crasher bug.
    
    Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
    Cc: Bhumika Goyal <bhumirks@gmail.com>
    Cc: Darren Hart <dvhart@infradead.org>
    Cc: Linus Torvalds <torvalds@linux-foundation.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: julia.lawall@lip6.fr
    Cc: platform-driver-x86@vger.kernel.org
    Link: http://lkml.kernel.org/r/20171228122523.21802-1-andriy.shevchenko@linux.intel.com
    
    
    Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
    9d0513d8
    History
    Name Last commit Last update