Skip to content
Snippets Groups Projects
  1. Feb 01, 2020
  2. Jan 31, 2020
  3. Jan 30, 2020
    • Florian Weimer's avatar
      nptl: Avoid using PTHREAD_MUTEX_DEFAULT in macro definition [BZ #25271] · 9baa46aa
      Florian Weimer authored
      Commit 1c3f9acf ("nptl: Add struct_mutex.h")
      replaced a zero constant with the identifier PTHREAD_MUTEX_DEFAULT
      in the macro PTHREAD_MUTEX_INITIALIZER.  However, that constant
      is not available in ISO C11 mode:
      
      In file included from /usr/include/bits/thread-shared-types.h:74,
                       from /usr/include/bits/pthreadtypes.h:23,
                       from /usr/include/pthread.h:26,
                       from bug25271.c:1:
      bug25271.c:3:21: error: ‘PTHREAD_MUTEX_DEFAULT’ undeclared here (not in a function)
          3 | pthread_mutex_t m = PTHREAD_MUTEX_INITIALIZER;
            |                     ^~~~~~~~~~~~~~~~~~~~~~~~~
      
      This commit change the constant to the equivalent
      PTHREAD_MUTEX_TIMED_NP, which is in the POSIX extension namespace
      and thus always available.
      9baa46aa
  4. Jan 24, 2020
    • Joseph Myers's avatar
      Build raise with -fasynchronous-unwind-tables. · 352bb997
      Joseph Myers authored
      In testing glibc for Arm and MIPS, I see:
      
      FAIL: misc/tst-sigcontext-get_pc
      
      If this test - backtracing through a call to raise - is valid, then
      raise needs to be built with -fasynchronous-unwind-tables (as the test
      itself is) to have the required unwind information for that
      backtracing to work.  Adding that option, which this patch does,
      causes the test for pass for Arm.  For MIPS, the test still does not
      pass (the backtrace has an address that is 2 bytes after the "address
      in signal handler", for unknown reasons), although the patch allows a
      longer backtrace to be produced.
      352bb997
    • Joseph Myers's avatar
      Fix locale/tst-locale-locpath cross-testing when sshd sets LANG. · ef02e3c4
      Joseph Myers authored
      The locale/tst-locale-locpath test unsets LANG, then runs a test with
      test_wrapper_env and expects LANG to remain unset for that test.  This
      does not work for cross-testing with cross-test-ssh.sh when sshd (on
      the system specified as an argument to cross-test-ssh.sh) is
      configured to have a default LANG setting.
      
      The general design used in cross testing, after commit
      8540f6d2 ("Don't require test wrappers
      to preserve environment variables, use more consistent environment.",
      6 June 2014), is that environment settings required by tests should be
      passed explicitly to $(test-wrapper-env).  This patch changes
      tst-locale-locpath.sh to pass an explicit LANG= rather than expecting
      "unset LANG" to be in effect for the program run under
      test_wrapper_env.  Note that this does slightly change the environment
      in which the test is run natively (empty LANG instead of unset LANG)
      but that difference does not appear relevant to what it is trying to
      test.
      
      Tested for Arm that this fixes the failure seen for that test in
      cross-testing.
      ef02e3c4
    • Joseph Myers's avatar
      Fix elf/tst-rtld-preload cross-testing. · d01fd5f0
      Joseph Myers authored
      As noted in
      <https://sourceware.org/ml/libc-alpha/2019-06/msg00824.html>,
      elf/tst-rtld-preload fails when cross-testing because it attempts to
      run the test wrapper with itself.  Unfortunately, that thread never
      resulted in a complete and correct patch for that test.
      
      This patch addresses the issues with that test more thoroughly.  The
      test is changed not to use the wrapper twice, including updating the
      message it prints about the command it runs to be more complete and
      accurate after the change; the Makefile is changed not to pass the
      redundant '$(test-wrapper)' argument.
      
      Tested for Arm that this fixes the failure seen for that test in
      cross-testing.
      d01fd5f0
  5. Jan 23, 2020
    • Joseph Myers's avatar
      Fix cross-testing of tst-ifunc-fault-* tests. · 00167b53
      Joseph Myers authored
      The tests elf/tst-ifunc-fault-bindnow and elf/tst-ifunc-fault-lazy
      fail in cross-testing because they run the dynamic linker directly
      without using the test wrapper.  This patch fixes them to use the test
      wrapper instead.
      
      Tested that this fixes the failure of those two tests for powerpc
      soft-float.
      00167b53
    • Siddhesh Poyarekar's avatar
      gitlog-to-changelog: Drop scripts in favour of gnulib version · de077de1
      Siddhesh Poyarekar authored
      The ChangeLog automation scripts were incorporated in gnulib as
      vcs-to-changelog for a while now since other projects expressed the
      desire to use and extend this script.  In the interest of avoiding
      duplication of code, drop the glibc version of gitlog-to-changelog and
      use the gnulib one directly.
      
      The only file that remains is vcstocl_quirks.py, which specifies
      properties and quirks of the glibc project source code.  This patch
      also drops the shebang at the start of vcstocl_quirks.py since the
      file is not intended to be directly executable.
      de077de1
    • Dragan Mladjenovic's avatar
      Add NEWS entry about the change in handling of PT_GNU_STACK on MIPS · ba44e5b5
      Dragan Mladjenovic authored
      
      The change was introduced in:
      
      commit 33bc9efd
      Author: Dragan Mladjenovic <dmladjenovic@wavecomp.com>
      Date:   Fri Aug 23 16:38:04 2019 +0000
      
          mips: Force RWX stack for hard-float builds that can run on pre-4.8 kernels
      
      and probably requires a small explanation.
      
      Co-authored-by: default avatarSiddhesh Poyarekar <siddhesh@sourceware.org>
      ba44e5b5
  6. Jan 21, 2020
  7. Jan 20, 2020
  8. Jan 19, 2020
    • Siddhesh Poyarekar's avatar
      translations: Update translations · 3cb57302
      Siddhesh Poyarekar authored
      Update translations after adding msgattrib to the update-translations
      makefile target.
      3cb57302
    • Siddhesh Poyarekar's avatar
      translations: Trim po files using msgattrib · afbfe2d9
      Siddhesh Poyarekar authored
      The translation project coordinator Benno Schulenberg suggested that
      we could save space in our tarball by trimming the generated po files
      by using msgattrib and dropping all untranslated, fuzzy and obsolete
      messages.  This patch updates the update-translations target to do
      that.  Testing indicates that the current po files reduce by over 65K
      lines due to this trimming.
      afbfe2d9
    • Siddhesh Poyarekar's avatar
      Update translations · 35869b85
      Siddhesh Poyarekar authored
      Update translations from the translation project.
      35869b85
    • Siddhesh Poyarekar's avatar
      translations: Run msgmerge when downloading translations · 63675a92
      Siddhesh Poyarekar authored
      The latest translations in the translationproject URL need to be
      merged in using msgmerge for the po files to be correctly updated,
      otherwise we may end up getting odd results, such as the previous
      translations update.  This patch adds another step to the
      update-translations Makefile target which does a msgmerge of the
      downloaded po file with libc.pot and then uses that as the final
      result.
      63675a92
  9. Jan 18, 2020
    • Matheus Castanho's avatar
      Fix maybe-uninitialized error on powerpc · 9f8b135f
      Matheus Castanho authored
      
      The build has been failing on powerpc64le-linux-gnu with GCC 10
      due to a maybe-uninitialized error:
      
      ../sysdeps/ieee754/dbl-64/mpa.c:875:6: error: ‘w.e’ may be used
      uninitialized in this function [-Werror=maybe-uninitialized]
        875 |   EY -= EX;
            |      ^~
      
      The warning is thrown because when __inv is called by __dvd *y is not
      initialized and if t == 0 before calling __dbl_mp, EY will stay
      uninitialized, as the function does not touch it in this case.
      
      However, since t will be set to 1/t before calling __dbl_mp, t == 0 will
      never happen, so we can instruct the compiler to ignore this case, which
      suppresses the warning.
      
      Tested on powerpc64le.
      
      Reviewed-by: default avatarTulio Magno Quites Machado Filho <tuliom@linux.ibm.com>
      9f8b135f
  10. Jan 17, 2020
  11. Jan 16, 2020
  12. Jan 13, 2020
Loading