Skip to content
  • Simon Marchi's avatar
    Make mapped_debug_names and mapped_index final · fc898b42
    Simon Marchi authored
    When compiling with Clang 6, I see these warnings:
    
    /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:25421:5: error: destructor called on non-final 'mapped_index' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
        data->index_table->~mapped_index ();
        ^
    In file included from /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:31:
    In file included from /home/emaisin/src/binutils-gdb/gdb/defs.h:28:
    In file included from /home/emaisin/src/binutils-gdb/gdb/common/common-defs.h:92:
    In file included from /home/emaisin/src/binutils-gdb/gdb/common/gdb_unique_ptr.h:23:
    In file included from /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/memory:81:
    /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:76:2: error: delete called on non-final 'mapped_debug_names' that has virtual functions but non-virtual destructor [-Werror,-Wdelete-non-virtual-dtor]
            delete __ptr;
            ^
    /usr/bin/../lib/gcc/x86_64-linux-gnu/5.4.0/../../../../include/c++/5.4.0/bits/unique_ptr.h:236:4: note: in instantiation of member function 'std::default_delete<mapped_debug_names>::operator()' requested here
              get_deleter()(__ptr);
              ^
    /home/emaisin/src/binutils-gdb/gdb/dwarf2read.c:2374:21: note: in instantiation of member function 'std::unique_ptr<mapped_debug_names, std::default_delete<mapped_debug_names> >::~unique_ptr' requested here
    dwarf2_per_objfile::dwarf2_per_objfile (struct objfile *objfile_,
                        ^
    
    This patch silences these warnings by making the classes final.
    
    gdb/ChangeLog:
    
    	* dwarf2read.c (struct mapped_debug_names): Make final.
    	(struct mapped_index): Make final.
    fc898b42
To find the state of this project's repository at the time of any of these versions, check out the tags.