• hiroshige's avatar
    Do not call Dispose() as ClassicPendingScript's prefinalizer · faa05510
    hiroshige authored
    Because the things in ClassicPendingScript::DisposeInternal() except for
    ScriptStreamer::Cancel() doesn't have to be called as a prefinalizer,
    this CL introduces ClassicPendingScript::Prefinalize() that only calls
    ScriptStreamer::Cancel() and thus makes Dispose() not to be called there.
    This CL simplified the prefinalization of ClassicPendingScript, especially
    order dependencies between ClassicPendingScript's prefinalizer and the
    prefinalizer of its parent class (ResourceOwner).
    Leaving ClassicPendingScript in a not-Dispose()d state is not observable
    if the related classes obeys the rule of Oilpan, and
    https://codereview.chromium.org/2837413002/ checks that in case there were
    a bug.
    Review-Url: https://codereview.chromium.org/2844583002
    Cr-Commit-Position: refs/heads/master@{#467299}
ClassicPendingScript.cpp 7.97 KB