-
Darin Fisher authored
SharedWorkerServiceImpl is no longer allocated using base::Singleton. That was never necessary given that the instance is used exclusively on a single thread. The change to put it on the main thread revealed a shutdown crash related to the order of shutdown of singletons. Rather than try to make sense of that, it seems better to just let the instance leak. It serves no purpose to try to clean it up. Note, in the future, it probably makes sense to hang an instance of the service off of each StoragePartition instead. Switched unit test over to using MockRenderProcessHost, which allows for simplification of SharedWorkerServiceImpl. It no longer needs extra layers of indirection to support unit testing. Bug: 612308 Change-Id: Iac67e9d22e7942769bf29ce76b199ac9da3295ac Reviewed-on: https://chromium-review.googlesource.com/674744 Reviewed-by: Brett Wilson <brettw@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Darin Fisher <darin@chromium.org> Cr-Commit-Position: refs/heads/master@{#507251}
d3768b2f