-
Timothy Loh authored
This patch fixes a crash that can occur if a tab is closed while the Location Settings Dialog is open (it's modal but doesn't block JS). The GeolocationServiceImpl correctly cancels permission requests upon upon destruction so it should be able to use an Unretained callback into itself for permission requests, but we end up binding this to the LSD completion callback and not clearing it upon cancels. Bug: 754376 Change-Id: I81bcdf2fb0c71821b1cfa83fdf1caff1449f360b Reviewed-on: https://chromium-review.googlesource.com/644592 Reviewed-by: Bernhard Bauer <bauerb@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#499597}
a7a788fa