Skip to content
  • pkasting@chromium.org's avatar
    Misc. cleanup found while mucking with search engines code: · 4ab952fe
    pkasting@chromium.org authored
    * Don't handle DCHECK failure
    * Remove NOTREACHED()/LOG(ERROR) from cases that look like they could
      legitimately happen
    * All lines of args should begin at the same position
    * WebDataService::SetDefaultSearchProvider() doesn't actually need a full
      TemplateURL, just an ID
    * Use GetCachedStatement correctly, and in more places
    * Make KeywordTableTest a friend of KeywordTable to reduce FRIEND_TEST
      declarations and in preparation for making Add/Update/RemoveKeyword private
    * Data members should be private, not protected
    * Function declarations: all args on first line or one arg per line
    * Fix misspelling
    
    BUG=none
    TEST=none
    R=shess@chromium.org
    
    Review URL: https://codereview.chromium.org/217613002
    
    git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260933 0039d316-1c4b-4281-b951-d872f2087c98
    4ab952fe