-
Bruce Dawson authored
This reverts commit 70155edf. Reason for revert: the 15.4 toolchain breaks incremental linking for Chrome (crbug.com/780161) Original change's description: > VS 2017 15.4 with 10.0.15063.468 SDK > > This change switches the VS 2017 package to use VS 2017 Update 4 while > still using the 10.0.15063.468 SDK. Update 4 fixes at least one code-gen > bug (crbug.com/759402) but the 10.0.16299.0 SDK is still incompatible > with Chrome (crbug.com/773476). > > Packaging was done on a Windows Server 2016 VM, cleanly created for this > purpose. > > Compiler was packaged up by downloading VS 2017 Update 4, from > https://www.visualstudio.com/vs/, and then passing these parameters to > the installer: > > --add Microsoft.VisualStudio.Workload.NativeDesktop > --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended > --passive > > Then the Windows 10.0.15063.468 SDK installer was run and everything was > installed except for the Windows Performance Toolkit, .Net Framework, > and the arm SDKs. > > Then the packaging script was run like this: > > python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0 > > Bug: 773476,759402 > Change-Id: Ie2176b5ff765d9e5497f51a7b00c02fad04fb973 > Reviewed-on: https://chromium-review.googlesource.com/727523 > Reviewed-by: Scott Graham <scottmg@chromium.org> > Commit-Queue: Bruce Dawson <brucedawson@chromium.org> > Cr-Commit-Position: refs/heads/master@{#510207} TBR=thakis@chromium.org,brucedawson@chromium.org,scottmg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 773476, 759402 Change-Id: Ica63e9740c954499b85ee891fb3bec0d48dd70fb Reviewed-on: https://chromium-review.googlesource.com/753422 Reviewed-by: Bruce Dawson <brucedawson@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#513965}
db456063