- Nov 08, 2024
-
-
Koji Ishii authored
This patch makes it possible to call `DumpLayoutObject` for destroyed objects. This is a generalization of crrev.com/c/5968499. This is a DCHECK-only change. Change-Id: I85e83736645062e9dda5f1828e1579f8f27c6bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000250 Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380297}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/00d01548c958..57a8f74b264a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll Please CC chrome-brapp-engprod@google.com,gambard@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Change-Id: I14f050be2ba706606d88458c9eae0985e216258e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004586 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1380296}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 351564777 Change-Id: Ife441f413f80d5e53067a187304f05193efd467f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000416 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/main@{#1380295}
-
Norge Vizcay authored
Bug: 355132717 Change-Id: I2cbea8dacda9fd50a8a7629b79f337c3f3b22c89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000345 Reviewed-by:
Jan Keitel <jkeitel@google.com> Commit-Queue: Norge Vizcay <vizcay@google.com> Cr-Commit-Position: refs/heads/main@{#1380294}
-
Florian Leimgruber authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/5999997/comment/8587bcbb_e7fddd0a/ Bug: 40100455 Change-Id: I5eb6e6af35465d8c56df48c4abb46a25a5f30509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999785 Reviewed-by:
Christoph Schwering <schwering@google.com> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Commit-Queue: Florian Leimgruber <fleimgruber@google.com> Cr-Commit-Position: refs/heads/main@{#1380293}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/ff9e7cb18241..c772fc227bbc 2024-11-08 danilchap@webrtc.org Deprecate AudioProcessingBuilder in favor of the BuiltinAudioProcessingBuilder 2024-11-08 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2024-11-08T04:06:14). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com,webrtc-infra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in WebRTC: https://bugs.chromium.org/p/webrtc/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic8235febaec3d7b60346ecdf251844731b54e320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004536 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1380292}
-
Olga Sharonova authored
To observe audio prefetch Bug: 0 Change-Id: I595f84cb970470b26cfe5e4978e97115215d48e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000344 Auto-Submit: Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Fredrik Hernqvist <fhernqvist@google.com> Commit-Queue: Fredrik Hernqvist <fhernqvist@google.com> Cr-Commit-Position: refs/heads/main@{#1380291}
-
Gauthier Ambard authored
The test is very flaky on the fieldtrial bot. Bug: 378058907 Change-Id: Ic975e4b4f15bcbba1eca4740dcc00c9860cafc9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999502 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380290}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0f623183f7df..42769e83e649 2024-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll vulkan-deps from 7363ad68f4c9 to 12e843b4aad1 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com,skiabot@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Skia: https://bugs.chromium.org/p/skia/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:gpu-fyi-cq-android-arm64;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: kjlubick@google.com Change-Id: Ia155a5618a54f19b6e1b74103eac2c0b3b730aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004581 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1380289}
-
David Stevens authored
Change-Id: I48299d8f8a18747caff0e8763326aaa8668614be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999018 Reviewed-by:
Alexandre Marciano Gimenez <raging@google.com> Commit-Queue: David Stevens <stevensd@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380288}
-
Fabian Sommer authored
The old NativeClientForceAllowed policy does not work for ChromeOS - we need the policy value early during startup, and user policies are not loaded for some scenarios (login screen, managed guest session). Instead, implement a new device policy that takes the place of the old user policy, while deprecating the old policy. Since the value needs to be present very early in startup, generally before device policies are loaded, add a second pref that is used to cache the last known value of the policy. During startup, use this cached value to potentially re-enable NaCl. This means that Chrome needs to be restarted once for the policy to be applied correctly. Fixed: 374790919 Change-Id: I6cb3d904d1627d18233c7f3e73374ad7c84fbaf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5988133 Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380287}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/devtools/devtools-internal.git/+log/25d42e7a776a..381c42247266 Also rolling transitive DEPS: https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/96f3a7092688b5802ba644c32c0900f62f57cade..98d493a5b9e52c39d8769f6cd49808b378bb7720 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/devtools-internal-chromium Please CC devtools-waterfall-sheriff-onduty@rotations.google.com,liviurau@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: devtools-waterfall-sheriff-onduty@rotations.google.com Change-Id: I5c5a7d24b3481c0dfdadbdf44958e5d0c927e205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004690 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1380286}
-
Peter Boström authored
NOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now. The former is [[noreturn]] so this CL also performs dead-code removal after the NOTREACHED(). This CL does not attempt to do additional rewrites of any surrounding code, like: if (!foo) { NOTREACHED(); } to CHECK(foo); Those transforms take a non-trivial amount of time (and there are thousands of instances). Cleanup can be left as an exercise for the reader. Bug: 40580068 Change-Id: I2393b200e3e51c7f8d67b1c30bdb7c91f150a80a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998915 Commit-Queue: Kartar Singh <kartarsingh@google.com> Reviewed-by:
Kartar Singh <kartarsingh@google.com> Auto-Submit: Peter Boström <pbos@chromium.org> Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1380285}
-
Norge Vizcay authored
Bug: 355132717 Change-Id: Idc35ead5f3219036cf872a3552377b81909d0b17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004748 Reviewed-by:
Jan Keitel <jkeitel@google.com> Commit-Queue: Norge Vizcay <vizcay@google.com> Cr-Commit-Position: refs/heads/main@{#1380284}
-
Norge Vizcay authored
The CL records two new user actions: one for when the user is initially presented with the option to create a plus address, and another for when they see the option again after having already accepted the notice. Bug: 355132717 Change-Id: I6ab02091f9e9712ebf886fb66fa22bf337b69fe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000363 Reviewed-by:
Jan Keitel <jkeitel@google.com> Commit-Queue: Norge Vizcay <vizcay@google.com> Cr-Commit-Position: refs/heads/main@{#1380283}
-
Steinar H. Gunderson authored
Change-Id: Ide8098f44647bcb4479bccc30cb65a58bd53f987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998678 Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Shunya Shishido <sisidovski@chromium.org> Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380282}
-
Josh Hilke authored
This is a reland of commit 8b891cac Fixed build error by updating deps in chrome/browser/ash/policy/core/BUILD.gn Original change's description: > Create user session activity reporter. > > This class and its delegate observes and reports active/idle states within a user session using the encrypted reporting pipeline and an idle event notifier. This change is guarded by the EnableUserSessionActivityReporting feature which is disabled by default. > > Browser test will be added in a following change. > > BYPASS_LARGE_CHANGE_WARNING=The majority of added code is guarded by a feature flag which is disabled by default. > > Change-Id: Ib68b883c9107f94bb2692d4d2cb8520ed6876f66 > Bug: b:372757109 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5924246 > Reviewed-by:
Sergey Poromov <poromov@chromium.org> > Reviewed-by:
Xinglong (Alan) Luan <alanlxl@chromium.org> > Commit-Queue: Josh Hilke <jrhilke@google.com> > Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1378766} Bug: b:372757109 Change-Id: I7013db3683fefdcdb1063a979b6378a7e7764640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6002488 Reviewed-by:
Leonid Baraz <lbaraz@chromium.org> Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Xinglong (Alan) Luan <alanlxl@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380281}
-
Quentin Pubert authored
This CL keeps disabled items editable in multifile mode so that their content remains aligned with enabled cells and improve readability. Before: https://screenshot.googleplex.com/ASqLXhJqdUowbcn After: https://screenshot.googleplex.com/7UiZxgVmnAN667t Bug: 378043188 Change-Id: I1be759149c9482f0dfcdbbc60015ccb823b4f143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6001969 Auto-Submit: Quentin Pubert <qpubert@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Quentin Pubert <qpubert@google.com> Cr-Commit-Position: refs/heads/main@{#1380280}
-
Sylvain Defresne authored
This is a reland of commit f17d9a31 The CL was reverted because it failed `gn check` when the CPE is disabled (i.e. ios_enable_credential_provider_extension=false) which is only the case when building for macOS catalyst. Fix the `gn check` failure by adding `// nogncheck` on the files that are included conditionally (since `gn check` does not understand the pre-processor #if directives). Original change's description: > Reland "[ios] Move part of Profile deferred init to ProfileController" > > This is a reland of commit 686edbcf > > The original CLs was reverted because it did not compiler on device > (which does not happen on CQ). This version fixes the typos in the > code that is only compiled for devices (introduced when introducing > an helper function). > > Original change's description: > > [ios] Move part of Profile deferred init to ProfileController > > > > Move some of the Profile deferred initialization from MainController > > to ProfileController. This ensure the code is run even for Profiles > > that are loaded dynamically after the MainController is initialized. > > > > Bug: 353683675, 40769058, 333863468 > > Change-Id: Ie22a5e2b68f127da6ace5715abd2ac1d8157b42a > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999921 > > Reviewed-by:
Aliona Dangla <alionadangla@chromium.org> > > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > > Cr-Commit-Position: refs/heads/main@{#1379635} > > Bug: 353683675, 40769058, 333863468 > Change-Id: I75008ce46788e94233d2402c90a2d4179d97cc89 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999324 > Reviewed-by:
Aliona Dangla <alionadangla@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1380223} Cq-Include-Trybots: luci.chromium.try:ios-catalyst Bug: 353683675, 40769058, 333863468 Change-Id: I67e6ab931dba2d3af22740d43a4c4248136a2020 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6003470 Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380279}
-
This reverts commit 5a1fe364. Reason for revert: LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/6469010959892480 Sample build with failed test: https://ci.chromium.org/b/8731909207621187153 Affected test(s): [ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.keyboard_accessory.AutofillKeyboardAccessoryIntegrationTest#testClicksThroughOtherSurfaceAreAreProcessed](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.keyboard_accessory.AutofillKeyboardAccessoryIntegrationTest%23testClicksThroughOtherSurfaceAreAreProcessed?q=VHash%3A65f54f06977427ae) [ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.keyboard_accessory.AutofillKeyboardAccessoryIntegrationTest#testClicksThroughOtherSurfaceAreIgnored](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.keyboard_accessory.AutofillKeyboardAccessoryIntegrationTest%23testClicksThroughOtherSurfaceAreIgnored?q=VHash%3A65f54f06977427ae) [ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.keyboard_accessory.AutofillKeyboardAccessoryIntegrationTest#testSwitchFieldsRescrollsKeyboardAccessory](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.keyboard_accessory.AutofillKeyboardAccessoryIntegrationTest%23testSwitchFieldsRescrollsKeyboardAccessory?q=VHash%3A65f54f06977427ae) [ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.keyboard_accessory.ManualFillingIntegrationTest#testAccessorySheetHiddenUntilManuallyTriggered](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.keyboard_accessory.ManualFillingIntegrationTest%23testAccessorySheetHiddenUntilManuallyTriggered?q=VHash%3A65f54f06977427ae) [ninja://chrome/android:chrome_public_test_apk/org.chromium.chrome.browser.keyboard_accessory.ManualFillingIntegrationTest#testAccessorySheetHiddenWhenRefocusingField](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fchrome%2Fandroid:chrome_public_test_apk%2Forg.chromium.chrome.browser.keyboard_accessory.ManualFillingIntegrationTest%23testAccessorySheetHiddenWhenRefocusingField?q=VHash%3A65f54f06977427ae) and 17 more ... If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F6469010959892480&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F5994590&type=BUG Original change's description: > Move ChromeCachedFlags update logic to be earlier in startup. > > The first access of a ChromeCachedFlag determines the state for the > session (even if the underlying server config seed is suggests a > different value). By moving the caching of the flag state earlier, this > gives a higher chance that flags that have not yet been read will use > the most up-to-date configuration state. > > Some additional findings as part of this CL: > * CachedFeatureFlags does not currently reflect the values set in fieldtrial_testing_config (existing bug: https://crbug.com/40239922) > * By moving this earlier, more tests were getting the flag values set in the fieldtrial_testing_config vs the default in the cached feature flag. This broke several tests that didn't work w/ the values in the fieldtrial_testing_config. > * If you override any value via EnableFeatures/DisableFeatures (or really via any command line means), it will skip any applicable experiment defined in the fieldtrial_testing_config (existing behavior), but I was unaware of this, so it took longer to diagnose what the issue was. > > Bug: None > Change-Id: I412bf6fa4f994c4076663ad94e0a80fb71aa0390 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5994590 > Code-Coverage: findit-for-me@appspot.gserviceaccount.com <findit-for-me@appspot.gserviceaccount.com> > Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> > Commit-Queue: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1379752} > Bug: None Change-Id: I9627974ea5fdbf90a493c4df985440c36ab135b1 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004668 Reviewed-by:
Aman Verma <amanvr@google.com> Owners-Override: Aman Verma <amanvr@google.com> Commit-Queue: Aman Verma <amanvr@google.com> Cr-Commit-Position: refs/heads/main@{#1380278}
-
Fredrik Söderquist authored
Replace the first_/last_ pointers into the entity table with a span of potentially (current prefix) matching entities. Rewrite the search functions to use indices into the current span and replace the open- coded lower/upper bound search with std::ranges::equal_range. Update the generator. Bug: 351564777 Change-Id: Ic97e61ed6c2a91df105bc3db249b3a01044c8d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5978828 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380277}
-
chromium-autoroll authored
Roll Chrome Mac Arm PGO profile from chrome-mac-arm-main-1731052676-d20c06aa745bf1bbaa635e7e53b222d199809761-7451b2e6.profdata to chrome-mac-arm-main-1731059917-751a13902a324a992213fc8702d4ed1efee7a943-9112a882.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-arm-chromium Please CC chrome-brapp-engprod@google.com,pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium main branch: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I1773af568b1913af0a723cc6d6a24f4d34a1a7d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004535 Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1380276}
-
hsuanling authored
If there are multiple language options, show the language picker for users to choose transcript language. Bug: b:357526779 Test: manually Change-Id: Ide69e206e7eb4cf0ce0fe9b94d4bebd6e4155001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6002547 Reviewed-by:
Pi-Hsun Shih <pihsun@chromium.org> Commit-Queue: Jennifer Ling <hsuanling@google.com> Cr-Commit-Position: refs/heads/main@{#1380275}
-
Christian Xu authored
Records the duration between the time a lens request was initiated and the time it was received. Bug: None Change-Id: I7da8febfccf11b8c5b6f88bfcd46f820ff9611c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999394 Commit-Queue: Christian Xu <christianxu@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Auto-Submit: Christian Xu <christianxu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380274}
-
Rubin Deliallisi authored
- Fix a bug where the lock screen would disappear if the browser was backgrounded and foregrounded again before the timeout has elapsed. Bug: 370804664 Change-Id: I45015f5b54a2c0b56705abd349848fc831527b90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000362 Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Rubin Deliallisi <rubindl@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380273}
-
Abhijith Nair authored
https://chromium.googlesource.com/aosp/platform/frameworks/support/javascriptengine/javascriptengine/src.git/+log/dd087a8dd0d1..e3b6fc680728 $ git log dd087a8dd..e3b6fc680 --date=short --no-merges --format='%ad %ae %s' 2024-02-29 android-test-infra-autosubmit Merge "Remove usage of @hide javadoc tag in javascriptengine" into androidx-main 2023-10-11 ashleynewson Merge "Rename DEFAULT_MAX_HEAP_SIZE to AUTOMATIC_MAX_HEAP_SIZE" into androidx-main 2023-10-10 aashnajena Merge "Rename FileDescriptorIoException to DataInputException for Alpha-07 release" into androidx-main 2023-10-09 ashleynewson Merge "Fix various JSE javadoc documentation bugs" into androidx-main 2023-10-09 ashleynewson Merge "Fix wording of JSE heap size limit configuration APIs" into androidx-main 2023-10-09 ashleynewson Merge "Restrict non-functional JSE console APIs" into androidx-main 2023-10-09 aashnajena Merge "Unhide FileDescriptorIoException for Alpha-07" into androidx-main 2023-10-06 ashleynewson Merge "Remove RestrictTo for JSE termination callback APIs" into androidx-main 2023-09-27 abhijithnair Merge "Remove ":DEV" suffix from flags" into androidx-main 2023-09-25 abhijithnair Merge "Improve exception handling in JavaScriptEngine" into androidx-main 2023-09-24 aashnajena Merge "Add tests for following evaluateJavaScriptAsync APIs: (1) evaluateJavaScriptAsync(AssetFileDescriptor afd) (2) evaluateJavaScriptAsync(ParcelFileDescriptor pfd)" into androidx-main Created with: roll-dep src/third_party/androidx_javascriptengine/src Bug: 377677601 Change-Id: Iad25e6bd666d2aed5bfd7173fbfb925bd32f5ca8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999984 Commit-Queue: Abhijith Nair <abhijithnair@chromium.org> Reviewed-by:
Ashley Newson <ashleynewson@chromium.org> Reviewed-by:
Richard (Torne) Coles <torne@chromium.org> Auto-Submit: Abhijith Nair <abhijithnair@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380272}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium-variations.git/+log/cdea434120aa..1c0c111c4736 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromium-variations-chromium Please CC chrome-metrics-team@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Chromium Variations: https://bugs.chromium.org/p/chromium/issues/entry To file a bug in Chromium: https://bugs.chromium.org/p/chromium/issues/entry To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: None Tbr: chrome-metrics-team@google.com Change-Id: I70100fe08584dd1049408d9b00f32b9aa28335d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004165 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Bot-Commit: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1380271}
-
Peter Boström authored
NOTREACHED() and NOTREACHED_IN_MIGRATION() are both CHECK-fatal now. The former is [[noreturn]] so this CL also performs dead-code removal after the NOTREACHED(). This CL does not attempt to do additional rewrites of any surrounding code, like: if (!foo) { NOTREACHED(); } to CHECK(foo); Those transforms take a non-trivial amount of time (and there are thousands of instances). Cleanup can be left as an exercise for the reader. Bug: 40580068 Change-Id: I53515b010e07581dcc4f25e06f946000d2eec259 Low-Coverage-Reason: OTHER Should-be-unreachable code Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6002137 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Peter Boström <pbos@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380270}
-
Asami Doi authored
Other changes related to this CL: ios public: this CL ios internal: https://chrome-internal-review.googlesource.com/c/chrome/ios_internal/+/7806127 google3: https://critique.corp.google.com/cl/693639409 Bug: 374076335 Change-Id: I8bbe95a60a3579366a5c11385af707c0cc9527d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5999533 Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Asami Doi <asamidoi@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380269}
-
Steinar H. Gunderson authored
Change-Id: Ied2d9d9860f1b8bc72e82b1fcd9c7cc89e8e7923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6001396 Reviewed-by:
Shunya Shishido <sisidovski@chromium.org> Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380268}
-
Steinar H. Gunderson authored
Change-Id: Iec7f4b7c388f18bd1f392c4a98364086128de4d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6001395 Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Shunya Shishido <sisidovski@chromium.org> Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380267}
-
Timofey Chudakov authored
Plus address surveys will be launched on Desktop and Android. To minimize the code duplication across platforms, this CL moves the logic of launching the surveys to the PlusAddressService. Next steps: add more plus address surveys. Bug: 348139343 Change-Id: I30fed91c8e87200a2b2b5e445809a2790806fb27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000534 Reviewed-by:
Rubin Deliallisi <rubindl@chromium.org> Commit-Queue: Timofey Chudakov <tchudakov@google.com> Reviewed-by:
Jan Keitel <jkeitel@google.com> Cr-Commit-Position: refs/heads/main@{#1380266}
-
chromium-internal-autoroll authored
Release_Notes: http://go/projector_app-x20/relnotes/Main/projector_app_202411080100_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/projector_app/app/+/uWzeS8L8TEFK4ZrnEcbpp6Z8QVjtGTTVn05TpLPT0nwC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/projector-app-chromium-autoroll Please CC cros-projector-oncall@grotations.appspotmail.com,cros-projector@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-chrome;luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: cros-projector-oncall@grotations.appspotmail.com Change-Id: Ib4737a59b18b77f32b805540a5d5c3ac464b3634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004529 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1380265}
-
Trevor Perrier authored
Remove The metadata field for autofill-caret-extraction which was not removed in https://crrev.com/c/5891512. Fixed: 373486423 Change-Id: I6059c333afa2dc4ef3b833f66a4c8325a9c331d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6003674 Reviewed-by:
Christoph Schwering <schwering@google.com> Auto-Submit: Trevor Perrier <perrier@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/main@{#1380264}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/ios_internal.git/+log/297fbf1b3134..00d01548c958 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/ios-internal-chromium-autoroll Please CC chrome-brapp-engprod@google.com,gambard@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md Bug: chromium:378039469 Change-Id: I69fe859e16a21c486fe92b3af8ef0b0268ff44eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6004167 Bot-Commit: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1380263}
-
Steinar H. Gunderson authored
Change-Id: Iee62acf223f9bcb39eff27d0f5ae491f4e389f69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6001394 Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Shunya Shishido <sisidovski@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380262}
-
Filipa Senra authored
Bug: 335387869 Change-Id: I344176a7fb62262208d45316b295d839c13b8f44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6002714 Auto-Submit: Filipa Senra <fsenra@google.com> Commit-Queue: Zaina Al-Mashni <zalmashni@google.com> Reviewed-by:
Zaina Al-Mashni <zalmashni@google.com> Cr-Commit-Position: refs/heads/main@{#1380261}
-
Steinar H. Gunderson authored
Change-Id: Ied1d7cec707a3ba3b10ddae09de5d1dc33768618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998702 Reviewed-by:
Daniil Sakhapov <sakhapov@google.com> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Daniil Sakhapov <sakhapov@chromium.org> Reviewed-by:
Shunya Shishido <sisidovski@chromium.org> Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380260}
-
Steinar H. Gunderson authored
Change-Id: I2d6b3750ffe235ec0fe4ccaa74328ba3c36529a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6000131 Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Shunya Shishido <sisidovski@chromium.org> Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380259}
-
Steinar H. Gunderson authored
Change-Id: I8885c31ef646470b29f9171980162f70bc4be662 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5998699 Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Shunya Shishido <sisidovski@chromium.org> Commit-Queue: Steinar H Gunderson <sesse@chromium.org> Cr-Commit-Position: refs/heads/main@{#1380258}
-