- May 18, 2018
-
-
Xavier Claessens authored
- Compiler checks were failing because it were using C compiler to build objc code. - xdgmime is needed on osx too. - -DGIO_COMPILATION must be passed to objc compiler too. - gapplication doesn't build on osx, it is excluded in autotools too. We have to be careful when we use add_project_link_arguments(): All targets are built using link arguments for the C language, except for libgio on osx which use the objc language, because it contains some ".m" source files. See https://github.com/mesonbuild/meson/issues/3585. https://bugzilla.gnome.org/show_bug.cgi?id=796214
-
Xavier Claessens authored
Those files got renamed to .c to work around an automake issue, but Meson needs them to have .m extension. Better rename them at build time in Makefile.am since that's where the workaround is needed. https://bugzilla.gnome.org/show_bug.cgi?id=672777
-
Xavier Claessens authored
-
-
- May 17, 2018
-
-
-
Philip Withnall authored
This could have caused spurious test failures when running with -Werror, due to the missing return statement in int main(). Signed-off-by: Philip Withnall <withnall@endlessm.com> Reviewed-by: nobody
-
Philip Withnall authored
Commit 3e96523e did not entirely fix the test, as the compiled test code did not have a main() function, so failed to link with: /usr/lib/gcc/x86_64-redhat-linux/7/../../../../lib64/crt1.o: In function `_start': (.text+0x20): undefined reference to `main' collect2: error: ld returned 1 exit status This caused an invalid mixtures of builtin and non-builtin atomics/locks to be used, which caused deadlocks in a number of tests. Fix the atomic ops test in meson.build, and the unit tests all start working again. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=796164
-
Philip Withnall authored
Spotted by Morten Welinder <mortenw@gnome.org>. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=796186
-
- May 16, 2018
-
-
Xavier Claessens authored
This allows building with posix threads on Windows. It is generally better to use win32 threads implementation on Windows, but this option can be used in case it causes issues, or for performance comparison for example. https://bugzilla.gnome.org/show_bug.cgi?id=784995
-
Xavier Claessens authored
win32_cflags gets used globally as cflags and exposed in the .pc file. win32_ldflags gets passed to glib-2.0 and exposed in the .pc file. This should match what the autotools build is currently doing with GLIB_EXTRA_CFLAGS and G_LIBS_EXTRA. https://bugzilla.gnome.org/show_bug.cgi?id=784995
-
Xavier Claessens authored
They are already handled properly by osx_ldflags. As far as I can tell it does the same as with autotools. https://bugzilla.gnome.org/show_bug.cgi?id=784995
-
Ondrej Holy authored
GVfsUDisks2VolumeMonitor handles x-gvfs-hide/x-gvfs-show mount options used to overwrite our heuristics whether the mount should be shown, or hidden. Unfortunately, it works currently only for mounts with corresponding fstab entries, because the options are read over g_unix_mount_point_get_options. Let's introduce g_unix_mount_get_options to allow reading of the options for all sort of mounts (e.g. created over pam_mount, or manually mounted). (Minor fixes to the documentation by Philip Withnall <withnall@endlessm.com>.) https://bugzilla.gnome.org/show_bug.cgi?id=668132
-
Philip Withnall authored
• A leak of filename on an error path • A leak of resolved_identifier if no out_identifier return location was provided The latter was spotted by Peter Bloomfield (https://gitlab.gnome.org/GNOME/glib/commit/8945227743a26a4fe6966baaf082dd6516e8a03c#note_111254 ). Thanks! Signed-off-by: Philip Withnall <withnall@endlessm.com> Reviewed-by: nobody
-
Nirbheek Chauhan authored
__MINGW32__ is defined on all MinGW variants including MinGW-w64. __MINGW64_VERSION_MAJOR is only defined on MinGW-w64. This difference is important because on MinGW-w64 we must #include winternl.h because including ntdef.h results in compiler errors about symbol redefinition, and the header warns that it is deprecated and may be removed in the future. https://bugzilla.gnome.org/show_bug.cgi?id=795849
-
Nirbheek Chauhan authored
-
- May 15, 2018
-
-
Xavier Claessens authored
On non-glibc platforms gettext is provided by extra libintl dependency. We wrongly thought libintl is an internal dependency and applications needs to explicitly link on it, but turns out that breaks many applications and with autotools the .pc generated actually has -lintl in public "Libs:". https://bugzilla.gnome.org/show_bug.cgi?id=796085
-
Philip Withnall authored
Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=789968
-
Philip Withnall authored
Do not add support for its subtypes, since all their constructors return GParamSpec*, and g_param_spec_unref() takes a GParamSpec* rather than a gpointer — adding G_DEFINE_AUTOPTR_CLEANUP_FUNC() for subtypes of GParamSpec results in compiler warnings about mismatched parameter types (GParamSpecBoolean* vs GParamSpec*, for example). Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=796139
-
Ondrej Holy authored
g_file_info_set_attribute mentions %G_ATTRIBUTE_TYPE_INVALID, but no such value exists. It should be %G_FILE_ATTRIBUTE_TYPE_INVALID. https://bugzilla.gnome.org/show_bug.cgi?id=796138
-
Philip Withnall authored
Signed-off-by: Philip Withnall <withnall@endlessm.com> Reviewed-by: nobody
-
- May 12, 2018
-
-
Kukuh Syafaat authored
-
- May 10, 2018
-
-
David Faure authored
This detects zero-sized files to return the special-case "application/x-zerosize" mime-type, as well as trying to differentiate unknown file types based on their first 128 bytes of data, so that text editors can automatically handle unknown text files. Based on: https://cgit.freedesktop.org/xdg/xdgmime/commit/?id=5181175d5fdaa3832b0fd094cda0120b1fe92af6 https://cgit.freedesktop.org/xdg/xdgmime/commit/?id=9c5802b8da56187c5c6abaf70042d14b12d832a9 https://bugzilla.gnome.org/show_bug.cgi?id=795544
-
- May 09, 2018
-
-
Philip Withnall authored
These make it easy to steal elements from pointer arrays without having the array’s GDestroyNotify called on them, similarly to what’s possible with g_hash_table_steal(). Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=795376
-
Philip Withnall authored
If using g_ptr_array_remove*() with a non-NULL GDestroyNotify function, the value returned will probably be freed memory (depending on what the GDestroyNotify) function actually does. Warn about that in the documentation. We can’t just unconditionally return NULL in these cases, though, since the user might have set the GDestroyNotify to a nifty function which doesn’t actually free the element; so returning it might still be valid and useful. Also add missing (nullable) annotations to that documentation. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=795376
-
Philip Withnall authored
They were almost identically the same. This introduces no functional changes, but will help with upcoming additions to GPtrArray. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=795376
-
Nirbheek Chauhan authored
We must try linking, not just compiling. That will give a false positive.
-
Nirbheek Chauhan authored
The compiler checks were being completely ignored.
-
Xavier Claessens authored
-z nodelete breaks the libresourceplugin module usage in the resources.c test, which expects to be able to unload it. Make the Meson build match what the autotools build does: only pass glib_link_flags to the headline libraries (glib-2.0, gio-2.0, gobject-2.0, gthread-2.0, gmodule-2.0) and omit it from all other build targets. https://bugzilla.gnome.org/show_bug.cgi?id=788771
-
Christian Hergert authored
The -fstack-protector-strong used in many distributions by default has a rather drastic slowdown of the fast path in generated _get_type() functions using G_DEFINE_* macros. The amount can vary by architecture, GCC version, and compiler flags. To work around this, and ensure a higher probability that our fast-path will match what we had previously, we need to break out the slow-path (registering the type) into a secondary function that is not a candidate for inlining. This ensures that the common case (type registered, return the GType id) is the hot path and handled in the prologue of the generated assembly even when -fstack-protector-strong is enabled. https://bugzilla.gnome.org/show_bug.cgi?id=795180
-
-
okimoto authored
It was deprecated in 2.30. https://bugzilla.gnome.org/show_bug.cgi?id=795960
-
- May 08, 2018
-
-
Philip Withnall authored
This is a combination of g_hash_table_lookup_extended() and g_hash_table_steal(), so that users can combine the two to reduce code and eliminate a pointless second hash table lookup by g_hash_table_steal(). Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=795302
-
Philip Withnall authored
Update our copy of valgrind.h from the Valgrind 3.13 release tarball. This seems to include fixes for PPC and Solaris. No changes made to the header file. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=736741
-
Philip Withnall authored
Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=748620
-
Philip Withnall authored
Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=748620
-
Philip Withnall authored
Make it a bit clearer that all lengths passed to GRegex methods are in bytes (not characters). This is mentioned in the section overview, but who reads that? Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=748620
-
- May 07, 2018
-
-
Philip Withnall authored
Signed-off-by: Philip Withnall <withnall@endlessm.com> Reviewed-by: nobody
-
Christoph Reiter authored
On Windows we use gnulib and elsewhere we use glibc or similar. Also change G_GNUC_PRINTF to use gnu_printf instead of __format__ if possible because __format__ evaluates to ms_printf under MinGW, but we use gnulib there and not the system printf. gnu_printf is only available with GCC>=4.4 and not with clang. https://bugzilla.gnome.org/show_bug.cgi?id=795569
-
- May 05, 2018
-
-
Matthew Leeds authored
-
- May 04, 2018
-
-
Philip Withnall authored
The existing implementation was completely incorrect (despite the fix in commit 566e64a6) — it always compared GVariants by pointer, rather than by value. Reimplement it to compare them by value where possible, depending on their type. The core of this implementation is g_variant_compare(). See the documentation and tests for further details of the new sort order. This adds documentation and tests. Signed-off-by: Philip Withnall <withnall@endlessm.com> https://bugzilla.gnome.org/show_bug.cgi?id=795735
-