Refactoring BufferedDataSource to work with WebURLLoader instead of a MediaResourceLoaderBridge.
Attempt #2 after fixing some race conditions between Initialize() and Abort() (see r68363). One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource. In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag. Patch by annacc@chromium.org: http://codereview.chromium.org/3863002/ BUG=16751 TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered* src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple* src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68378 0039d316-1c4b-4281-b951-d872f2087c98
Showing
- chrome/renderer/render_view.cc 4 additions, 24 deletionschrome/renderer/render_view.cc
- webkit/glue/media/buffered_data_source.cc 197 additions, 112 deletionswebkit/glue/media/buffered_data_source.cc
- webkit/glue/media/buffered_data_source.h 70 additions, 37 deletionswebkit/glue/media/buffered_data_source.h
- webkit/glue/media/buffered_data_source_unittest.cc 97 additions, 130 deletionswebkit/glue/media/buffered_data_source_unittest.cc
- webkit/glue/media/simple_data_source.cc 92 additions, 35 deletionswebkit/glue/media/simple_data_source.cc
- webkit/glue/media/simple_data_source.h 48 additions, 24 deletionswebkit/glue/media/simple_data_source.h
- webkit/glue/media/simple_data_source_unittest.cc 42 additions, 53 deletionswebkit/glue/media/simple_data_source_unittest.cc
- webkit/glue/mock_webframe.h 352 additions, 0 deletionswebkit/glue/mock_webframe.h
- webkit/glue/mock_weburlloader_impl.h 36 additions, 0 deletionswebkit/glue/mock_weburlloader_impl.h
- webkit/glue/multipart_response_delegate.cc 34 additions, 10 deletionswebkit/glue/multipart_response_delegate.cc
- webkit/glue/multipart_response_delegate.h 2 additions, 1 deletionwebkit/glue/multipart_response_delegate.h
- webkit/glue/multipart_response_delegate_unittest.cc 12 additions, 4 deletionswebkit/glue/multipart_response_delegate_unittest.cc
- webkit/glue/plugins/webplugin_impl.cc 3 additions, 1 deletionwebkit/glue/plugins/webplugin_impl.cc
- webkit/glue/webmediaplayer_impl.cc 3 additions, 4 deletionswebkit/glue/webmediaplayer_impl.cc
- webkit/glue/webmediaplayer_impl.h 5 additions, 2 deletionswebkit/glue/webmediaplayer_impl.h
- webkit/support/webkit_support.cc 4 additions, 25 deletionswebkit/support/webkit_support.cc
- webkit/tools/test_shell/test_shell.gypi 2 additions, 0 deletionswebkit/tools/test_shell/test_shell.gypi
- webkit/tools/test_shell/test_webview_delegate.cc 4 additions, 25 deletionswebkit/tools/test_shell/test_webview_delegate.cc
Loading
Please register or sign in to comment