Attempt #2 after fixing some race conditions between Initialize() and Abort() (see r68363).

One thing to notice is that both buffered_data_source_unittest and simple_data_source_unittest need to have a way to inject a MockWebURLLoader into the BufferedResourceLoader and the SimpleDataSource.  In order to make sure a new one is not created during a Start(), I introduced the function SetURLLoaderForTest and keep_test_loader flag.

Patch by annacc@chromium.org:
http://codereview.chromium.org/3863002/

BUG=16751
TEST=src/xcodebuild/Debug/test_shell_tests --gtest_filter=Buffered*
src/xcodebuild/Debug/test_shell_tests --gtest_filter=Simple*
src/webkit/tools/layout_tests/run_webkit_tests.sh --debug media
webkit/tools/layout_tests/run_webkit_tests.sh --debug http/tests/media

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68378 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68377 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65642
TEST=Valgrind unit tests go green.
TBR=bauerb
Review URL: http://codereview.chromium.org/5556009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68375 0039d316-1c4b-4281-b951-d872f2087c98

CID=8391,8392,8526,8527,11212,11213,12566,12567,
    12610,12611,13934,13935,13936,13937
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5577003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68374 0039d316-1c4b-4281-b951-d872f2087c98

BUG=static compile doesn't work with 'touchui=1 chromeos=1'
TEST=static compile should work with 'touchui=1 chromeos=1'

Review URL: http://codereview.chromium.org/5515007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68373 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65203
TEST=Open a DOMUI pref subpage; there should be a close button in the upper-right.

Review URL: http://codereview.chromium.org/5518006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68372 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65642
TEST=Heapchecker goes green.
Review URL: http://codereview.chromium.org/5559008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68371 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65464
TEST=Type "hello" into the omnibox.  When the suggestion appears, press right (or tab).  Suggest text should turn black.
Review URL: http://codereview.chromium.org/5556007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68370 0039d316-1c4b-4281-b951-d872f2087c98

There are two reasons that cause this problem:
1. See issue http://crbug.com/65375
2. By some reason, when BrowserWindowCocoa::PreHandleKeyboardEvent() is
called for Cmd-W, it fails to get its corresponding command id, because
the corresponding menu item is not enabled at that time.

This CL does following changes:
1. Change testing flow to work around issue 65375.
2. Fix the second problem by always retrieving the corresponding command
id regardless of the menu item's state.

The reason of the second issue:
When Cmd-T gets handled in NSApp, BrowserWindowController's -validateUserInterfaceItem: method will be called for all menu items to determine their enable states and the states will be cached in each menu item. At this time, because there is only one tab, the "Close Tab" menu item will be disabled.
Then when sending Cmd-W to the browser, it'll firstly be handled in BrowserWindowCocoa::PreHandleKeyboardEvent() method, which will look up the
command id associated to Cmd-W, but at this time, BrowserWindowController's -validateUserInterfaceItem: method does not get called yet, so the corresponding menu item is still not enabled. Then BrowserWindowCocoa::PreHandleKeyboardEvent() will not handle Cmd-W because it
cannot find its command id.

After removing the check in cr_firesForKeyEvent method, BrowserWindowCocoa::PreHandleKeyboardEvent() method will always get the correct command id of a key equivalent regardless of its enable state, then if it's a reserved key equivalent, it will always be sent to NSApp for handling, which will call BrowserWindowController's -validateUserInterfaceItem: to update the enable states of all menu items. Then if the corresponding menu item is really disabled, NSApp will do nothing and return false, then the key event will be dispatched to web page as normal.

BUG=50447 BrowserKeyEventsTest.ReservedAccelerators failed on Mac10.6 Tests (dbg)(1) bot.
TEST=The test should not flaky.

Review URL: http://codereview.chromium.org/5576002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68369 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yutak
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68368 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5556008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68367 0039d316-1c4b-4281-b951-d872f2087c98

This makes us ignore out_* (per-board output directories,
e.g. out_x86-generic) and c (a symlink created by the Chrome
OS ebuild to limit the length of some command lines).

BUG=chromium-os:7967
TEST=ran "git status"

Review URL: http://codereview.chromium.org/5535005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68366 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68365 0039d316-1c4b-4281-b951-d872f2087c98

With -webkit-{margin,padding}-{start,end}, a lot of dir=rtl pseudo-selectors
can be removed. 

While I'm at it, I fixed one glitch in the history page where 'text-align: right' is hard-coded instead of 'text-align: end'

BUG=NONE
TEST=extension/download/plugin/history and DOM UI pages are laid out as before both in LTR CHrome and RTL Chrome.


Review URL: http://codereview.chromium.org/5217005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68364 0039d316-1c4b-4281-b951-d872f2087c98

Previously we were using it as a DCHECK but we would fail gracefully.  Now that stopped_on_render_loop_ is set via Abort() (i.e., catastrophic failure), we need to use it as a singal to make sure all work on the render loop does indeed stop.

BUG=16751
TEST=http/tests/media should stop crashing

Review URL: http://codereview.chromium.org/5603004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68363 0039d316-1c4b-4281-b951-d872f2087c98

If compositor window already exists, then simply return it rather than complaining. May affect how bug 65194 manifests.

BUG=65194
TEST=Verify against WebGL demos, poster circle content with tab opening and closing, as well as killing of GPU process.

Review URL: http://codereview.chromium.org/5528007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68362 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65129
TEST=unit_tests --gtest_filter=WebDatabaseTest.Update*

Review URL: http://codereview.chromium.org/5610002

TBR=isherman@chromium.org
Review URL: http://codereview.chromium.org/5515006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68360 0039d316-1c4b-4281-b951-d872f2087c98

TBR=amit
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5515005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68359 0039d316-1c4b-4281-b951-d872f2087c98

BUG=65129
TEST=unit_tests --gtest_filter=WebDatabaseTest.Update*

Review URL: http://codereview.chromium.org/5610002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68358 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yutak
TESt=none
BUG=65404


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68357 0039d316-1c4b-4281-b951-d872f2087c98

Make http connection for cupsGetPPD non-blocking to prevent that.

BUG=none
TEST=Make sure GettPPD does not get stuck.

Review URL: http://codereview.chromium.org/5609004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68356 0039d316-1c4b-4281-b951-d872f2087c98

This is a redesign for http://codereview.chromium.org/4852002/ following discussions.

The goal of this patch is to ensure that Chrome maintains the order in which extensions apply their preferences between restarts. This may be an issue if two extensions overwrite each others preferences. Furthermore, it ensures that preferences are persisted to disk between browser restarts. Therefore, previous settings are immediately available when the browser is restarted.

A description of the design has been published https://docs.google.com/a/google.com/document/d/1E_HX_cUpET1gH2gDunGIU1EOywMM6FEOuVU6TlpnSwo/edit?hl=en for review and comments. - Sorry, accessible Google internally only.

This CL requires http://codereview.chromium.org/5204006/

Contributed by battre@google.com

BUG=50726
TEST=none

Review URL: http://codereview.chromium.org/5213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68355 0039d316-1c4b-4281-b951-d872f2087c98

instant.

BUG=65206
TEST=see bug

Review URL: http://codereview.chromium.org/5631001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68354 0039d316-1c4b-4281-b951-d872f2087c98

TBR=yutak
TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68353 0039d316-1c4b-4281-b951-d872f2087c98

implementation via new glGetRequestableExtensionsCHROMIUM and
glRequestExtensionCHROMIUM entry points. These entry points are needed in
order to allow WebGL to both query the available extensions and enable them
individually.

Added these entry points to WebGraphicsContext3DCommandBufferImpl. A
subsequent WebKit checkin under https://bugs.webkit.org/show_bug.cgi?id=40316
will utilize them and implement the OES_texture_float extension for WebGL.

BUG=none
TEST=none (ran with new oes-texture-float.html WebGL conformance test)

Review URL: http://codereview.chromium.org/5626008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68352 0039d316-1c4b-4281-b951-d872f2087c98

I missed some comments from wtc on patch http://codereview.chromium.org/5195001 before landing, so following up here.

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/5587001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68351 0039d316-1c4b-4281-b951-d872f2087c98

contributed by battre@google.com

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5204006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68350 0039d316-1c4b-4281-b951-d872f2087c98

Fix for the following bug:
[11725:11725:1206/035953:10306309386:ERROR:base/process_util_posix.cc(105)] Received signal 11
base::debug::StackTrace::StackTrace() [0x1f68261]
base::(anonymous namespace)::StackDumpSignalHandler() [0x1fa2853]
0x2ba8f9b0f100
__pthread_mutex_lock_internal [0x2ba8f6dce423]
LockImpl::Lock() [0x1f7a9f6]
Lock::Acquire() [0x58a947]
AutoLock::AutoLock() [0x58a979]
MessageLoop::PostTask_Helper() [0x1f7e2cc]
MessageLoop::PostDelayedTask() [0x1f7e40d]
WebResourceService::ScheduleNotification() [0x158db6f]
WebResourceService::UnpackPromoSignal() [0x158e1db]
WebResourceServiceTest_UnpackPromoSignal_Test::TestBody() [0xcbb723]
testing::HandleExceptionsInMethodIfSupported<>() [0x1b6ff6b]
testing::Test::Run() [0x1b72cb9]
testing::TestInfo::Run() [0x1b76548]
testing::TestCase::Run() [0x1b7669b]
testing::internal::UnitTestImpl::RunAllTests() [0x1b771f0]
testing::HandleExceptionsInMethodIfSupported<>() [0x1b6fd4f]
testing::UnitTest::Run() [0x1b6fdb7]
base::TestSuite::Run() [0x33ed0a8]
main [0x1a4f56d]
0x2ba8f9afb1c4
0x433829

Program received signal SIGSEGV, Segmentation fault.
__pthread_mutex_lock (mutex=0x170) at pthread_mutex_lock.c:50
50      pthread_mutex_lock.c: No such file or directory.
        in pthread_mutex_lock.c
(gdb) bt
#0  __pthread_mutex_lock (mutex=0x170) at pthread_mutex_lock.c:50
#1  0x00007ffff5ac327d in LockImpl::Lock (this=0x170) at base/lock_impl_posix.cc:41
#2  0x00007ffff5a85dee in Lock::Acquire (this=0x168) at ./base/lock.h:40
#3  0x00007ffff5a85e50 in AutoLock::AutoLock (this=0x7fffffffd450, lock=...) at ./base/lock.h:95
#4  0x00007ffff5ac7a16 in MessageLoop::PostTask_Helper (this=0x0, from_here=..., task=0x7fffe29a8e00, delay_ms=1974154931, nestable=true)
    at base/message_loop.cc:378
#5  0x00007ffff5ac7816 in MessageLoop::PostDelayedTask (this=0x0, from_here=..., task=0x7fffe29a8e00, delay_ms=1974154931) at base/message_loop.cc:318
#6  0x00007ffff77009e1 in WebResourceService::ScheduleNotification (this=0x7fffe41ed4e0, promo_start=1264899600, promo_end=1327971600)
    at chrome/browser/web_resource/web_resource_service.cc:285

Note how this is NULL in MessageLoop::PostDelayedTask.

Patch from Dominic Battré (battre@google.com)

BUG=65462
TEST=none
TBR=mirandac

Review URL: http://codereview.chromium.org/5559007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68349 0039d316-1c4b-4281-b951-d872f2087c98

Don't test the killbit in each ExternalExtensionProvider, but test it in ExternalExtensionsService.

BUG=65107
TEST=ExtensionManagementTest.ExternalUpdate

Review URL: http://codereview.chromium.org/5535002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68348 0039d316-1c4b-4281-b951-d872f2087c98

Address review comments from Nico and add a separating line as
requested by Glen.

BUG=51105
TEST=None

Review URL: http://codereview.chromium.org/5640001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68346 0039d316-1c4b-4281-b951-d872f2087c98

TBR=victorw
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5653001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68345 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:7295
TEST=Login with a new user, lock screen on profile picture step, sign out, login as the same user, verify there's no crash infobar shown.

Review URL: http://codereview.chromium.org/5600001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68344 0039d316-1c4b-4281-b951-d872f2087c98

Changed the static call of SQLitePersistantCookieStore::ClearLocalState to
a call of a virtual method PersistantCookieStore::ClearLocalState from
inside the destruction sequence of the owning UrlRequestContext.

Thus the code will now work with any other persistancy implementation and
allow for better parallelism.

To test. Enable deleting of cookies and user data on shutdown and check if
the Cookies file in the profile directory has been deleted.

BUG=64920
TEST=Manual.

Review URL: http://codereview.chromium.org/5430004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68343 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68339 0039d316-1c4b-4281-b951-d872f2087c98

The description for IDS_ABOUT_PAGE_TITLE (Title used for about options panel)
was ambiguous enough to confuse translators:

1. Title used for <about> <options panel>  (original intention)
2. Title used for <about options> panel (misunderstanding)

And unfortunately for Japanese, 2 was translated.
2 ways to fix this, clarify the description or use IDS_ABOUT.

As title on the wrench menu use IDS_ABOUT ("About &PRODUCT_NAME"),
using IDS_ABOUT for the title for the options panel makes sense.

BUG=none
TEST=manually open chrome://settings/about (or wrench menu -> about) and see tht title displayed properly.

Review URL: http://codereview.chromium.org/5567001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68336 0039d316-1c4b-4281-b951-d872f2087c98

BUG=51822
TEST=Webkit Linux (valgrind layout) goes green.
TBR=evan
Review URL: http://codereview.chromium.org/5586005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68335 0039d316-1c4b-4281-b951-d872f2087c98

TBR=victorw
BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5606006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68334 0039d316-1c4b-4281-b951-d872f2087c98

When viewing a certificate on Linux, if the certificate has a CRL Distribution Point extension, display all of the URIs contained, rather than only the first.

BUG=64565
TEST=none

Review URL: http://codereview.chromium.org/5372003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68333 0039d316-1c4b-4281-b951-d872f2087c98

When using NSS for certificate verification, add a check when fetching CRLs/OCSP responses to prevent redirects to non-HTTP URLs. This matches the initial check when first called from NSS to create the URLRequest.

In particular, fetching a CRL/OCSP response over HTTPS is troublesome, as the certificate sent by the responder may also need revocation checking, potentially causing revocation checking loops.

The existing check only considered the initial URL scheme supplied by NSS. However, if the server issues a redirect, the new URL scheme scheme was not filtered.

BUG=64521
TEST=none

Review URL: http://codereview.chromium.org/5372002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68329 0039d316-1c4b-4281-b951-d872f2087c98

BUG=31526
BUG=60840
TEST=TaskManagerBrowserTest.NoticeExtensionTabs
TEST=TaskManagerBrowserTest.NoticeAppTabs

Review URL: http://codereview.chromium.org/5526002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@68324 0039d316-1c4b-4281-b951-d872f2087c98