Skip to content
Snippets Groups Projects
Commit bf865be0 authored by ananta@chromium.org's avatar ananta@chromium.org
Browse files

Disable the ChromeFrame Firefox tests on Windows 7 due to a bug in Firefox causing it to crash

on startup after the machine has been running for a while. For the curious the crash occurs
in the tab preview code in Firefox which only executes on Windows 7 and executes even if
we disable tab preview.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/5745008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@69218 0039d316-1c4b-4281-b951-d872f2087c98
parent cb550777
No related merge requests found
......@@ -226,6 +226,11 @@ void ChromeFrameTestWithWebServer::SimpleBrowserTestExpectedResult(
void ChromeFrameTestWithWebServer::SimpleBrowserTest(BrowserKind browser,
const wchar_t* page) {
if (browser == FIREFOX &&
base::win::GetVersion() == base::win::VERSION_WIN7) {
LOG(INFO) << "Not running Firefox tests on Windows 7";
return;
}
SimpleBrowserTestExpectedResult(browser, page, "OK");
}
......@@ -244,6 +249,12 @@ void ChromeFrameTestWithWebServer::OptionalBrowserTest(BrowserKind browser,
void ChromeFrameTestWithWebServer::VersionTest(BrowserKind browser,
const wchar_t* page) {
if (browser == FIREFOX &&
base::win::GetVersion() == base::win::VERSION_WIN7) {
LOG(INFO) << "Not running Firefox tests on Windows 7";
return;
}
FilePath plugin_path;
PathService::Get(base::DIR_MODULE, &plugin_path);
plugin_path = plugin_path.AppendASCII("servers");
......@@ -291,6 +302,12 @@ void ChromeFrameTestWithWebServer::SessionIdTest(BrowserKind browser,
const wchar_t* page,
int privilege_mode,
const char* expected_result) {
if (browser == FIREFOX &&
base::win::GetVersion() == base::win::VERSION_WIN7) {
LOG(INFO) << "Not running Firefox tests on Windows 7";
return;
}
SetConfigInt(kEnableFirefoxPrivilegeMode, privilege_mode);
EXPECT_TRUE(LaunchBrowser(browser, page));
server_mock_.set_expected_result(expected_result);
......@@ -1052,13 +1069,6 @@ TEST_F(ChromeFrameTestWithWebServer, FullTabModeIE_WindowClose) {
}
TEST_F(ChromeFrameTestWithWebServer, FullTabModeFF_WindowClose) {
// Please see http://code.google.com/p/chromium/issues/detail?id=60987
// for more information on why this test is disabled for Vista with IE7.
if (base::win::GetVersion() == base::win::VERSION_VISTA &&
chrome_frame_test::GetInstalledIEVersion() == IE_7) {
LOG(INFO) << "Not running test on Vista with IE7";
return;
}
SimpleBrowserTest(FIREFOX, kWindowCloseTestUrl);
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment